Permalink
Branch: master
Commits on Oct 3, 2018
  1. doc: move gibfahn to TSC Emeritus

    gibfahn authored and Trott committed Oct 3, 2018
    PR-URL: #23238
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 9, 2018
  1. build: update arm64 minimum supported platform

    gibfahn committed Mar 6, 2018
    This is already true in practice.
    
    PR-URL: #19164
    Fixes: nodejs/build#1164
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Mar 7, 2018
  1. 2018-03-06 Version 8.10.0 'Carbon' (LTS)

    gibfahn committed Jan 24, 2018
    Notable changes:
    
    * deps:
      * update V8 to 6.2.414.46 (Michaël Zasso) [#16413](#16413)
      * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [#16413](#16413)
      * upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260)
      * re land npm 5.6.0 (Myles Borins) [#18625](#18625)
      * ICU 60 bump (Steven R. Loomis) [#16876](#16876)
    * crypto:
      * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [#16130](#16130)
      * warn on invalid authentication tag length (Tobias Nießen) [#17566](#17566)
    * async_hooks:
      * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [#18004](#18004)
      * use typed array stack as fast path (Anna Henningsen) [#17780](#17780)
      * use scope for defaultTriggerAsyncId (Andreas Madsen) [#17273](#17273)
      * separate missing from default context (Andreas Madsen) [#17273](#17273)
      * rename initTriggerId (Andreas Madsen) [#17273](#17273)
      * deprecate undocumented API (Andreas Madsen) [#16972](#16972)
      * add destroy event for gced AsyncResources (Sebastian Mayr) [#16998](#16998)
      * add trace events to async_hooks (Andreas Madsen) [#15538](#15538)
      * set HTTPParser trigger to socket (Andreas Madsen) [#18003](#18003)
      * add provider types for net server (Andreas Madsen) [#17157](#17157)
    * n-api:
      * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
    * cli:
      * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [#16495](#16495)
    * console:
      * add support for console.debug (Benjamin Zaslavsky) [#17033](#17033)
    * module:
      * add builtinModules (Jon Moss) [#16386](#16386)
      * replace default paths in require.resolve() (cjihrig) [#17113](#17113)
    * src:
      * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
      * add process.ppid (cjihrig) [#16839](#16839)
    * http:
      * support generic `Duplex` streams (Anna Henningsen) [#16267](#16267)
      * add rawPacket in err of `clientError` event (XadillaX) [#17672](#17672)
      * better support for IPv6 addresses (Mattias Holmlund) [#14772](#14772)
    * net:
      * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [#17662](#17662)
    * process:
      * fix reading zero-length env vars on win32 (Anna Henningsen) [#18463](#18463)
    * tls:
      * unconsume stream on destroy (Anna Henningsen) [#17478](#17478)
    * process:
      * improve unhandled rejection message (Madara Uchiha) [#17158](#17158)
    * stream:
      * remove usage of *State.highWaterMark (Calvin Metcalf) [#12860](#12860)
    * trace_events:
      * add executionAsyncId to init events (Andreas Madsen) [#17196](#17196)
    
    PR-URL: #18336
Commits on Feb 16, 2018
  1. doc: note that linting is required in releases.md

    gibfahn authored and BridgeAR committed Feb 14, 2018
    Refs: #18769
    
    PR-URL: #18776
    Refs: #18769
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 3, 2018
  1. doc: remove x86 from os.arch() options

    gibfahn committed Dec 28, 2017
    It is not possible for `process.arch` (which comes from V8's
    `target_arch`) to be `x86`.
    
    Also updates `process.arch` to have the same information.
    
    PR-URL: #17899
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  2. 2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release

    gibfahn committed Dec 20, 2017
    PR-URL: #17774
    
    Notable Changes:
    
    * deps:
      * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
    * build:
      * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)
Commits on Dec 10, 2017
  1. build: allow running configure from any directory

    gibfahn committed Nov 26, 2017
    PR-URL: #17321
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Dec 9, 2017
  1. build: add a `make help` option for common targets

    gibfahn committed Nov 26, 2017
    PR-URL: #17323
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Dec 5, 2017
  1. 2017-12-05, Version 8.9.2 'Carbon' (LTS)

    gibfahn committed Nov 21, 2017
    Notable Changes:
    
    - **console**:
      - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n
    de/pull/16770)
    - **http2**:
      - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej
    s/node/pull/16718)
    
    PR-URL: #17204
Commits on Nov 22, 2017
  1. test,doc: document where common modules go

    gibfahn authored and jasnell committed Oct 8, 2017
    Keep the `require('../common')` separate from other common modules, as
    it's the only line that must be there.
    
    PR-URL: #16089
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Nov 20, 2017
  1. tools: allow running test.py without configuring

    gibfahn committed Oct 30, 2017
    If config.gypi isn't defined, assume Node was build the default way,
    i.e. with the inspector.
    
    PR-URL: #16621
    Refs: #16436 (comment)
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  2. test: make debugging of inspector-port-zero easier

    gibfahn committed Nov 2, 2017
    If the process was killed, then the exit code will be null, in which
    case knowing the signal is really helpful.
    
    PR-URL: #16685
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  3. src: add NODE_VERSION_IS_LTS to node_version.h

    gibfahn committed Nov 2, 2017
    This is defined in LTS releases, but should really be defined in master
    too.
    
    PR-URL: #16697
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Nov 7, 2017
  1. 2017-11-07, Version 8.9.1 'Carbon' (LTS)

    gibfahn committed Nov 5, 2017
    Notable Changes:
    
    - **openssl**:
      - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691)
    - ***Revert*** "**https**:
      - refactor to use http internals" (Myles Borins) [#16660](#16660)
    
    PR-URL: #16783
Commits on Nov 2, 2017
  1. doc: add nodejs/gyp team for GYP related issues

    gibfahn committed Oct 31, 2017
    PR-URL: #16638
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  2. build: suppress lint-md output

    gibfahn committed Oct 27, 2017
    We don't need to print out the output if we've already installed it, at
    the same time we do want to see some output when we haven't installed.
    
    PR-URL: #16551
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
  3. doc: fix Changelog link order

    gibfahn authored and XadillaX committed Oct 31, 2017
    PR-URL: #16632
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Brian White <mscdex@mscdex.net>
Commits on Oct 31, 2017
  1. 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release

    gibfahn committed Oct 31, 2017
    This LTS release comes with 87 commits. This includes 30 that are
    updates to lib/ or src/, 20 that are test related, 13 that are doc
    related, 19 which are build / tools related, and 4 commits which are
    updates to dependencies.
    
    Notable Changes:
    
    * doc:
      - add Gibson Fahnestock to Release team (Gibson Fahnestock)
        #16620
    * deps:
      - update npm to 5.5.1 (Myles Borins)
        #16509
    * http2:
      - The exposed http2 socket is no longer manipulatable
        (Anatoli Papirovski)
        #16330
    * module:
      - support custom paths to require.resolve() (cjihrig)
        #16397
    * util:
      - util.TextEncoder and util.TextDecoder are no longer experimental.
        There will no longer be a warning when they are used
        (James M Snell)
        #15743
    
    PR-URL: #16630
  2. doc: add Gibson Fahnestock to Release team

    gibfahn authored and MylesBorins committed Oct 30, 2017
    PR-URL: #16620
    Refs: nodejs/TSC#350
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on Oct 27, 2017
  1. test: skip test-process-config if no config.gypi

    gibfahn committed Oct 20, 2017
    If you run the tests in a different machine to the one you built on,
    this test will fail. Avoid this by skipping if the file doesn't exist.
    We shouldn't need to check that the file exists in this test, as the
    build won't pass without a config.gypi anyway.
    
    Also adds console.logs, so you can see what the actual difference
    between the objects was, as `assert.deepStrictEqual()` only shows you
    the first three lines.
    
    PR-URL: #16436
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Oct 22, 2017
  1. test: handle blank shells in test-os.js

    gibfahn committed Oct 18, 2017
    The shell in /etc/passwd can be blank, in which case the user is given
    the default shell. Handle this by only checking the shell contains a
    path separator if the string isn't empty.
    
    PR-URL: #16287
    Fixes: #15684
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Commits on Oct 19, 2017
  1. test: update test-npm to use test-npm-package.js

    gibfahn committed Feb 22, 2017
    Deletes the old test-npm.sh script.
    
    PR-URL: #11540
    Refs: #7867
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Oct 13, 2017
  1. doc: include V8 commit URL in V8 backport guide

    gibfahn authored and joyeecheung committed Oct 6, 2017
    Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL.
    
    Refs: #16053 (comment)
    PR-URL: #16054
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 28, 2017
  1. doc: standardize function param/object prop style

    gibfahn authored and BridgeAR committed Jun 18, 2017
    PR-URL: #13769
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Sep 26, 2017
  1. crypto: only try to set FIPS mode if different

    gibfahn committed Apr 4, 2017
    Turning FIPS mode on (or off) when it's already on (or off) should be a
    no-op, not an error.
    
    PR-URL: #12210
    Fixes: #11849
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 21, 2017
  1. build: don't fail `make test` on source tarballs

    gibfahn authored and BridgeAR committed Sep 16, 2017
    Tries to achieve the same effect as
    #13658 without breaking source
    tarballs. Presumably if `tools/eslint` wasn't there at all, people
    would notice in the PR review!
    
    PR-URL: #15441
    Fixes: #14513
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 3, 2017
  1. test: remove envPlus, use Object.assign everywhere

    gibfahn authored and BridgeAR committed Aug 15, 2017
    PR-URL: #14845
    Fixes: #14823
    Refs: #14822
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Aug 12, 2017
  1. test: allow inspector to reopen with same port

    gibfahn committed Jul 17, 2017
    Test checks that if you open the inspector with '0' (pick a random free
    port), close it, then reopen it, you get a different port. However this
    isn't necessarily true.
    
    PR-URL: #14320
    Fixes: #14316
    Refs: #14316 (comment)
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jul 17, 2017
  1. doc: move LTS README link to increase prominence

    gibfahn authored and jasnell committed Jul 16, 2017
    PR-URL: #14259
    Fixes: #10718
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 29, 2017
  1. doc: note that fs.futimes only works on AIX >7.1

    gibfahn authored and jasnell committed Jun 13, 2017
    PR-URL: #13659
    Fixes: #12609
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> i
Commits on Jun 16, 2017
  1. build: fail linter if linting not available

    gibfahn authored and jasnell committed Jun 13, 2017
    PR-URL: #13658
    Ref: #13645 (comment)
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Commits on Jun 14, 2017
  1. doc: note that EoL platforms are not supported

    gibfahn committed Apr 26, 2017
    Add a note to clarify that any platform that is EoL will not be
    supported by Node.js.
    
    PR-URL: #12672
    Fixes: nodejs/build#688
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
Commits on Jun 7, 2017
  1. test: pass env vars through to test-benchmark-http

    gibfahn committed Jun 2, 2017
    Allows NODE_TEST_DIR to be set (necessary to avoid path length issues
    with common.PIPE).
    
    PR-URL: #13390
    Refs: #12708 (comment)
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  2. tools, test: update test-npm-package paths

    gibfahn committed Jun 3, 2017
    Makes the same changes as
    9946173
    to update the test runner for npm5.
    
    PR-URL: #13441
    Refs: #12936
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Jun 3, 2017
  1. doc: suggest xcode-select --install

    gibfahn committed May 28, 2017
    If you don't have the full Xcode installed, the command-line tools are
    all you need.
    
    PR-URL: #13264
    Fixes: #6449
    Refs: #9215
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>