Skip to content
Permalink
Branch: master
Commits on Aug 23, 2017
  1. gyp: inherit parent for `*.host`

    jbergstroem authored and refack committed Apr 13, 2016
    Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
    suitable for environments that only uses the clang toolchain.
    
    Since we already assume that the user will provide clang/clang++
    through CC/CXX, lean against it (then drop to gcc/g++).
    
    Also apply the same logic for link/ar for consistency although
    it doesn't affect us.
    
    PR-URL: #6173
    Fixes: #6152
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Apr 18, 2017
  1. gyp: inherit parent for `*.host`

    jbergstroem authored and refack committed Apr 13, 2016
    Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
    suitable for environments that only uses the clang toolchain.
    
    Since we already assume that the user will provide clang/clang++
    through CC/CXX, lean against it (then drop to gcc/g++).
    
    Also apply the same logic for link/ar for consistency although
    it doesn't affect us.
    
    PR-URL: #6173
    Fixes: #6152
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Nov 10, 2016
  1. gitignore: ignore all tap files

    jbergstroem committed Oct 25, 2016
    We now have multiple tap producers; just ignore all
    files with the `.tap` extension.
    
    PR-URL: #9262
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
  2. gtest: output tap comments as yamlish

    jbergstroem committed Oct 25, 2016
    This makes yaml-ish parsers happy.
    Note: gtest still seems to output the expected/result slightly
    different making the full traceback less informational.
    
    PR-URL: #9262
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
  3. test: output tap13 instead of almost-tap

    jbergstroem committed Oct 12, 2016
    Produce a tap13-compatible output which makes it
    simpler to parse. Output is still readable by
    the jenkins tap plugin.
    
    PR-URL: #9262
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
Commits on Sep 1, 2016
  1. build: don't require processing docs for nightlies

    jbergstroem committed Aug 29, 2016
    Opt-out `nightly` and `next-nightly` from the documentation
    requirement since these docs aren't meant to be published.
    
    This fixes our nightly jobs in CI.
    
    PR-URL: #8325
    Fixes: nodejs/build#478
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Apr 30, 2016
  1. build: use shorthand lint target from test

    jbergstroem committed Apr 27, 2016
    Instead of invoking jslint/cpplint from the test target,
    call on the generic lint instead since it checks if eslint
    exists. Since our tarballs lacks eslint we now get a more graceful
    exit from `make test` instead of a traceback from jslint.
    
    PR-URL: #6406
    Fixes: #6408
    Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Apr 24, 2016
  1. gyp: inherit parent for `*.host`

    jbergstroem committed Apr 13, 2016
    Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
    suitable for environments that only uses the clang toolchain.
    
    Since we already assume that the user will provide clang/clang++
    through CC/CXX, lean against it (then drop to gcc/g++).
    
    Also apply the same logic for link/ar for consistency although
    it doesn't affect us.
    
    PR-URL: #6173
    Fixes: #6152
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Apr 16, 2016
  1. build: allow test-ci to run tests in parallel

    jbergstroem committed Apr 15, 2016
    Run tests in parallel if the environment variable JOBS
    (which should contain a number of parallel jobs) is set.
    
    PR-URL: #6208
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Apr 5, 2016
  1. doc: improve github templates by using comments

    jbergstroem committed Mar 15, 2016
    Use HTML comments to reduce potential noise in github templates.
    Also, improve flow of the pull request, making it easier to read.
    
    PR-URL: #5710
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
  2. deps: reintroduce supporting shared c-ares builds

    jbergstroem committed Mar 17, 2016
    As of cc192f0 we've now in sync with upstream which means that we
    also can allow our users to build against a shared version of c-ares.
    
    Note: It is still up to users to make sure that the library version
    is on par with what Node.js bundles.
    
    This "reverts" commit 25fa5c4.
    
    PR-URL: #5775
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Apr 1, 2016
  1. build: introduce ci targets for lint/benchmark

    jbergstroem authored and jasnell committed Mar 27, 2016
    Introduce two new targets we will populate with actions
    once merged into all branches we need to support through CI.
    
    PR-URL: #5921
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 16, 2016
  1. build: remove lint/dotfiles from release tarball

    jbergstroem committed Mar 13, 2016
    This removes the ability to run linting from the source tarball,
    rationale being that developers should use a git clone instead.
    
    Also, fix the path of removing artifacts from the openssl dependency
    since it now lives in `deps/openssl/openssl/`.
    
    Tarballs shrink with ~10%.
    
    PR-URL: #5695
    Fixes: #5618
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
    Reviewed-By: James Snell <jasnell@gmail.com>
Commits on Mar 13, 2016
  1. doc: move build instructions to a new document

    jbergstroem committed Mar 9, 2016
    This makes README.md easier to consume and likely less
    confusing for people that get it as part of a binary download.
    
    PR-URL: #5634
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 9, 2016
  1. build: don't install github templates

    jbergstroem committed Mar 9, 2016
    Avoid putting github templates in the source tarballs.
    
    PR-URL: #5612
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Feb 11, 2016
  1. build: treat aarch64 as arm64

    jbergstroem committed Feb 11, 2016
    `Makefile` is now consistent with `configure` regarding
    how we treat aarch64.
    
    PR-URL: #5191
    Fixes: #5175
    Reviewed-By: Rod Vagg <r@va.gg>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Dec 31, 2015
  1. test: inherit JOBS from environment

    jbergstroem committed Dec 31, 2015
    In some virtualized environments the amount of available resources
    are misleading; for instance `multiprocessing.cpu_count()` on our current
    4-core smartos vm's returns `48`. This is not a bug, merely how the vm
    host provides information about available hardware.
    
    Avoid running into issues by overriding `cpu_count()` with `JOBS`.
    
    PR-URL: #4495
    Reviewed-By: Brian White <mscdex@mscdex.net>
Commits on Dec 30, 2015
  1. test: don't use cwd for relative path

    jbergstroem committed Dec 30, 2015
    With the introduction of temporary paths in the test runner
    realpath tests would bail in scenarios where the temporary folder
    wasn't in the same directory as the source code.
    
    PR-URL: #4477
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. test: don't assume a certain folder structure

    jbergstroem committed Dec 30, 2015
    A few tests assumed that temp dirs always lived in the same
    parent folder as fixtures. Make these use `common.tmpDir` instead.
    
    PR-URL: #3325
    Reviewed-By: Joao Reis <reis@janeasystems.com>
  3. test: make temp path customizable

    jbergstroem committed Oct 12, 2015
    In CI we previously passed `NODE_COMMON_PIPE` to the test runner to
    avoid long filenames. Add an option to the test runner that allows the
    user to change the temporary directory instead. This also allows us to
    run test suites in parallel since `NODE_COMMON_PIPE` otherwise would
    have been used from multiple tests at the same time.
    
    PR-URL: #3325
    Reviewed-By: Joao Reis <reis@janeasystems.com>
Commits on Nov 12, 2015
  1. tools: add tap output to cpplint

    jbergstroem committed Oct 20, 2015
    Implement a crude TAP13 writer for cpplint. Does its job and
    not much else. Only supports writing TAP output to file,
    not vs7 or emacs formats.
    
    PR-URL: #3448
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Oct 8, 2015
  1. build: make icu download path customizable

    jbergstroem committed Oct 6, 2015
    This makes it easier to store icu tarballs outside of the node.js
    directory which is useful in our CI where git directories are
    scrubbed between runs.
    
    PR-URL: #3200
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rod Vagg <rod@vagg.org>
Commits on Sep 6, 2015
  1. doc: reorder collaborators by their usernames

    jbergstroem authored and rvagg committed Jul 25, 2015
    Fixes: #1972
    PR-URL: #2322
    Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
    Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Jul 30, 2015
  1. tools: expose skip output to test runner

    jbergstroem committed Jul 8, 2015
    In the TAP protocol, skips are flagged as ok. Expose more
    information so we can understand if the test was skipped or not.
    
    PR-URL: #2130
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Jul 10, 2015
  1. build: bail early if clean is invoked

    jbergstroem committed Jul 7, 2015
    On windows, there's no need to continue with the msbuild process
    (signing, whatnot) when we only want to clean the project.
    
    PR-URL: #2127
    Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Commits on Jul 8, 2015
  1. test: add missing crypto checks

    jbergstroem committed Jul 8, 2015
    Add a check for crypto before using it, similar to how
    other tests work.
    
    PR-URL: #2129
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Commits on Jun 19, 2015
  1. build: remove lint from test-ci on windows

    jbergstroem committed Jun 17, 2015
    PR-URL: #2004
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Commits on Jun 17, 2015
  1. doc: reformat authors section

    jbergstroem committed Jun 13, 2015
    Make the order of name, email and other additions simpler to
    copy paste and/or match with git commit messages.
    
    Useful when working with `Reviewed-By`.
    
    PR-URL: #1966
    Reviewed-By: Christian Tellnes <christian@tellnes.no>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Jun 15, 2015
  1. build: don't run lint from test-ci

    jbergstroem committed Jun 13, 2015
    Since we will run linting before compiling or testing there's no
    need to run it as part of the ci testing.
    
    PR-URL: #1965
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Revewied-By: Evan Lucas <evanlucas@me.com>
  2. build: simplify execution of built binary

    jbergstroem committed Jun 12, 2015
    Since we aleady have a variable with path to the newly built
    binary, use that instead of prefixing path. This also allows us
    to pass a different path through the environment (NODE=)
    
    PR-URL: #1955
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rod Vagg <rod@vagg.org>
Commits on May 31, 2015
  1. build: avoid passing empty strings to build flags

    jbergstroem committed May 25, 2015
    While checking the return values from icu-i18n, we didn't
    validate the content before passing it to the build system.
    
    Also make cflags parsing more robust by avoiding empty strings.
    
    Fixes: #1787
    PR-URL: #1789
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on May 30, 2015
  1. tools: pass constant to logger instead of string

    jbergstroem committed May 30, 2015
    On a few of our installations (namely CentOS), passing 'INFO'
    resulted in a silent loglevel. Use a logging constant instead.
    
    Fixes: nodejs/build#104
    PR-URL: #1842
    Reviewed-By: Rod Vagg <rod@vagg.org>
Commits on May 20, 2015
  1. build: refactor pkg-config for shared libraries

    jbergstroem committed May 4, 2015
    Improve detection and usage of pkg-config. This simplifies the setup
    of all our shared libraries.
    
    If pkg-config is installed on the host and `--shared` flags are passed
    by the user, we try to get defaults from pkg-config instead of using the
    default provided by configure.
    
    PR-URL: #1603
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on May 14, 2015
  1. build: use backslashes for paths on windows

    jbergstroem committed May 13, 2015
    PR-URL: #1698
    Reviewed-By: Yosuke Furukawa <furukawa.yosuke@dena.jp>
    Reviewed-By: Roman Reiss <me@silverwind.io>
Commits on May 13, 2015
  1. build: move --with-intl to intl optgroup

    jbergstroem committed May 12, 2015
    PR-URL: #1680
    Reviewed-By: Rod Vagg <rod@vagg.org>
Older
You can’t perform that action at this time.