Permalink
Switch branches/tags
Commits on Sep 17, 2018
  1. tls: de-duplicate for TLSSocket methods

    maclover7 authored and addaleax committed Aug 5, 2018
    Similar approach is used for `TLSWrap`, where C++ handle methods are
    mapped one-to-one in JS.
    
    PR-URL: #22142
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Aug 14, 2018
  1. lib: extract validateNumber validator

    maclover7 committed Aug 3, 2018
    Pulls out another common argument validator to `internal/validators`
    
    PR-URL: #22249
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Aug 12, 2018
  1. src: add READONLY_STRING_PROPERTY and simplify config

    maclover7 committed Aug 9, 2018
    Bit of tidying up where we set different config values.
    
    PR-URL: #22222
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. crypto: remove unused SSLWrap handle methods

    maclover7 committed Aug 9, 2018
    One was not used at all, and the other was only used in a test, which I
    converted to use the more standard `ShutdownWrap` API.
    
    PR-URL: #22216
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Aug 7, 2018
  1. dgram: fix linting issue

    maclover7 authored and jasnell committed Aug 7, 2018
    Not sure why CI (and `make -j8 test` at the time of landing) showed this
    as being OK, but `make lint-js` is failing now.
    
    PR-URL: #22175
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. lib: extract validateString validator

    maclover7 committed Aug 2, 2018
    Pulls out a common argument validator to `internal/validators`
    
    PR-URL: #22101
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 5, 2018
  1. src: remove unused env strings

    maclover7 authored and tniessen committed Jul 30, 2018
    user_string:
    Usage removed in 4e05952
    onstop_string:
    Usage removed in 7b46e17
    max_old_space_size_string:
    Added in 0df031a, never used
    max_semi_space_size_string:
    Added in 0df031a, never used
    enter_string:
    Usage removed in eeede3b
    
    PR-URL: #22137
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Aug 4, 2018
  1. src: remove unused env->vm_parsing_context_symbol

    maclover7 committed Jul 30, 2018
    Stopped being used via 77b52fd, was
    originally added in d932e80.
    
    For the one remaining usecase inside of `lib/vm.js`, define a Symbol at
    the top of the file.
    
    PR-URL: #22034
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Aug 1, 2018
  1. doc: mark DEP0004 and DEP0042 as End-of-Life

    maclover7 committed Jul 30, 2018
    `CryptoStream` was removed via 9301b8a.
    
    PR-URL: #22033
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. src: rename PROVIDER_FSREQWRAP to PROVIDER_FSREQCALLBACK

    maclover7 committed Jul 28, 2018
    PR-URL: #21971
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  3. src,lib: rename FSReqWrap to FSReqCallback

    maclover7 committed Jul 25, 2018
    Given that FSReqPromise does not inherit from FSReqWrap, FSReqWrap
    should be renamed FSReqCallback to better describe what it does.
    
    First of a few upcoming `fs` refactorings :)
    
    PR-URL: #21971
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jul 31, 2018
  1. tools,test: remove unused config hooks

    maclover7 committed Jul 28, 2018
    Removes a couple of unused/empty functions inside of `tools/test.py`
    
    PR-URL: #22010
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. test: remove custom AsyncHooksTestConfiguration

    maclover7 committed Jul 28, 2018
    Has the same behavior as `ParallelTestConfiguration`
    
    PR-URL: #22008
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  3. test: remove outdated documentation

    maclover7 committed Jul 28, 2018
    As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
    be updated since they run the `default` suite.
    
    PR-URL: #22009
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jul 28, 2018
  1. src: use available ReqWrap instance for libuv req

    maclover7 committed Jul 26, 2018
    Use available `ReqWrap` descendant to make call to libuv -- avoid doing
    call with the `ReqWrap`'s request member and then calling `Dispatched()`
    afterwards.
    
    PR-URL: #21980
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jul 27, 2018
  1. tools: fix docs and run known_issues by default

    maclover7 committed Jul 20, 2018
    - Updates `test/README.md` with new suites
    - Fixes some outdated `IGNORED_SUITES` listings
    - Allows for `test/known_issues` suite to be run by default
    
    PR-URL: #21910
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Lance Ball <lball@redhat.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jul 22, 2018
  1. src: don't store one-use strings in variable

    maclover7 committed Jul 18, 2018
    Move strings that are used only once to their call-sites, don't store
    in a variable.
    
    PR-URL: #21876
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. src: remove unnecessary else

    maclover7 committed Jul 18, 2018
    Argument is not used by the only caller.
    
    PR-URL: #21874
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jul 15, 2018
  1. src: remove defunct timer_wrap file

    maclover7 committed Jul 12, 2018
    Unused since the excellent refactoring in 2930bd,
    which also removed `src/timer_wrap.cc` from `node.gyp`. If you try and
    get at the binding on a v11.0-pre build, you'll get an error, since the
    file is no longer in the GYP build.
    
    ```
    Jonathans-MBP:node jon$ ./node -v
    v11.0.0-pre
    Jonathans-MBP:node jon$ ./node -e "process.binding('timer_wrap')"
    internal/bootstrap/loaders.js:81
            mod = bindingObj[module] = getBinding(module);
                                       ^
    
    Error: No such module: timer_wrap
        at process.binding (internal/bootstrap/loaders.js:81:36)
        at [eval]:1:9
        at Script.runInThisContext (vm.js:89:20)
        at Object.runInThisContext (vm.js:286:38)
        at Object.<anonymous> ([eval]-wrapper:6:22)
        at Module._compile (internal/modules/cjs/loader.js:689:30)
        at evalScript (internal/bootstrap/node.js:562:27)
        at startup (internal/bootstrap/node.js:248:9)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
    ```
    
    PR-URL: #21777
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Refs: #20894
Commits on Jul 13, 2018
  1. test: fix weird string error

    maclover7 authored and addaleax committed Jul 13, 2018
    Previously getting this error when running `tap2junit` (what parses our
    `.tap` files in CI):
    
    ```
    Traceback (most recent call last):
      File "/usr/local/bin/tap2junit", line 11, in <module>
        sys.exit(main())
      File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main
        result.to_file(args.output, [result], prettyprint=False)
      File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file
        test_suites, prettyprint=prettyprint, encoding=encoding)
      File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string
        ts_xml = ts.build_xml_doc(encoding=encoding)
      File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc
        attrs['message'] = decode(case.skipped_message, encoding)
      File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode
        ret = unicode(var)
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128)
    ```
    
    PR-URL: #21793
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. src: add HandleWrap::AddWrapMethods

    maclover7 committed Jul 11, 2018
    Extracts common setters to a single location
    
    PR-URL: #21769
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Jul 12, 2018
  1. zlib: instance-ify two methods

    maclover7 committed Jul 7, 2018
    Both `Params` and `SetDictionary` take `ZCtx` as an arg, so just make
    them both instance methods on `ZCtx`.
    
    PR-URL: #21702
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jul 11, 2018
  1. src: make Environment::is_stopping_worker inline

    maclover7 committed Jul 9, 2018
    Fixes a TODO comment.
    
    PR-URL: #21720
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 14, 2018
  1. doc: add build wg info to releases.md

    maclover7 committed Jun 12, 2018
    PR-URL: #21275
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Jan 19, 2018
  1. test: refactor test-http-parser

    maclover7 authored and BridgeAR committed Jan 18, 2018
    Use common's mustCall (for some reason was implementing its own?), and
    other small fixes.
    
    PR-URL: #18219
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jan 13, 2018
  1. doc: add documentation for deprecation properties

    maclover7 committed Oct 26, 2017
    PR-URL: #16539
    Fixes: #16394
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jan 11, 2018
  1. fs: extract out validateUint32 and validateLen functions

    maclover7 authored and joyeecheung committed Dec 23, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  2. fs: extract out validatePath function

    maclover7 authored and joyeecheung committed Dec 22, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  3. fs: extract out validateOffsetLengthWrite function

    maclover7 authored and joyeecheung committed Dec 22, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  4. fs: extract out validateBuffer function

    maclover7 authored and joyeecheung committed Dec 14, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  5. fs: extract out validateOffsetLengthRead function

    maclover7 authored and joyeecheung committed Dec 13, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  6. fs: extract out validateFd function

    maclover7 authored and joyeecheung committed Dec 13, 2017
    PR-URL: #17682
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Commits on Jan 5, 2018
  1. tools: host remark-preset-lint-node in-tree

    maclover7 authored and BridgeAR committed Dec 3, 2017
    Moved from https://github.com/watilde/remark-preset-lint-node.
    
    PR-URL: #17441
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Dec 25, 2017
  1. async_hooks: use CHECK instead of throwing error

    maclover7 committed Dec 23, 2017
    SetupHooks is only available via `process.binding('async_wrap')`, so
    there's no reason it shouldn't be called with the appropriate arguments,
    since it is an internal-only function. The only place this function is
    used is `lib/internal/async_hooks.js`.
    
    PR-URL: #17832
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Dec 24, 2017
  1. lib, src: use process.config instead of regex

    maclover7 committed Dec 21, 2017
    Is safer to use a `process.binding(config)` defined boolean, than to
    regex on `process.execArgv`. Also, this better falls in line with the
    conventions of checking flags passed to the executable.
    
    PR-URL: #17814
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>