Skip to content
Permalink
Branch: master
Commits on Oct 2, 2019
  1. doc: remove reference to stale CITGM job

    mhdawson authored and Trott committed Sep 30, 2019
    Remove reference to job that is out of date, has not
    been run for a long time and likely does not work
    properly.
    
    Refs: nodejs/citgm#741
    
    PR-URL: #29774
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Sep 20, 2019
  1. build: update minimum Xcode version for macOS

    mhdawson committed Sep 19, 2019
    Update the minimum Xcode version for macOS to 10. We'll
    need this level to incorporate future V8 versions.
    
    Refs: #29493
    
    PR-URL: #29622
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Commits on Sep 13, 2019
  1. doc: add Bethany to TSC

    mhdawson committed Sep 13, 2019
    Refs: nodejs/TSC#718
    
    PR-URL: #29546
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  2. doc: add Tobias to the TSC

    mhdawson committed Sep 13, 2019
    refs: nodejs/TSC#746
    
    PR-URL: #29545
    Refs: nodejs/TSC#746
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Commits on Sep 8, 2019
  1. build: update minimum AIX OS level

    mhdawson authored and Trott committed Sep 6, 2019
    Update minimum AIX OS level to 7.2 TL2. Looks like this
    will be the version we can get into the CI so should be the
    base level for 13.X and above and will be in support for the life
    of 13.X.
    
    PR-URL: #29476
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Sep 7, 2019
  1. doc: simplify wording in n-api doc

    mhdawson authored and Trott committed Sep 4, 2019
    Simplify/clarify wording documenting n-api execute
    callback.
    
    PR-URL: #29441
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Aug 16, 2019
  1. doc: mention N-API as recommended approach

    mhdawson committed Aug 1, 2019
    We've had a few comments that from the doc it might not
    be clear that N-API is the recommended approach for Addons.
    As a start, mention N-API early in the non N-API section
    as the recommended approach unless lower level access
    is required.
    
    PR-URL: #28922
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 4, 2019
  1. doc: remove use of you

    mhdawson authored and Trott committed Aug 1, 2019
    We generally avoid the use of 'you'.
    
    PR-URL: #28919
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jul 20, 2019
  1. doc: amplify warning for execute callback

    mhdawson authored and Trott committed Jul 17, 2019
    Add specific recommendation not to use the
    to the napi-env parameter in napi_async_execute_callback
    
    PR-URL: #28738
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jun 25, 2019
  1. doc: remove N-API version for Experimental APIs

    mhdawson authored and addaleax committed Jun 20, 2019
    Experimental APIs should not have an N-API version
    specified. Remove cases were one had been added
    incorrectly.
    
    PR-URL: #28330
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jun 13, 2019
  1. doc: update kernel and glibc reqs for PPCle

    mhdawson authored and richardlau committed Jun 10, 2019
    We've moved master to build on centos7 for PPCle, adjust
    the glibc and kernel levels accordingly.
    
    PR-URL: #28162
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Commits on Jun 11, 2019
  1. doc: clarify N-API version Matrix

    mhdawson committed May 28, 2019
    I was asked by a community member if they needed to
    recompile for v12.x based on the version matrix. Add
    additional context to help ensure it is clear that this
    is not the case.
    
    PR-URL: #27942
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on May 26, 2019
  1. doc: add version info for types

    mhdawson authored and Trott committed May 17, 2019
    Add version info for types in N-API doc.
    
    PR-URL: #27754
    Fixes: #27486
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on May 20, 2019
  1. doc: remove stability highlight for stable functions

    mhdawson authored and Trott committed May 17, 2019
    We don't have the stability functions for all stable
    functions, only those that were previously experimental and
    then when stable. Remove the stability indicator to be
    consistent with the rest of the functions.
    
    PR-URL: #27753
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on May 1, 2019
  1. doc: move James back onto TSC

    mhdawson authored and Trott committed Apr 25, 2019
    refs: nodejs/TSC#694
    
    PR-URL: #27411
    Refs: nodejs/TSC#694
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Apr 11, 2019
  1. doc: add missing n-api version indicator

    mhdawson committed Apr 9, 2019
    When the threadsafe functions were promoted to
    version 4 from experimental we missed documenting
    that. Add the version indicator for these functions
    in the doc.
    
    PR-URL: #27155
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Apr 9, 2019
  1. n-api: reduce gc finalization stress

    mhdawson authored and danbev committed Apr 4, 2019
    #24494 fixed a crash
    but resulted in increased stress on gc finalization. A leak
    was reported in #26667 which
    we are still investigating. As part of this investigation I
    realized we can optimize to reduce amount of deferred finalization.
    Regardless of the root cause of the leak this should be a
    good optimization. It also resolves the leak for the case being
    reported in #26667. The OP in 26667 has confirmed that he can
    still recreate the original problem that 24494 fixed and that
    the fix still works with this optimization
    
    PR-URL: #27085
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Apr 8, 2019
  1. test: fix test-worker-memory.js for large cpu #s

    mhdawson committed Apr 4, 2019
    This test consistently failed on a system with a
    large number of cores (~120). Cap the number of
    concurrent workers so we'll stay consistently within
    the "slack" allowed with respect to rss.
    
    PR-URL: #27090
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on Mar 4, 2019
  1. doc: fix up N-API support matrix

    mhdawson committed Mar 1, 2019
    The support matrix was out of date. Update
    with current status.
    
    Fixes: #25801
    
    PR-URL: #26377
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Feb 1, 2019
  1. test: exclude additional test for coverage

    mhdawson committed Jan 30, 2019
    Exclude async-hooks/test-callback-error as it seems
    to fail consistently when run with coverage on
    the docker ubuntu16 machines we plan to run the
    coverage sanity test on.
    
    PR-URL: #25833
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
Commits on Jan 29, 2019
  1. test: enable marking of failing coverage tests

    mhdawson authored and danbev committed Jan 22, 2019
    Enable marking of coverage tests so that we can
    allow some tests to fail without blocking the generation
    of coverage data. This will later allow us to
    fail the coverage job if other kinds of errors occur and
    to capture which tests we believe are not running properly
    with coverage enabled.
    
    PR-URL: #25671
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Jan 18, 2019
  1. test: improve code coverage for i18n

    mhdawson committed Jan 10, 2019
    Coverage report for src/node_i18n.cc shows that the
    Has() method is not covered. This test adds coverage
    for that method.
    
    PR-URL: #25428
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Jan 17, 2019
  1. doc: add Rich back to TSC list

    mhdawson committed Jan 16, 2019
    Fixes: nodejs/TSC#650
    
    PR-URL: #25535
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  2. test: revert fail `coverage` target if tests fail"

    mhdawson committed Jan 16, 2019
    This reverts commit f216d5b.
    Seems like it breaks the nightly job so reverting until
    we figure that out.
    
    PR-URL: #25543
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 9, 2019
  1. doc: add clarification for exception behaviour

    mhdawson authored and danbev committed Jan 4, 2019
    Document current behaviour where some methods can be called
    when an exception is pending, while others cannot and explain
    the behaviour.
    
    PR-URL: #25339
    Refs: nodejs/abi-stable-node#356
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Jan 4, 2019
  1. src: add NAPI_VERSION_EXPERIMENTAL

    mhdawson committed Jan 2, 2019
    Refs: nodejs/node-addon-api#421
    
    Define NAPI_VERSION_EXPERIMENTAL so that it can be
    used to guard code in addons that need to check
    if a function they want to use is available.
    
    PR-URL: #25319
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Nov 24, 2018
  1. doc: mark napi_add_finalizer experimental

    mhdawson authored and Trott committed Nov 22, 2018
    This was missed when the function was added. As it
    is experimental in the code it should also be
    experimental in the docs.
    
    Fixes: #24509
    PR-URL: #24572
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Nov 23, 2018
  1. n-api: handle reference delete before finalize

    mhdawson committed Nov 16, 2018
    Crashes were reported during finalization due to
    the memory for a reference being deleted and the
    finalizer running after the deletion.
    
    This change ensures the deletion of the memory for
    the reference only occurs after the finalizer has run.
    
    Fixes: nodejs/node-addon-api#393
    
    PR-URL: #24494
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Nov 16, 2018
  1. doc: better linkage to node-addon-api

    mhdawson committed Nov 14, 2018
    One of the comments we got at the N-API workshop
    at NodeConfEU was that we should have a better link to
    node-addon-api and the docs in the main API docs for
    N-API. The goal being to help people find node-addon-api
    and potentially start with the node-addon-api docs
    instead if they are using C++.
    
    This expands and strengthens the link along with a
    recommendation that starting with the node-addon-api
    docs might make sense.
    
    PR-URL: #24371
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  2. doc: add help on fixing IPv6 test failures

    mhdawson committed Nov 14, 2018
    It took me a while to figure out the problem and
    then some googling to find the right answer.  I think
    it is worth adding this to help other people in the
    future and to have an easy place to point people to
    for the solution if their test run fails with IPv6
    failures.
    
    PR-URL: #24372
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Commits on Oct 22, 2018
  1. build: fix coverage generation

    mhdawson committed Oct 19, 2018
    Changes in command line options for nyc resulted in the
    coverage target no longer working.
    
    Pin the major version of nyc and update the options to
    get it working again.
    
    PR-URL: #23769
    Fixes: #23690
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
Commits on Sep 13, 2018
  1. doc: add reference to guide for N-API additions

    mhdawson committed Aug 29, 2018
    Add reference to guide with requirements/principles
    for accepting additions to N-API.
    
    PR-URL: #22593
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 28, 2018
  1. doc: initial cut at support tiers for diag tools

    mhdawson committed Jul 18, 2018
    PR-URL: #21870
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
Commits on Jul 28, 2018
  1. src: fix may be uninitialized warning in n-api

    mhdawson authored and maclover7 committed Jul 19, 2018
    PR-URL: #21898
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Jun 14, 2018
  1. doc: clarify async execute callback usage

    mhdawson committed Jun 8, 2018
    Clarify that calls to N-API should be avoided in
    the 'execute' callback.
    
    PR-URL: #21217
    Refs: nodejs/help#1318
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Older
You can’t perform that action at this time.