Skip to content
Permalink
Branch: master
Commits on Jul 31, 2018
  1. doc: add pronouns to readme

    not-an-aardvark committed Jul 31, 2018
    Refs: #21803
    
    PR-URL: #22036
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Jun 28, 2018
  1. util: add inspect suffix to BigInt64Array elements

    not-an-aardvark committed Jun 24, 2018
    This commit updates `util.inspect` to add an `n` suffix to BigInts that
    appear in BigInt64Arrays. BigInts are formatted with an `n` suffix in
    most cases, but this did not occur in BigInt64Arrays due to an apparent
    oversight where the implementation of `inspect` for typed arrays assumed
    that all typed array elements are numbers.
    
    PR-URL: #21499
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Commits on May 26, 2018
  1. doc: mark Node 4 as EOL in changelog

    not-an-aardvark committed May 24, 2018
    Node 4 has been unsupported since 2018-05-01, but the changelog was out
    of date and said that Node 4 was still in LTS.
    
    PR-URL: #20926
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Weijia Wang <starkwang@126.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
Commits on May 23, 2018
  1. doc: fix incorrect fs.readFileSync example output

    not-an-aardvark committed May 22, 2018
    This fixes an incorrect example in the documentation for calling
    `fs.readFileSync` on a directory. The example was presumably copied from
    the documentation for `fs.readFile`, which has an error argument in its
    callback.
    
    PR-URL: #20902
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Apr 4, 2018
  1. assert: ensure .rejects() disallows sync throws

    not-an-aardvark committed Mar 28, 2018
    This updates `assert.rejects()` to disallow any errors that are thrown
    synchronously from the given function. Previously, throwing an error
    would cause the same behavior as returning a rejected Promise.
    
    Fixes: #19646
    PR-URL: #19650
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  2. test: ensure failed assertions cause build to fail

    not-an-aardvark committed Mar 28, 2018
    This updates the test in `test/parallel/test-assert-async.js` to add an
    assertion that the Promises used in the test end up fulfilled.
    Previously, if an assertion failure occurred, the Promises would have
    rejected and a warning would have been logged, but the test would still
    have exit code 0.
    
    PR-URL: #19650
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Oct 14, 2017
  1. test: add tests for eslint rules

    not-an-aardvark committed Oct 11, 2017
    This adds tests for the custom eslint rules in this repository, using
    the `RuleTester` test utility bundled with eslint.
    
    PR-URL: #16138
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 13, 2017
  1. repl: include folder extensions in autocomplete

    not-an-aardvark committed Aug 10, 2017
    When autocompleting `require` calls, the repl strips .js file extensions
    from results. However, stripping an extension from a directory results
    in an error. Update the autocompletion logic to avoid stripping
    extensions from directories.
    
    PR-URL: #14727
    Fixes: #14726
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Commits on Jun 16, 2017
  1. doc: fix typo in changelog

    not-an-aardvark committed Jun 16, 2017
    PR-URL: #13713
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Apr 4, 2017
  1. test: fix test-cli-syntax assertions on windows

    not-an-aardvark committed Apr 4, 2017
    The test introduced in a5f91ab
    accidentally introduced failures on some windows builds. Update the
    assertion that was causing the failures.
    
    PR-URL: #12212
    Ref: #11689
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. src: throw when -c and -e are used simultaneously

    not-an-aardvark committed Mar 30, 2017
    The -c flag ("check script syntax") and -e flag ("evaluate given code")
    have contradictory meanings. Make them mutually exclusive by throwing
    when both of them are provided.
    
    Fixes: #11680
    PR-URL: #11689
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  3. lib: ensure --check flag works for piped-in code

    not-an-aardvark committed Mar 5, 2017
    Previously, the --check CLI flag had no effect when run on code piped
    from stdin. This commit updates the bootstrap logic to handle the
    --check flag the same way regardless of whether the code is piped from
    stdin.
    
    PR-URL: #11689
    Fixes: #11680
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Jan 9, 2017
  1. tools,test: enforce assert.ifError with lint rule

    not-an-aardvark authored and jasnell committed Jan 7, 2017
    This adds an ESLint rule to enforce the use of `assert.ifError(err)`
    instead of `if (err) throw err;` in tests.
    
    PR-URL: #10671
    Ref: #10543
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Michal Zasso <targos@protonmail.com>
Commits on Jan 5, 2017
  1. util: avoid out-of-bounds arguments index access

    not-an-aardvark committed Jan 2, 2017
    This updates util.inspect() to avoid accessing out-of-range indices of
    the `arguments` object, which is known to cause optimization bailout.
    
    Based on an average of 10 runs of the benchmark in
    `benchmark/util/inspect.js`, this change improves the performance of
    `util.inspect` by about 10%.
    
    Relates to #10323
    
    PR-URL: #10569
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Dec 6, 2016
  1. repl: avoid parsing division operator as regex

    not-an-aardvark committed Dec 3, 2016
    This improves the heuristic used in multiline-prompt mode to determine
    whether a given slash character is at the beginning of a regular
    expression.
    
    PR-URL: #10103
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: James M Snell <jasnell@keybase.io>
    Fixes: #9300
Commits on Dec 3, 2016
  1. doc: suggest Buffer.alloc instead of Buffer#fill

    not-an-aardvark committed Dec 1, 2016
    Now that `Buffer.alloc` exists, there is no reason to recommend using
    `new Buffer(size).fill(0)` or `Buffer.allocUnsafe(size).fill(0)`.
    
    PR-URL: #10000
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Dec 2, 2016
  1. repl: fix generator function preprocessing

    not-an-aardvark committed Nov 30, 2016
    Function declarations in the REPL are preprocessed into variable
    declarations before being evaluated. However, the preprocessing logic
    did not account for the star in a generator function declaration, which
    caused the preprocessor to output invalid syntax in some circumstances.
    
    PR-URL: #9852
    Fixes: #9850
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Sep 21, 2016
  1. tools: add additional ESLint rules

    not-an-aardvark committed Sep 18, 2016
    PR-URL: #8643
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@keybase.io>
Commits on Sep 18, 2016
  1. doc: remove extra comma in cluster docs

    not-an-aardvark committed Sep 16, 2016
    PR-URL: #8557
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Sep 13, 2016
  1. doc: add not-an-aardvark to collaborators

    not-an-aardvark committed Sep 13, 2016
    PR-URL: #8525
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Sep 12, 2016
  1. test: make crypto.timingSafeEqual test less flaky

    not-an-aardvark authored and Trott committed Sep 8, 2016
    The `crypto.timingSafeEqual` test still seems to be a bit flaky. This
    makes a few changes to the test:
    
    * Separates the basic usage and the benchmarking into different tests
    
    * Moves the timing-sensitive benchmark function into a separate module,
    and reparses the module on every iteration of the loop to avoid shared
    state between timing measurements.
    
    PR-URL: #8456
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 7, 2016
  1. crypto: add crypto.timingSafeEqual()

    not-an-aardvark authored and Trott committed Aug 24, 2016
    Reinstate crypto.timingSafeEqual() which was reverted due to test
    issues. The flaky test issues are resolved in this new changeset.
    
    PR-URL: #8304
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Aug 20, 2016
  1. crypto: add crypto.timingSafeEqual

    not-an-aardvark authored and jasnell committed Aug 9, 2016
    PR-URL: #8040
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
You can’t perform that action at this time.