Skip to content
Permalink
Branch: master
Commits on Oct 23, 2018
  1. doc: move @phillipj to emeriti

    phillipj authored and Trott committed Oct 20, 2018
    Moving @phillipj to emeriti as he has not been an active collaborator
    for a long time, and will not have the opportunity to do so in the
    near future.
    
    PR-URL: #23790
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Jan 25, 2017
  1. tools,doc: add Google Analytics tracking.

    phillipj committed Jan 25, 2017
    Adds Google Analytics tracking script to all doc pages when
    `DOCS_ANALYTICS` is set when running `make`:
    
    ```bash
    $ DOCS_ANALYTICS=<GOOGLE ANALYTICS ID> make
    ```
    
    By default (when `DOCS_ANALYTICS` is not set), no tracking scripts are
    included.
    
    It respects "Do Not Track" settings end users might have in their
    browser.
    
    Also changes make target `doc-upload` from depending on the
    `$(TARBALL)` target, to only depend on `doc` directly.
    
    PR-URL: #6601
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Aug 5, 2016
  1. doc: improve server.listen() random port

    phillipj committed Aug 4, 2016
    Minor rewording related to making a server listen to a random port,
    and added how to retrieve which port was randomly chosen by the OS.
    
    Also changed documented `server.listen()` signature as it does in fact
    not require `port` to be provided.
    
    PR-URL: #7976
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Apr 1, 2016
  1. net: improve socket.write() error message

    phillipj authored and jasnell committed Mar 31, 2016
    Informative error messages are very important for developers and could
    possibly save hours of debugging and frustration. This improves the error
    message thrown when writing invalid data into a socket, by communicating
    what's expected compared to what the developer just tried to write.
    
    PR-URL: #5981
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 29, 2016
  1. module: prioritize current dir for local lookups

    phillipj committed Mar 13, 2016
    This fixes a bug where a 3rd party module found in node_modules,
    would be preferred over a ./local module with the same name.
    
    Fixes: #5684
    PR-URL: #5689
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Commits on Mar 11, 2016
  1. doc: add phillipj to collaborators

    phillipj committed Mar 11, 2016
    PR-URL: #5663
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Commits on Feb 26, 2016
  1. doc: explicit about VS 2015 support in readme

    phillipj authored and rvagg committed Feb 24, 2016
    `vcbuild.bat` already supports both Visual Studio 2013 and 2015.
    
    PR-URL: #5406
    Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
    Reviewed-By: Rod Vagg <rod@vagg.org>
Commits on Oct 29, 2015
  1. doc: made code spans more visible in the API docs

    phillipj authored and silverwind committed Oct 28, 2015
    This makes the code spans in the API docs more visible and
    therefore readable by adding some background color.
    
    PR-URL: #3573
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
Commits on Oct 14, 2015
  1. doc: label v4.2.1 as LTS in changelog heading

    phillipj authored and silverwind committed Oct 14, 2015
    PR-URL: #3360
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
Commits on Jul 19, 2015
  1. doc: recompile before testing core module changes

    phillipj authored and thefourtheye committed Jun 24, 2015
    Changes to core modules do not take effect unless recompiled. Tip new
    contributors about this when describing how to run tests in
    contribution guide.
    
    Removed `jslint` from first test command example, as jslint is included
    when running `make test`.
    
    Fixed wrong path of example stream2-transform test.
    
    PR-URL: #2051
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Jul 11, 2015
  1. path: assert path.join() arguments equally

    phillipj authored and silverwind committed Jul 10, 2015
    Re-use `assertPath()` when asserting path argument types in `join()`
    as throughout the rest of the `path` module.
    
    This also ensures the same error message generated for posix as for
    win32.
    
    PR-URL: #2159
    Reviewed-By: Roman Reiss <me@silverwind.io>
You can’t perform that action at this time.