Skip to content
Permalink
Branch: master
Commits on Jun 13, 2019
  1. build,win: delegate lint-cpp to make

    refack committed Jun 6, 2019
    * look for GNU Make in the Path or use wsl
    
    PR-URL: #28102
    Fixes: #28086
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
Commits on Jun 6, 2019
  1. test: mark test-worker-debug as flaky

    refack committed Jun 5, 2019
    Also try to make more traceable.
    
    PR-URL: #28035
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  2. test: regression test `tmpdir`

    refack committed Jun 2, 2019
    PR-URL: #28035
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  3. test: always suffix `tmpdir`

    refack committed Jun 2, 2019
    This makes temp dir names consistent whether we run in stand-alone mode,
    via `test.py` in single process, or in multi-process.
    
    PR-URL: #28035
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  4. test: shell out to `rmdir` first on Windows

    refack committed Jun 2, 2019
    cmd's `rmdir` is hardened to deal with Windows edge cases, like
    lingering processes, indexing, and AV checks. So we give it a try first.
    
    * Added `opts = { spawn = true }` to opt-out of spawning
    * test-pipeconnectwrap.js - spawning messes up async_hooks state
    
    PR-URL: #28035
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
  5. test,v8: skip less and stabilize test-linux-perf.js

    refack committed Apr 23, 2019
    Co-authored-by: Matheus Marchini <mat@mmarchini.me>
    
    PR-URL: #27364
    Refs: nodejs/build#1774
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jun 3, 2019
  1. build,meta: rearrange and narrow git ignore rules

    refack committed May 29, 2019
    PR-URL: #27954
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Jun 2, 2019
  1. tools: fix js2c regression

    refack authored and Trott committed May 30, 2019
    PR-URL: #27980
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  2. meta: correct personal info

    refack authored and Trott committed May 28, 2019
    PR-URL: #27940
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Commits on Jun 1, 2019
  1. test: fail `test-worker-prof` on internal timeout

    refack committed Jun 1, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. lib: no need to strip BOM or shebang for scripts

    refack committed May 27, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  3. test: drain platform before unregistering isolate

    refack committed May 25, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  4. deps: V8: backport 3a75c1f

    refack committed May 28, 2019
    Original commit message:
    
        Fixing a possible freeze on abort with 'v8_win64_unwinding_info'
    
        Win64 unwind data can specify a language-specific handler function which is
        called as part of the search for an exception handler, as described in
        https://docs.microsoft.com/en-us/cpp/build/exception-handling-x64?view=vs-2019.
        This is used for example by Crashpad to register its own exception handler for
        exceptions in V8-generated code.
        There is a problem in the code that may cause a freeze on abort: in file
        \deps\v8\src\unwinding-info-win64.cc in function CRASH_HANDLER_FUNCTION_NAME the
        line:
            return EXCEPTION_CONTINUE_SEARCH;
        should be
            return ExceptionContinueSearch;
    
        These constants are both used in the context of Win32 exception handlers, but
        they have different semantics and unfortunately different values:
        EXCEPTION_CONTINUE_SEARCH (=0) should be returned by an exception filter
        while a language-specific handler should return an EXCEPTION_DISPOSITION value,
        and more precisely ExceptionContinueSearch (=1) in this case.
    
        Bug: v8:9295
        Change-Id: I1a3aaabf357e52a909611814f1ea013cf652ae06
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1629795
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Paolo Severini <paolosev@microsoft.com>
        Cr-Commit-Position: refs/heads/master@{#61867}
    
    Refs: v8/v8@3a75c1f
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  5. deps: V8: fix BUILDING_V8_SHARED issues

    refack committed May 26, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  6. deps: V8: workaround for MSVC 14.20 optimizer bug

    refack committed May 17, 2019
    Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  7. deps: V8: template explicit instantiation for GCC-8

    refack committed May 23, 2019
    Fails to link for missing:
    void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  8. deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init

    refack committed May 23, 2019
    `std::atomic_init<size_t>` is not implemented in all platforms.
    
    * pragma to ignore `-Wbraced-scalar-init`
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  9. deps: V8: forward declaration of `Rtl*FunctionTable`

    refack committed May 22, 2019
    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  10. deps: V8: patch register-arm64.h

    refack committed May 22, 2019
    Fixes a compilation issue on some platforms
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  11. deps: V8: un-cherry-pick bd019bd

    refack committed Mar 27, 2019
    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: #26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
  12. deps: V8: fix filename manipulation for Windows

    refack committed Mar 31, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  13. tools,gyp: introduce MSVS 2019

    refack committed May 22, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  14. build,v8: sync V8 gypfiles with 7.5

    refack committed Mar 29, 2019
    Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  15. src: update NODE_MODULE_VERSION to 74

    refack committed May 28, 2019
    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 7.5.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  16. build: reset embedder string to "-node.0"

    refack committed May 28, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  17. deps: update V8 to 7.5.288.22

    refack committed May 28, 2019
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  18. build,aix: link with `noerrmsg` to eliminate warnings

    refack committed May 19, 2019
    PR-URL: #27773
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on May 29, 2019
  1. src: make UNREACHABLE variadic

    refack committed May 25, 2019
    Eliminate warning C4003
     - not enough arguments for function-like macro invocation 'UNREACHABLE'
    
    PR-URL: #27877
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Commits on May 25, 2019
  1. build,win: create junction instead of symlink to `out\%config%`

    refack committed May 16, 2019
    PR-URL: #27736
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on May 18, 2019
  1. tools: refactor js2c.py for maximal Python3 compatibility

    refack committed Jan 14, 2019
    * add explicit `--target` argument to enable succinct gyp declaration
    * simplify js2c semantics
    
    PR-URL: #25518
    Reviewed-By: Christian Clauss <cclauss@me.com>
Commits on May 3, 2019
  1. build: delegate building from Makefile to ninja

    refack committed Apr 30, 2019
    PR-URL: #27504
    Refs: https://mobile.twitter.com/refack/status/1118484079077482498
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Commits on Apr 22, 2019
  1. build,win: deprecate `vcbuild test-ci`

    refack committed Apr 14, 2019
    PR-URL: #27231
    Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  2. deps,test: bump googletest to 39f72ea6f5

    refack committed Apr 14, 2019
    Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3
    
    PR-URL: #27231
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  3. build: improve embedded code-cache detection

    refack committed Apr 19, 2019
    PR-URL: #27311
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Apr 21, 2019
  1. test: mark some known flakes

    refack committed Apr 14, 2019
    PR-URL: #27225
    Refs: #26910
    Refs: #27219
    Refs: #26938
    Refs: #23089
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Older
You can’t perform that action at this time.