Skip to content
Permalink
Branch: master
Commits on Oct 3, 2019
  1. tools: support full-icu by default

    srl295 authored and Trott committed Sep 30, 2019
    Instead of an English-only icudt64l.dat in the repo,
    we now have icudt64l.dat.gz with all locales.
    
    - updated READMEs and docs
    - shrinker now copies source, and compresses (bzip2) the ICU data file
    - configure expects deps/icu-small to be full ICU with a full
    compressed data file
    
    Fixes: #19214
    Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
    Co-Authored-By: Jan Olaf Krems <jan.krems@gmail.com>
    Co-Authored-By: James M Snell <jasnell@gmail.com>
    PR-URL: #29522
    
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Sep 12, 2019
  1. tools: fix iculslocs to support ICU 65.1

    srl295 committed Sep 10, 2019
    The ICU alias table format changed in
    https://unicode-org.atlassian.net/browse/ICU-20627
    
    Because of this, iculslocs.cc needs to handle URES_TABLE format
    contents in the res_index.txt file.
    
    PR-URL: #29523
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Commits on Apr 27, 2019
  1. deps: backport ICU-20575 to fix err/crasher

    srl295 authored and targos committed Apr 25, 2019
    - Floating patch for ICU 64.x
    - includes test case
    
    ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
    Backport of: unicode-org/icu#634
    Fixes: #27418
    
    PR-URL: #27435
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
  2. deps: backport ICU-20558 to fix Intl crasher

    srl295 authored and targos committed Apr 25, 2019
    - Floating patch for ICU 63.x and 64.x
    - fixing crash in Intl when ICU data not found.
    - Regression test from refack included.
    
    Background:
    - ICU-13778 (landed in ICU 63.1) fixed a bug but
    added a regression.
    - a recent v8 land in Node v12 (which one?) exposes
    this bug to cause a crash when ICU data is not found.
    
    ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558
    Backport of: unicode-org/icu#632
    Fixes: #27379
    Co-authored-by: Refael Ackermann <refack@gmail.com>
    
    PR-URL: #27415
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Commits on Apr 26, 2019
  1. build: allow icu download to use other hashes besides md5

    srl295 committed Apr 23, 2019
    - ICU uses sha512 instead of md5 in some recent releases
    - Use hashlib.algorithms_guaranteed to choose the following algorithms:
        sha1 sha224 sha384 sha256 sha512 md5
    - No preference as to the priority of the algorithms
    - This commit does not change the hash used for ICU.
    
    Fixes: #27369
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-by: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-by: Richard Lau <riclau@uk.ibm.com>
    PR-URL: #27370
Commits on Mar 28, 2019
  1. doc: correct typo: cert.issuerCertificate

    srl295 committed Mar 26, 2019
    - docs incorrectly mention issuerCert, should be issuerCertificate
    
    Fix for Commit:
    a856406#diff-f6e3a86962eaf0897ab59e88b418e64fR678
    
    Fix for PR: #24358
Commits on Nov 17, 2018
  1. build: check minimum ICU in configure for system-icu

    srl295 authored and refack committed Nov 8, 2018
    - check the version number coming out of pkg-config
    
    PR-URL: #24255
    Fixes: #24253
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 24, 2018
  1. deps: icu 63.1 bump (CLDR 34)

    srl295 committed Oct 17, 2018
    - Full release notes: http://site.icu-project.org/download/63
    
    Fixes: #22344
    
    PR-URL: #23715
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  2. tools, icu: actually failover if there are multiple URLs

    srl295 committed Oct 17, 2018
    Building on #23269, if multiple ICU download URLs are present, try the
    next one in case of error.
    
    Part of the ICU 63.1 bump, but independent code-wise.
    #23244
    
    PR-URL: #23715
    Fixes: #22344
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Oct 23, 2018
  1. doc: document and warn if the ICU version is too old

    srl295 committed Jun 8, 2018
    Fixes: #19657
    
    PR-URL: #23766
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
  2. deps: icu: apply workaround patch

    srl295 committed Aug 7, 2018
    ICU 62.1 had a bug where certain orders of operations would not
    work with the minimum significant digit setting. Fixed in
    ICU 63.1. Applied the following patch from v8.
    
    https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503
    
    ICU Bug:
    https://unicode-org.atlassian.net/browse/ICU-20063
    
    Fixes: #22156
    
    PR-URL: #23764
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Oct 4, 2018
  1. tools: fix ICU shrinker and docs

    srl295 committed Oct 3, 2018
    - tools: path to ICU datafile moved
    - docs: configure is now configure.py
    
    Fixes: #23245
    
    PR-URL: #23266
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Jul 10, 2018
  1. deps: icu 62.1 bump (Unicode 11, CLDR 33.1)

    srl295 authored and addaleax committed Jul 9, 2018
    - Full release notes: http://site.icu-project.org/download/62
    
    Fixes: #21452
    PR-URL: #21728
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Apr 3, 2018
  1. tools: don’t emit illegal utf-8 from icutrim/iculslocs

    srl295 committed Apr 2, 2018
    - argv[0] was being emitted into a utf-8 stream, but argv[0] may
    not be legal utf-8
    - fix by not emitting argv[0] (was only for a source comment)
    - partially resolves #17077
    
    PR-URL: #19756
    Fixes: #17077
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. deps: ICU 61.1 bump

    srl295 committed Mar 26, 2018
    - Update to released ICU 61.1, including:
      - CLDR 33 (many new languages and data improvements)
      - Many small API additions, improvements, and bug fixes
      - note: 'icu::' namespace is no longer used by default
       (Necessated #18667 )
    
    PR-URL: #19621
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 28, 2018
  1. deps: turn in std::string for ICU

    srl295 committed Mar 5, 2018
    - node and v8 did not call into std::string previously,
    so that access was shut off.
    - this fixes compilation for ICU 58.2 (backlevel) but may
    be expressed in other versions also.
    
    Fixes: #19151
    
    PR-URL: #19624
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Commits on Mar 24, 2018
  1. doc: fix n-api example string

    srl295 authored and tniessen committed Mar 7, 2018
    - using a length of 6 for `"hello"` includes a terminating null yielding
      `"hello\u0000"`
    - length of 5 would work,
    but comparing to the N-API docs gives `NAPI_AUTO_LENGTH` instead
    
    PR-URL: #19205
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Mar 6, 2018
  1. src: #include <stdio.h>" to iculslocs

    srl295 authored and jasnell committed Mar 5, 2018
    iculslocs uses stdio, but didn't include the header.
    
    PR-URL: #19150
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on Feb 10, 2018
  1. src: add "icu::" prefix before ICU symbols

    srl295 committed Feb 8, 2018
    In ICU 61.x, icu4c will no longer put its declarations in the global namespace.
    Everything will be in the "icu::" namespace (or icu_60:: in the linker).
    Prepare for this.
    https://ssl.icu-project.org/trac/ticket/13460
Commits on Jan 30, 2018
  1. doc: Update tools/icu/README.md

    srl295 committed Nov 10, 2017
    - remove TODOs: the one about defaults has been
    addressed, and the one about testing is a work
    item that doesn't belong in a doc.
    - add some background information
    
    Fixes: #7843
    
    PR-URL: #16939
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Jan 18, 2018
  1. deps: ICU 60.2 bump

    srl295 committed Dec 14, 2017
    - Update to Maintainance ICU 60.2
    - CLDR 32.0.1
    - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
    - Subsumes #16931
    
    PR-URL: #17687
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Nov 10, 2017
  1. deps: ICU 60 bump

    srl295 committed Sep 21, 2017
    - Update to released ICU 60.1, including:
      - CLDR 32 (many new languages and data improvements)
      - Unicode 10 (8,518 new characters, including four new scripts,
      7,494 new Han characters, and 56 new emoji characters)
      - UTF-8 malformed bytes now handled according to W3C/WHATWG spec
    
    Fixes: #15540
    PR-URL: #16876
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on May 9, 2017
  1. deps: ICU 59.1 bump

    srl295 committed Apr 13, 2017
    * No feature changes.
    * Bug fixes.
    * Details: http://site.icu-project.org/download/59
    
    Fixes: #12077
    PR-URL: #12486
    Refs: #7844
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Mar 30, 2017
  1. tools: add missing #include "unicode/putil.h"

    srl295 committed Mar 27, 2017
    * we use u_setDataDirectory() in "unicode/putil.h"
    * at present, this header is indirectly included,
      but this will change in ICU 59
    * no impact on past ICUs.
    * this is an exact analog to #11753
    
    PR-URL: #12078
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Mar 9, 2017
  1. src: add missing #include <unicode/ustring.h>

    srl295 committed Mar 8, 2017
    * We use these functions that are declared in <unicode/ustring.h>
    
      u_strFromUTF8()
        u_strToUTF8()
    
    * At present, <unicode/ustring.h> is indirectly included, but this will
    likely change in future ICUs. Adding this header has been the right
    thing to do for many years, so it is backwards compatible.
    
    Fixes: #11753
    PR-URL: #11754
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Jan 6, 2017
  1. deps: add test for v8 bug in toUpper('ç')

    srl295 authored and MylesBorins committed Nov 28, 2016
    * add test for ç/Ç in various locales
    
    PR-URL: #9828
    Fixes: #9785
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
  2. deps: cherry-pick 2f5da9a from V8 upstream

    srl295 authored and MylesBorins committed Dec 30, 2016
    Original commit message:
      Fix the uppercasing of U+00E7(ç) and U+00F7(÷)
      Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased
      while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7).
    
      Add a comprehensive test for Latin-1 supplemental block
      (U+00A0 ~ U+00FF). (they're special-cased for speed-up and
      needs to have a test for the range.).
    
      TEST=intl/general/case-mapping
      BUG=v8:5681
    
      Review-Url: https://codereview.chromium.org/2533033003
      Cr-Commit-Position: refs/heads/master@{#41331}
    
    PR-URL: #9828
    Fixes: #9785
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
Commits on Dec 29, 2016
  1. deps: ICU 58.2 bump download URL

    srl295 committed Dec 9, 2016
    Bump configure download path for ICU from 58.1 to 58.2
    
    * This commit just changes the download URL.
    
    PR-URL: #10206
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. deps: ICU 58.2 bump

    srl295 committed Dec 9, 2016
    Bump ICU from 58.1 to 58.2
    
    No feature changes. Bug fixes.
    * This commit contains the actual ICU source code and data.
    * CLDR 30.0.3 ( was 30.0.2)
    * Timezone 2016j ( was 2016g )
    
    ICU Details:
    http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2
    
    PR-URL: #10206
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Nov 4, 2016
  1. src: default --icu_case_mapping on as a v8 option

    srl295 committed Nov 3, 2016
    * toLocaleUpperCase() and toLocaleLowerCase() do not function properly
    without this flag.
    * basic test case. The test case would fail if `--no_icu_case_mapping`
    was set.
    
    Fixes: #9445
    PR-URL: #9454
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Commits on Oct 31, 2016
  1. deps: Intl: ICU 58 bump - small icu (BIG COMMIT)

    srl295 committed Oct 20, 2016
    This commit contains the ICU 58.1 delta.
    It is especially large because of the ICU license change,
    and, because the line endings were off previously.
    
    * bump to ICU 58.1 - check in small ICU source
    * from 58.1 final http://site.icu-project.org/download/58
    
    Fixes: #7844
    PR-URL: #9234
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. deps: Intl: ICU 58 bump: configure/LICENSE/docs

    srl295 committed Oct 19, 2016
    * bump to ICU 58.1 - update URL / hash
    * does not attempt to reduce size - yet
    * patch to work around http://bugs.icu-project.org/trac/ticket/12822
      ( compile issue on Windows)
    * Fix ICU shrinker to delete old license.html file
      (update to #8674 )
    
    Fixes: #7844
    PR-URL: #9234
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 27, 2016
  1. intl: Add more versions from ICU

    srl295 committed Oct 24, 2016
    * Adds process.versions.cldr, .tz, and .unicode
    * Changes how process.versions.icu is loaded
    * Lazy loads the process.versions.* values for these
    * add an exception to util.js
       to cause 'node -p process.versions' to still work
    * update process.version docs
    
    Fixes: #9237
Commits on May 4, 2016
  1. deps: Intl: ICU 57 bump

    srl295 committed Apr 9, 2016
    * bump to ICU 57.1 - update URL / hash
    
    Fixes: #6058
    PR-URL: #6088
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. tools: Check in tools for shrinking ICU size, change default to small…

    srl295 committed Apr 9, 2016
    …-icu
    
    * Change configure default to "small-icu" (Intl on, English only)
    * add "--without-intl" and "vcbuild without-intl" options, equivalent
    to --with-intl=none
    * update BUILDING.md with above changes
    * Checks in tools that generate the deps/icu-small source directory
    from ICU source
    * Tools and process for updating ICU documented in tools/icu/README.md
    
    Fixes: #3476
    PR-URL: #6088
    Reviewed-By: James M Snell <jasnell@gmail.com>
Older
You can’t perform that action at this time.