Permalink
Switch branches/tags
Commits on Mar 2, 2018
  1. test: add test cases for fsPromises

    watilde committed Feb 28, 2018
    Add tests of lchmod, chown, fchown and lchown.
    
    PR-URL: #19064
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Oct 25, 2017
  1. tools: add make lint-md-clean

    watilde committed May 26, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  2. build: add lint-md-build

    watilde committed May 22, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  3. tools: add lint-md command in Makefile

    watilde committed Apr 30, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  4. tools: use remark-preset-lint-node in .remarkrc

    watilde committed Apr 30, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  5. tools: introduce remark-preset-lint-node

    watilde committed Apr 30, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  6. tools: introduce remark-cli@3.0.1

    watilde committed Apr 30, 2017
    PR-URL: #12756
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  7. doc: fix missing newline character

    watilde authored and lpinca committed Oct 24, 2017
    PR-URL: #16447
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on Oct 24, 2017
  1. doc: fix doc styles

    watilde committed Oct 22, 2017
    CONTRIBUTING.md
      + L857: Unused definition
      + L861: Unused definition
      + L863: Unused definition
    
    doc/api/assert.md
      + L719: Unused definition
    
    doc/api/async_hooks.md
      + L460: Missing code-language flag
    
    doc/api/child_process.md
      + L1362: Unused definition
    
    doc/api/dns.md
      + L674: Unused definition
    
    doc/api/esm.md
      + L178: Missing code-language flag
    
    doc/api/http.md
      + L1868: Unused definition
      + L1887: Unused definition
      + L1888: Unused definition
      + L1889: Unused definition
      + L1916: Unused definition
      + L1917: Unused definition
    
    doc/api/https.md
      + L260: Unused definition
    
    doc/api/os.md
      + L1226: Unused definition
    
    doc/api/process.md
      + L1888: Unused definition
    
    doc/api/stream.md
      + L2227: Definitions with the same identifier
    
    doc/guides/writing-and-running-benchmarks.md
      + L1: Missing newline character at end of file
    
    Refs: #12756
    PR-URL: #16385
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Aug 13, 2017
  1. doc: fix docs style in util.md

    watilde committed Aug 9, 2017
    Summary
      + L582: Cell should be padded
      + L589: Cell should be padded
      + L590: Cell should be padded
      + L600: Cell should be padded
      + L622: Cell should be padded
    
    PR-URL: #14711
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  2. doc: fix docs style in intl.md

    watilde committed Aug 9, 2017
    Summary
      + L43: Add missing final pipe in table fence
      + L45: Add missing final pipe in table fence
      + L46: Add missing final pipe in table fence
      + L47: Add missing final pipe in table fence
      + L48: Add missing final pipe in table fence
      + L49: Add missing final pipe in table fence
      + L50: Add missing final pipe in table fence
      + L51: Add missing final pipe in table fence
      + L52: Add missing final pipe in table fence
      + L53: Add missing final pipe in table fence
      + L54: Add missing final pipe in table fence
      + L55: Add missing final pipe in table fence
    
    PR-URL: #14711
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Commits on Jul 3, 2017
  1. doc: fix api docs style

    watilde committed Jun 28, 2017
    doc/api/cluster.md
      L337: Use the definition link
    
    doc/api/deprecations.md
      L106: Fix the definition link name
    
    doc/api/errors.md
      L901: Remove unused definition
    
    PR-URL: #13970
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Cai <davidcai1993@yahoo.com>
Commits on Jun 19, 2017
  1. doc: fix api docs style

    watilde committed Jun 15, 2017
    doc/api/async_hooks.md
      + L198: Missing code-language flag
      + L239: Missing code-language flag
      + L317: Missing code-language flag
      + L347: Missing code-language flag
    
    doc/api/fs.md
      + L2857: Unused definition
    
    PR-URL: #13700
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on Jun 3, 2017
  1. doc: add require modules in url.md

    watilde committed Jun 1, 2017
    To make the example codes in URL doc work without additional codes,
    it should have more lines to require modules.
    
    PR-URL: #13365
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Commits on May 30, 2017
  1. doc: fix doc styles

    watilde committed May 28, 2017
    BUILDING.md
      + L122: Missing code-language flag
      + L170: Strong should use `*` as a marker
    
    doc/changelogs/CHANGELOG_V6.md
      + L1494: Don't pad `emphasis` with inner spaces
    
    doc/guides/maintaining-V8.md
      + L3: Don't use multiple top level headings
      + L16: Don't use multiple top level headings
      + L40: Don't use multiple top level headings
      + L124: Don't use multiple top level headings
      + L182: Missing code-language flag
      + L223: Don't use multiple top level headings
      + L288: Don't use multiple top level headings
      + L307: Don't use multiple top level headings
    
    doc/guides/writing-tests.md
      + L322: Missing code-language flag
      + L329: Missing code-language flag
    
    doc/releases.md
      + L299: Missing code-language flag
    
    PR-URL: #13270
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on May 28, 2017
  1. doc: fix api docs style

    watilde committed May 26, 2017
    doc/api/fs.md
      + L314: Missing code-language flag
    
    doc/api/stream.md
      + L2120: Do not use definitions with the same identifier
      + L2121: Do not use definitions with the same identifier
      + L2122: Do not use definitions with the same identifier
    
    doc/api/v8.md
      + L157: Move definitions to the end of the file
      + L158: Move definitions to the end of the file
      + L159: Move definitions to the end of the file
      + L160: Move definitions to the end of the file
    
    PR-URL: #13236
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Commits on May 20, 2017
  1. doc: remove unused/duplicated reference links

    watilde committed May 16, 2017
    PR-URL: #13066
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on May 5, 2017
  1. url: handle windows drive letter in the file state

    watilde authored and TimothyGu committed May 3, 2017
    `C|` should not satisfy the condition to not copy
    the base's path. It also synchronises WPT url test data
    to verify the update in upstream.
    
    PR-URL: #12808
    Refs: whatwg/url#305
    Refs: web-platform-tests/wpt#5754
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on May 2, 2017
  1. tools: ignore node_trace.*.log

    watilde committed May 2, 2017
    `node_trace.*.log` files are generated by `NodeTraceWriter`.
    
    Refs: #9304
    PR-URL: #12754
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on May 1, 2017
  1. src: support domains with empty labels

    watilde committed May 1, 2017
    Follow the spec of domainToASCII/domainToUnicode in whatwg, and
    synchronise WPT url test data.
    
    Refs: web-platform-tests/wpt#5397
    PR-URL: #12707
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Apr 14, 2017
  1. url: disallow invalid IPv4 in IPv6 parser

    watilde committed Apr 14, 2017
    Fixes: #10655
    PR-URL: #12315
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Apr 12, 2017
  1. url: remove javascript URL special case

    watilde committed Apr 12, 2017
    Fixes: #11485
    PR-URL: #12331
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Apr 10, 2017
  1. url: trim leading slashes of file URL paths

    watilde committed Apr 10, 2017
    It should trim the slashes after the colon into three for file URL.
    
    PR-URL: #12203
    Refs: web-platform-tests/wpt#5195
    Fixes: #11188
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Apr 3, 2017
  1. test: synchronize WPT url setter test data

    watilde committed Apr 3, 2017
    Updates:
    + Bring tests url-setter-tests from WPT, and put it as JavaScript
    + Comment out unpassed tests
    
    Refs: web-platform-tests/wpt#5112
    Refs: #11887
    PR-URL: #12058
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
  2. test: synchronize WPT url test data

    watilde committed Apr 3, 2017
    Refs: web-platform-tests/wpt#4586
    Refs: #11887
    PR-URL: #12058
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
  3. url: change path parsing for non-special URLs

    watilde committed Apr 3, 2017
    This changes to the way path parsing for non-special URLs.
    It allows paths to be empty for non-special URLs and also
    takes that into account when serializing.
    
    Fixes: #11962
    Refs: whatwg/url#213
    PR-URL: #12058
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Mar 20, 2017
  1. test: synchronize WPT url setters tests data

    watilde committed Mar 20, 2017
    Synchronize url-setter-test to upstream.
    
    Refs: web-platform-tests/wpt#5112
    PR-URL: #11887
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  2. url: restrict setting protocol to "file"

    watilde committed Mar 20, 2017
    Since file URLs can not have `username/password/port`,
    the specification was updated to restrict setting protocol to "file".
    
    Refs: whatwg/url#269
    Fixes: #11785
    PR-URL: #11887
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Mar 14, 2017
  1. test: test resolveObject with an empty path

    watilde committed Mar 14, 2017
    Add a case to test an URL object that has no path at all
    for `url.resolveObject`.
    
    PR-URL: #11811
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  2. net: remove an unused internal module `assertPort`

    watilde committed Mar 14, 2017
    A module `assertPort` in `lib/internal/net.js` is not used anymore.
    
    Refs: #11667
    PR-URL: #11812
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Mar 5, 2017
  1. test: check the origin of the blob URLs

    watilde committed Mar 5, 2017
    In the getter of the origin in URL, the URL that has blob protocol
    will be parsed in a function called "originFor".
    Add test cases into the url-tests-additional fixture to test that.
    
    Refs: web-platform-tests/wpt#4941
    
    PR-URL: #11426
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 4, 2017
  1. url: use `hasIntl` instead of `try-catch`

    watilde authored and jasnell committed Feb 28, 2017
    Like the other internal modules, we should use
    `process.binding('config').hasIntl` instead of `try-catch`
    to make sure `icu` is bonded or not.
    
    PR-URL: #11571
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Commits on Mar 3, 2017
  1. doc: add `Daijiro Wachi` to collaborators

    watilde committed Mar 3, 2017
    PR-URL: #11676
    Reviewed-By: Evan Lucas <evanlucas@me.com>
Commits on Mar 1, 2017
  1. test: add two test cases for querystring

    watilde authored and addaleax committed Feb 25, 2017
    + Cover untested branch in the state machine with the string
      that its first letter is `+` in the key/value.
    + `qs.unescapeBuffer` shouldn't decode `+` to space.
    
    PR-URL: #11551
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Feb 24, 2017
  1. test: add two test cases for querystring

    watilde authored and jasnell committed Feb 21, 2017
    + Check an empty substring: In `querystring`, if the `maxKeys` is 1
      and the state machine finds an empty substring between separators,
      it should return an empty object.
    + Test invalid encoded strings: If provided string is an invalid
      encoded string in `query.parse`, it will not be encoded.
    
    PR-URL: #11481
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>