Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 8.0.0 Tracking Issue #10117

Closed
jasnell opened this issue Dec 5, 2016 · 40 comments
Closed

Node.js 8.0.0 Tracking Issue #10117

jasnell opened this issue Dec 5, 2016 · 40 comments
Assignees
Labels

Comments

@jasnell
Copy link
Member

@jasnell jasnell commented Dec 5, 2016

It's still very early in the process, but this will be the issue that I use to track the issues and todo's around the Node.js 8.0.0 release that will land in April 2017. The current plan is to cut the v8.x branch off master in the first couple of weeks in March 2017 (just about 3 months from now). This issue will be updated periodically with the relevant todo's.

@jasnell jasnell added the meta label Dec 5, 2016
@jasnell jasnell self-assigned this Dec 5, 2016
@targos
Copy link
Member

@targos targos commented Dec 5, 2016

We could also try to use a Github project?

@jasnell
Copy link
Member Author

@jasnell jasnell commented Dec 5, 2016

@targos targos added this to the 8.0.0 milestone Dec 5, 2016
@Trott
Copy link
Member

@Trott Trott commented Dec 5, 2016

Probably need to add an issue for deprecating the current CLI debugger.

@jasnell
Copy link
Member Author

@jasnell jasnell commented Dec 5, 2016

Ooh... Yeah, good idea. We will need the new stuff to come out of experimental at the same time the old debugger deprecates.

@targos
Copy link
Member

@targos targos commented Dec 5, 2016

Yeah this is very important because we will probably have V8 5.8 or 5.9 by the time of the release and the old debugging protocol is removed as of 5.7! See: #9789

@Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented Dec 5, 2016

and the old debugging protocol is removed as of 5.7!

It would be nice if they could have, you know, given us a heads up specifically about that. Thanks V8 team. 😠

Guess we need to issue another semver-minor deprecation in node 7 and maybe 6 that everyone will hate.

@Trott
Copy link
Member

@Trott Trott commented Dec 5, 2016

It would be nice if they could have, you know, given us a heads up specifically about that. Thanks V8 team. 😠

The protocol has been deprecated in V8 for at least one year, and I think longer than that.

@ofrobots opened an issue in June to discuss getting off the deprecated protocol. I'm pretty sure he surfaced the issue before that too, but certainly at least since then.

@Trott
Copy link
Member

@Trott Trott commented Dec 5, 2016

By the way, the debugger thing is on the CTC agenda this week, at least indirectly, as nodejs/CTC#40.

@klimashkin
Copy link

@klimashkin klimashkin commented Dec 5, 2016

@targos Is there a date when 8.0.0 is going to be released?
V5 5.7 will be around the beginning of March, 5.8 - middle of April

@chicoxyzzy
Copy link

@chicoxyzzy chicoxyzzy commented Dec 5, 2016

Node.js 8.0.0 release that will land in April 2017

@klimashkin
Copy link

@klimashkin klimashkin commented Dec 5, 2016

So there is hope that nodejs release will wait for V8 5.8, as 7.0.0 did with 5.4

@Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented Dec 5, 2016

Only if V8 5.8 comes out in April.

@ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Dec 5, 2016

Extrapolating from the schedule, my non-official estimat is that V8 5.8 will go stable during the last week of April. My guesstimate is that Node 8.0.0 will ship on April 25. If we hold things, V8 5.8 may be possible in 8.0.0, but the schedule is too tight for comfort. I don't see a way to get V8 5.9 in though. @targos: perhaps you meant as a ABI compatible upgrade sometime after 8.0?

Re: the old debug protocol. This has been deprecated for at least 2 years – we just haven't done anything about it. I guess the fault is partially mine that I didn't make even more noise about the imminent deprecation. After chatting with the V8 team, they have agreed to delay the removal of the old debug protocol from V8 5.7 to V8 5.8. This should give us some deprecation breathing room if 8.0.0 ships with V8 5.7 instead of V8 5.8. Coming up with an API/ABI compatible patch to upgrade to 5.8/5.9 during the life of 8.x would be a lot more work though.

Regardless, as discussed in the collaborator summit, we will need to immediately start working on figuring out a path forward for the old debug protocol going away.

@jasnell
Copy link
Member Author

@jasnell jasnell commented Dec 5, 2016

The timing is going to depend largely on what kinds of breakage is expected in 5.8. Once the branch is cut in early March, the ability to land semver-major PRs will be cut significantly and will require CTC sign off (that's not an absolute rule, just the way that I'll be handling this release). If there are any breaking changes going into 5.8, they will be need to be reviewed carefully.

@targos
Copy link
Member

@targos targos commented Dec 5, 2016

I don't see a way to get V8 5.9 in though. @targos: perhaps you meant as a ABI compatible upgrade sometime after 8.0?

No you're right. I just went too fast and looked at the Branch points schedule.

@hashseed
Copy link
Member

@hashseed hashseed commented Dec 21, 2016

For the record: the legacy debugging JSON protocol has been deprecated for a very long time already. The reason it stayed functional until now is because there was no reasonable migration path away from it (aside from using the not-well-documented debug context). This has changed since v8-inspector finally landed in V8.

@targos
Copy link
Member

@targos targos commented Feb 6, 2017

I'm trying to integrate V8 5.8 and it seems that vm.runInDebugContext is also compromised.

@klimashkin
Copy link

@klimashkin klimashkin commented Feb 6, 2017

There is only 2 month left for Node 8.
Not sure that 5.5 for Node 7 still makes sense, anyway it's not LTS.
Maybe it's better to spend more effort on 5.8 and its new inspect api, community will happily wait for it : )
Imo

Anyway async in 5.5 is not so fast:

async 5.7 speed

@hashseed
Copy link
Member

@hashseed hashseed commented Feb 7, 2017

@targos what do you mean by "compromised"? v8::Debug::GetDebugContext is deprecated but should still work.

@targos
Copy link
Member

@targos targos commented Feb 7, 2017

@hashseed see https://github.com/nodejs/node/blob/master/src/node_contextify.cc#L262-L275. We are using v8::Debug::GetMirror.
I don't know if this is still needed or can be replaced by something else.
/cc @ofrobots @bnoordhuis

@hashseed
Copy link
Member

@hashseed hashseed commented Feb 7, 2017

Hehehe... check out this: v8@293fc84

@Trott
Copy link
Member

@Trott Trott commented Feb 14, 2017

Three things that need to be worked out, at least two of which will likely come down to the CTC in my opinion:

  • what's the CLI debugger story in v8.0.0 (I think Diagnostics has that worked out already)
  • what to do about Buffer constructor and when (paging @ChALkeR)
  • whether or not to go with the new error system as-is or if it needs modifications or what. My primary motivation at this time is realizing that all error messages are going to change and not being certain of the cost to the ecosystem vs. the benefit. See #11220 (comment) and discussion that follows
@jasnell
Copy link
Member Author

@jasnell jasnell commented Mar 15, 2017

The v8.x and v8.x-staging branches have been cut.
I'm running the first test release build now (https://ci-release.nodejs.org/job/iojs+release/1575/). (Note: This test build does not have the release bit set... it is essentially a cut directly off master).

I will generate a new test build each week and will begin working on the release candidate process starting April 4th.

@nodejs/collaborators @nodejs/ctc ... please work on landing all semver-major commits that should go into Node.js 8.0.0 by April 4th.

@jasnell
Copy link
Member Author

@jasnell jasnell commented Mar 16, 2017

New test build: https://ci-release.nodejs.org/job/iojs+release/1576
(the first run errored out because I'd forgotten that the REPLACEME tags needed to be replaced before running a release build (even for tests... that seems odd)

@jasnell
Copy link
Member Author

@jasnell jasnell commented Mar 27, 2017

@targos
Copy link
Member

@targos targos commented Mar 27, 2017

@jasnell this page is not public? I get "Access Denied".

@jasnell
Copy link
Member Author

@jasnell jasnell commented Mar 27, 2017

It's on the release ci so only release team members have access.

@joaocgreis
Copy link
Member

@joaocgreis joaocgreis commented Mar 28, 2017

@jasnell that looks like nodejs/v8#4, did that run with all the commits from #11752? I see 9c9e2d7 in v8.x-staging now, if it was not when you run the job then that is expected.

@jasnell
Copy link
Member Author

@jasnell jasnell commented Mar 28, 2017

@joaocgreis ... ok. I'll be running another test build tomorrow and will be syncing v8.x-staging and v8.x with master before I run.

@joaocgreis
Copy link
Member

@joaocgreis joaocgreis commented Mar 30, 2017

@jasnell there's a real issue here, tracking in nodejs/build#669 and nodejs/v8#4.

@gordysc
Copy link

@gordysc gordysc commented Apr 26, 2017

Both tickets in the above comment have been closed. Is there still outstanding issues?

@iyobo
Copy link

@iyobo iyobo commented Apr 27, 2017

@gordysc None! Release the Kraken! :D

@kyrylkov
Copy link

@kyrylkov kyrylkov commented Apr 27, 2017

@vjeux
Copy link

@vjeux vjeux commented May 9, 2017

Sorry if this is the wrong place but is node 8 going to have support for trailing commas for function calls? Here's the commit on v8 that implements it: https://bugs.chromium.org/p/v8/issues/detail?id=5051

@klimashkin
Copy link

@klimashkin klimashkin commented May 9, 2017

@vjeux Yes, it was shipped in v8 5.8

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented May 25, 2017

One for the release notes: new Date(...) date parsing follows ES2015 behavior now:

When the time zone offset is absent, date-only forms are interpreted as a UTC time and date-time forms are interpreted as a local time.

Refs #13210 and others.

@jasnell
Copy link
Member Author

@jasnell jasnell commented May 30, 2017

Landed. Thank you all.

@jasnell jasnell closed this May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.