deps/v8/src/objects.h:3263:46: error: invalid use of incomplete type ‘class v8::internal::Heap

[octoploid]

• Version:
• Platform:
• Subsystem:

Compilation fails with gcc-7:

 % g++ '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_I18N_SUPPORT' -I../deps/v8 -I../. -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/markus/tmp/node/out/Release/.deps//home/markus/tmp/node/out/Release/obj.target/v8_nosnapshot/gen/libraries.o.d.raw -c -o /home/markus/tmp/node/out/Release/obj.target/v8_nosnapshot/gen/libraries.o /home/markus/tmp/node/out/Release/obj/gen/libraries.cc

In file included from ../deps/v8/src/snapshot/natives.h:8:0,
                 from /home/markus/tmp/node/out/Release/obj/gen/libraries.cc:8:
../deps/v8/src/objects.h: In member function ‘uint32_t v8::internal::HashTable<Derived, Shape, Key>::Hash(Key)’:
../deps/v8/src/objects.h:3263:46: error: invalid use of incomplete type ‘class v8::internal::Heap’
       return Shape::SeededHash(key, GetHeap()->HashSeed());
                                              ^~
In file included from ../deps/v8/src/v8.h:8:0,
                 from /home/markus/tmp/node/out/Release/obj/gen/libraries.cc:7:
../deps/v8/include/v8.h:149:7: note: forward declaration of ‘class v8::internal::Heap’
 class Heap;
       ^~~~
In file included from ../deps/v8/src/snapshot/natives.h:8:0,
                 from /home/markus/tmp/node/out/Release/obj/gen/libraries.cc:8:
../deps/v8/src/objects.h: In member function ‘uint32_t v8::internal::HashTable<Derived, Shape, Key>::HashForObject(Key, v8::internal::Object*)’:
../deps/v8/src/objects.h:3271:55: error: invalid use of incomplete type ‘class v8::internal::Heap’
       return Shape::SeededHashForObject(key, GetHeap()->HashSeed(), object);
                                                       ^~
In file included from ../deps/v8/src/v8.h:8:0,
                 from /home/markus/tmp/node/out/Release/obj/gen/libraries.cc:7:
../deps/v8/include/v8.h:149:7: note: forward declaration of ‘class v8::internal::Heap’
 class Heap;
       ^~~~

The code is ill formed (no diagnostic required) according the C++ standard.

[targos]

cc @nodejs/v8

[mscdex]

@octoploid What node version?

[octoploid]

Latest git branch master.

[gibfahn]

@octoploid what platform are you on?

[jeisinger]

/cc @hashseed

[octoploid]

I'm running Linux. Let me quote the C++ std:

14.6/8: "If a hypothetical instantiation of a template immediately following its definition would be ill-formed due to a construct that does not depend on a template parameter, the program is ill-formed; no diagnostic is required. If the interpretation of such a construct in the hypothetical instantiation is different from the interpretation of the corresponding construct in any actual instantiation of the template, the program is ill-formed; no diagnostic is required.
[ Note: This can happen in situations including the following: * a type used in a non-dependent name is incomplete at the point at which a template is defined but is complete at the point at which an instantiation is performed, ....

[octoploid]

 % cat tc.ii
class Heap;
class A {
public:
  Heap *m_fn1();
};
template <typename> class B : A {
  void m_fn2() { m_fn1()->HashSeed; }
};
 
% g++ -c tc.ii
tc.ii: In member function ‘void B< <template-parameter-1-1> >::m_fn2()’:
tc.ii:7:25: error: invalid use of incomplete type ‘class Heap’
   void m_fn2() { m_fn1()->HashSeed; }
                         ^~
tc.ii:1:7: note: forward declaration of ‘class Heap’
 class Heap;
       ^~~~

[hashseed]

it should work by including heap.h into natives.h?

[sgallagher]

For the record, just including heap.h (or heap.h plus heap-inl.h) into natives.h does not result in a successful build.

Example: https://kojipkgs.fedoraproject.org//work/tasks/8811/17888811/build.log (note: this is a transient build and will be reaped in seven days)

[kasicka]

Can someone take a look on this already?
New logs:
6.9.5: https://fedorapeople.org/~zvetlik/buildlogs/v695-gcc701build.log
6.10.0: https://fedorapeople.org/~zvetlik/buildlogs/v6100-gcc701build.log

[hashseed]

Some small refactoring to move the code out of objects.h into objects-inl.h should hopefully fix this issue. I'll come up with a patch tomorrow.

[bnoordhuis]

g++ 6.3.1 works okay and I'm not adventurous enough to upgrade my FC25 box to Rawhide. Any suggestions?

[sgallagher]

g++ 6.3.1 works okay and I'm not adventurous enough to upgrade my FC25 box to Rawhide. Any suggestions?

On Fedora 25, you can do:
dnf install mock
Add your user to the mock group in /etc/group and log out and back in (so it takes effect).

Then you can do:

$ mock -r fedora-rawhide-x86_64 init
$ mock -r fedora-rawhide-x86_64 install <packages needed for building>
$ mock -r fedora-rawhide-x86_64 --copyin <src> <dest>
$ mock -r fedora-rawhide-x86_64 shell

Inside that chroot, you essentially have Fedora 26/Rawhide (running on the F25 kernel).

[kasicka]

I usually use rawhide docker images.

[bnoordhuis]

mock made it real easy, thanks. The fix:

diff --git a/deps/v8/src/objects-body-descriptors.h b/deps/v8/src/objects-body-descriptors.h
index 91cb8883be..a1c3634bd7 100644
--- a/deps/v8/src/objects-body-descriptors.h
+++ b/deps/v8/src/objects-body-descriptors.h
@@ -99,7 +99,7 @@ class FixedBodyDescriptor final : public BodyDescriptorBase {
 
   template <typename StaticVisitor>
   static inline void IterateBody(HeapObject* obj, int object_size) {
-    IterateBody(obj);
+    IterateBody<StaticVisitor>(obj);
   }
 };
 

(That method can probably be removed entirely with some more effort.)

And another change to silence that very noisy forward declaration warning:

diff --git a/deps/v8/src/objects-inl.h b/deps/v8/src/objects-inl.h
index 1a8274cbf1..a237d2b753 100644
--- a/deps/v8/src/objects-inl.h
+++ b/deps/v8/src/objects-inl.h
@@ -39,6 +39,27 @@
 namespace v8 {
 namespace internal {
 
+template <typename Derived, typename Shape, typename Key>
+uint32_t HashTable<Derived, Shape, Key>::Hash(Key key) {
+  if (Shape::UsesSeed) {
+    return Shape::SeededHash(key, GetHeap()->HashSeed());
+  } else {
+    return Shape::Hash(key);
+  }
+}
+
+
+template <typename Derived, typename Shape, typename Key>
+uint32_t HashTable<Derived, Shape, Key>::HashForObject(Key key,
+                                                       Object* object) {
+  if (Shape::UsesSeed) {
+    return Shape::SeededHashForObject(key, GetHeap()->HashSeed(), object);
+  } else {
+    return Shape::HashForObject(key, object);
+  }
+}
+
+
 PropertyDetails::PropertyDetails(Smi* smi) {
   value_ = smi->value();
 }
diff --git a/deps/v8/src/objects.h b/deps/v8/src/objects.h
index 747a4f0511..b9279640e2 100644
--- a/deps/v8/src/objects.h
+++ b/deps/v8/src/objects.h
@@ -3531,22 +3531,10 @@ class HashTable : public HashTableBase {
  public:
   typedef Shape ShapeT;
 
-  // Wrapper methods
-  inline uint32_t Hash(Key key) {
-    if (Shape::UsesSeed) {
-      return Shape::SeededHash(key, GetHeap()->HashSeed());
-    } else {
-      return Shape::Hash(key);
-    }
-  }
-
-  inline uint32_t HashForObject(Key key, Object* object) {
-    if (Shape::UsesSeed) {
-      return Shape::SeededHashForObject(key, GetHeap()->HashSeed(), object);
-    } else {
-      return Shape::HashForObject(key, object);
-    }
-  }
+  // Wrapper methods.  Defined in src/objects-inl.h
+  // to break a cycle with src/heap/heap.h.
+  inline uint32_t Hash(Key key);
+  inline uint32_t HashForObject(Key key, Object* object);
 
   // Returns a new HashTable object.
   MUST_USE_RESULT static Handle<Derived> New(

We can float these as patches in v6.x but since the issue also exists in the master branch, I'll upstream them to V8.

[detailyang]

Hello Guys.

+ 1 on Centos 6 with node https://nodejs.org/dist/v6.10.0/node-v6.10.0.tar.gz as the following:

../deps/v8/src/builtins.cc:88:68: error: invalid use of incomplete type 'class v8::internal::{anonymous}::BuiltinArguments<v8::internal::BuiltinExtraArguments:: kTarget>'
 Handle<S> BuiltinArguments<BuiltinExtraArguments::kTarget>::target() {
                                                                    ^
../deps/v8/src/builtins.cc:35:7: error: declaration of 'class v8::internal::{anonymous}::BuiltinArguments<v8::internal::BuiltinExtraArguments:: kTarget>'
 class BuiltinArguments : public Arguments {



$ /opt/gcc/bin/g++ --version
g++ (GCC) 4.8.0
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ cat /etc/issue
CentOS release 6.8 (Final)
Kernel \r on an \m

Any idea?

[bnoordhuis]

@detailyang Try upgrading to gcc 4.8.5 or newer. 4.8.0 has several known bugs that make it impossible to build node.

[detailyang]

Hello.
@bnoordhuis 4.8.5 is okay for me :D
Yup, I try to build node on personal server with Centos 7 gcc 4.8.5 and It's successful. Now I'm ready to upgrade the gcc from 4.8.0 to 4.8.5 on production , you know that it's time-consuming and risky (maybe)

BTW, I think it should be mention on BUILDING.md and I will create a PR to fix this 😁

[bnoordhuis]

Oh, good point. We recently discussed bumping the base line from 4.8 to 4.8.5 but looks like we didn't actually do it yet. A pull request would be welcome.

[octoploid]

Any reason why this patch isn't applied? It fixes the issue for me.

[bnoordhuis]

#12392 - I didn't get around to upstreaming it; things changed quite a bit upstream and I didn't have time to look into it. It's probably no longer an issue there.

[bnoordhuis]

Fixed in 2bbee49, should be in the next v7.x release.