Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`test-npm` applicability #12836

Closed
Trott opened this issue May 4, 2017 · 3 comments

Comments

@Trott
Copy link
Member

commented May 4, 2017

  • Version: v8.0.0-pre
  • Platform: all
  • Subsystem: doc,test

What's the deal with make test-npm? Who is supposed to run that and when?

A lot of new folks have problems with it, and they're only running it because it's in BUILDING.md. I wonder if it should be moved in that doc, removed from that doc, annotated in that doc, or if it really is generally applicable and should be made more robust.

@Trott Trott added doc npm test labels May 4, 2017
@Fishrock123

This comment has been minimized.

Copy link
Member

commented May 4, 2017

Annotated? You should really only need to run it if you are upgrading npm. pretty much no one does that except from me and @MylesBorins at the current time.

It will not run/work on Windows. It does not pass on Linux as of the latest time someones tried it. (Alpine, maybe?)

Since it is not suitable for our CI (I think it still makes network calls? maybe cc @nodejs/npm) it is run on our local macOS machines prior to an npm upgrade.

@addaleax

This comment has been minimized.

Copy link
Member

commented May 4, 2017

removed from that doc

I’d say so, yes

It does not pass on Linux as of the latest time someones tried it.

Fwiw the npm tests doesn’t pass for me on Linux until npm/npm#16474 gets merged even outside of make test-npm 😄

@Trott Trott added the question label May 4, 2017
Trott added a commit to Trott/io.js that referenced this issue May 4, 2017
`make test-npm` is not particularly robust (currently fails on Linux and
Windows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.

Refs: nodejs#12836
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 4, 2017

PR submitted. This isn't a bug report (or is only sort of a bug report), just a question, so I'm going to close it.

@Trott Trott closed this May 4, 2017
addaleax added a commit that referenced this issue May 7, 2017
`make test-npm` is not particularly robust (currently fails on Linux and
Windows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.

Refs: #12836
PR-URL: #12840
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
`make test-npm` is not particularly robust (currently fails on Linux and
Windows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.

Refs: nodejs#12836
PR-URL: nodejs#12840
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn added a commit that referenced this issue Jun 20, 2017
`make test-npm` is not particularly robust (currently fails on Linux and
Windows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.

Refs: #12836
PR-URL: #12840
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this issue Jul 11, 2017
`make test-npm` is not particularly robust (currently fails on Linux and
Windows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.

Refs: #12836
PR-URL: #12840
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.