-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Coordinating HTTP2 work with Express #15203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm happy to jump on a meeting at any time. We really want See for some of the technical details: expressjs/express#3390 (comment) |
The whole compatibility question has been one of the key issues all along. We knew going in that there were going to be some rough spots that needed work. The compatibility API layer needs to be the main focus of this. |
Would be happy to help out in any way I can & that is needed. |
Accidentally closed this, sorry! |
Needless to say I'd be more than happy to help in any way. |
I would love to see both @phouri and @apapirovski attend the express meeting. @apapirovski thanks a lot for all your recent HTTP2 work by the way - keep up! |
I'll try to dig into how this is all setup in hapijs/hapi (which I use in production), just to have another point of reference as we try to figure out the compatibility layer. |
FWIW hapi seems to work with the compatibility layer. There's an issue with them maintaining a flag on the socket which becomes unavailable after the finish event but not sure if that's our or their problem (we would have to maintain a reference to the session or the socket which doesn't seem great). Hard to tell the extent to which it's compatible without running their test suite which is only h1. The site I tested it on ran fine but I'm almost certainly not using even half of the functionality available. |
Not sure if this is the place for a for/against the compatibility layer discussion, but I'll mention my experience. I'm building a web backend framework with a pretty different approach than the current ones (express, koa, hapi). It's still drafting/testing and not available to anyone, so there's nothing to show yet and I won't go into detail about it here. However, I never even considered touching the compatibility layer. In my view, HTTP/2 is radically different than HTTP/1(.1). The push is a nice feature, not that architecturally remarkable for higher-level API's like Node.js' The new API, in my view, is generally good in that it's close to the protocol and does no magic. I must say though, that I'm allergic to the monoliths of the old Overall, with the Github issues (and fixes for them) included, the API is good. One can relatively painlessly build applications (and most importantly, frameworks) on top of it. Well done, and thanks for the work. |
What's the current status here? Do we need to keep this issue open? |
@jasnell unless express 5 was released with http2, I think so |
I've been waiting on that code from @apapirovski or at least if someone wanted to implement the same thing again. I'm happy to pick apart the code from the dump if I can get access to it 👍 |
Closing as stale. |
Hey,
Related to expressjs/express#3390 - @phouri has been trying to do work in order to get Express to work with HTTP2 and it seems like there are a few questions and blockers.
I'd love to hear from @nodejs/http2 what prior work was done on getting HTTP2 to work in Express and know how we can help smooth things out.
In the thread @dougwilson wrote:
I thought we could set up a short meeting to make sure everyone is on the same page and @phouri and other contributors can keep working on it.
Thanks :)
The text was updated successfully, but these errors were encountered: