Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Process V8 profiler output not working (new v8.10.0) #19199
After generate log statistical profiling information (
I've been testing with example from Easy profiling for Node.js Applications.
It works fine with previous v8.9.4 version. You can use Simple profiling repository to test it.
Can you explain more about how to reproduce with that repository?
This is what I get when I run the steps from the readme on a vagrant box (on a macOS machine):
I set up the VM with:
vagrant init ubuntu/artful64 vagrant up vagrant ssh
And then used nvm to install node
One observation that might help:
The issue happens when I use node --prof with v8.10.0 to record the profiling information and then --prof-process gets stuck with either v8.10.0 or v8.9.4.
However, when I use v8.9.4 to create the profiler file, both versions succeed with --prof-process...
It looks like the .log files produced by node v8.9.4 have a newline at the end, and the ones produced by v8.10.0 don't.
I built a debug build of v8.10.0 and interrupted it in the debugger while it was hanging. It seems to be calling filesystem read in an infinite loop. I guess something expects a newline at the end of the file.
None of the log files I can generate to cause the hanging end with 0xa and all of the ones that work end with 0xa.
Not sure where that expectation is happening though, also not sure whether the v8 profiler output changed or if node itself writes the file.