Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add node-report to cdp and add Visual Panel like React or Vue #27858

Open
gengjiawen opened this issue May 24, 2019 · 8 comments
Open

Comments

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented May 24, 2019

I found node-report is very usefully (tbh I am a little surprised that Node.js has this level of clarity, really amazing job 馃憤 ), in some cases more usefully than profiler :)
I would like two thing:

screenshot

cc @nodejs/inspector @nodejs/report @richardlau
(Not sure I ping the group right, I don't know the Node.js group category )

@richardlau

This comment has been minimized.

Copy link
Member

@richardlau richardlau commented May 24, 2019

@gireeshpunathil

This comment has been minimized.

Copy link
Member

@gireeshpunathil gireeshpunathil commented May 27, 2019

  • adding report to the CDP panel of Vuejs: makes perfect sense, as one could generate an in-memory report upon user selection, and then render the relevant sections in the view.
  • adding report to the CDP protocol: Not very much sure about how does it work / help. Can you please elaborate a little on that?

Also in both cases, where does the feature be developed? in core, or in chrome? can the report.getReport() api can be consumed as is by the panel / protocol implementors?

@gireeshpunathil

This comment has been minimized.

Copy link
Member

@gireeshpunathil gireeshpunathil commented May 27, 2019

node-report largely is used to refer the original npm module https://www.npmjs.com/package/node-report and diagnostic-report or simply report is used to refer to the one that is available in core. It may be great if you change the title to reflect the right report meant in this case.

@gengjiawen

This comment has been minimized.

Copy link
Member Author

@gengjiawen gengjiawen commented May 27, 2019

adding report to the CDP panel of Vuejs

Nope, my thought is a new panel, like opened in chrome://inspect. May need to change chrome front-end code https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/node_main/NodeConnectionsPanel.js.

image

image

node-report largely is used to refer the original npm module npmjs.com/package/node-report.

Hopefully work on Node.js with node-report installed too.

@hashseed

This comment has been minimized.

Copy link
Member

@hashseed hashseed commented May 27, 2019

TBH I don't know how much value it is to show the JSON data that node-report or diagnostic-report provides in a DevTools panel, visually..

@gengjiawen

This comment has been minimized.

Copy link
Member Author

@gengjiawen gengjiawen commented May 27, 2019

TBH I don't know how much value it is to show the JSON data that node-report or diagnostic-report provides in a DevTools panel, visually..

Kind of like DOM in front end (Elements Panel in Devtools).

@june07

This comment has been minimized.

Copy link

@june07 june07 commented Nov 18, 2019

@gengjiawen Will likely drop in the next version of NiM(see screenshot from the DevTools Panel)...

Will have the ability to save reports and quickly access reports from multiple node instances.

image

Stay tuned.

@june07

This comment has been minimized.

Copy link

@june07 june07 commented Dec 27, 2019

Took over a week to get the update pushed thru the Chrome Web Store but it is done. https://blog.brakecode.com/nodejs-diagnostic-reports/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can鈥檛 perform that action at this time.