Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test/js-native-api/test_bigint/test.js #30185

Open
mpark86 opened this issue Oct 31, 2019 · 2 comments
Open

Improve test/js-native-api/test_bigint/test.js #30185

mpark86 opened this issue Oct 31, 2019 · 2 comments

Comments

@mpark86
Copy link
Contributor

@mpark86 mpark86 commented Oct 31, 2019

Replace assert.throws with common.expectsError in test/js-native-api/test_bigint/test.js.

@lundibundi

This comment has been minimized.

Copy link
Member

@lundibundi lundibundi commented Nov 22, 2019

@mpark86 ping, did you perhaps forgot to open a PR?
(Also, PTAL https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines for commit message guidelines)

@yorkie

This comment has been minimized.

Copy link
Member

@yorkie yorkie commented Nov 22, 2019

Add a direct PR link: master...mpark86:issue-30185 :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.