Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openssl 1.1.1f (across all release lines) #32537

Closed
sam-github opened this issue Mar 28, 2020 · 4 comments
Closed

update openssl 1.1.1f (across all release lines) #32537

sam-github opened this issue Mar 28, 2020 · 4 comments

Comments

@sam-github
Copy link
Contributor

sam-github commented Mar 28, 2020

Yes, another one! :-)

https://mta.openssl.org/pipermail/openssl-announce/2020-March/000168.html

Looks like its related to the EOF detection issue:

#32210 (comment)

@nodejs/releasers Might affect release plans, though I'm still not convinced that issue affects Node.js, we only saw it when interacting with openssl s_client/s_server, which had a bug in their implementation that became noticable after the behaviour change in OpenSSL 1.1.1e.

Still, with all the release delays, its likely that 1.1.1f can go out in place of 1.1.1e 10.x. I don't recall from memory the current state of release plans for 12 and 13, I'll check them out Monday (if no one beats me to it).

@hassaanp Interested in doing this update? It really should be trivial, compared to the last one! (famous last words...).

@hassaanp
Copy link
Contributor

hassaanp commented Mar 28, 2020

I'm in.

@hassaanp
Copy link
Contributor

hassaanp commented Mar 31, 2020

The updated version has been published. Pulling it now

@hassaanp
Copy link
Contributor

hassaanp commented Mar 31, 2020

Successfully built and tests ran without any issues.

Kindly review @sam-github

#32583

@hassaanp
Copy link
Contributor

hassaanp commented Apr 14, 2020

New version 1.1.1g coming in on the 21st
I can take care of it.

cc: @sam-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants