Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tty.isatty" results in an abort #37805

Closed
zyscoder opened this issue Mar 19, 2021 · 0 comments · Fixed by #37809
Closed

"tty.isatty" results in an abort #37805

zyscoder opened this issue Mar 19, 2021 · 0 comments · Fixed by #37809
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@zyscoder
Copy link

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

tty = require('tty');tty.isatty(1000000000000000000);

Then an abort occurs.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node                                                                                                                                                                                                                                                 134 ↵ zys@zys-X299-UD4-Pro
Welcome to Node.js v14.15.1.
Type ".help" for more information.
> tty = require('tty');tty.isatty(1000000000000000000);
node[57893]: ../src/tty_wrap.cc:73:static void node::TTYWrap::IsTTY(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `(fd) >= (0)' failed.
 1: 0xa03530 node::Abort() [node]
 2: 0xa035ae  [node]
 3: 0xaea222  [node]
 4: 0xbe369b  [node]
 5: 0xbe4c46  [node]
 6: 0xbe52c6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 7: 0x13ff259  [node]
[1]    57893 abort (core dumped)  node

Additional information

@aduh95 aduh95 added the confirmed-bug Issues with confirmed bugs. label Mar 19, 2021
aduh95 added a commit to aduh95/node that referenced this issue Mar 19, 2021
aduh95 added a commit to aduh95/node that referenced this issue Mar 19, 2021
@aduh95 aduh95 closed this as completed in 134fb5a Mar 23, 2021
ruyadorno pushed a commit that referenced this issue Mar 24, 2021
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants