Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented `readline` methods #3836

Closed
sindresorhus opened this issue Nov 15, 2015 · 6 comments

Comments

Projects
None yet
7 participants
@sindresorhus
Copy link

commented Nov 15, 2015

There are several exposed methods on readline that are not documented:

They should IMHO either be documented or made internal. Preferably the latter.

Most of these are already modules on npm anyways:

@tejasmanohar

This comment has been minimized.

Copy link

commented Nov 16, 2015

@sindresorhus Just submitted a PR for these.

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

PR: #3847

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2015

I'm going to keep this open, as #3862 doesn't cover readline.emitKeypressEvents(). On the last CTC call, the discussion to deprecate or document this function was tabled.

@cjihrig cjihrig reopened this Nov 19, 2015

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 2, 2016

@cjihrig ... do we still need to keep this one open?

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2016

@jasnell I'll submit a PR to address this so that it can be closed one way or the other.

@cjihrig cjihrig referenced this issue Apr 3, 2016

Closed

readline: document emitKeypressEvents() #6024

3 of 3 tasks complete
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2016

Documented in 3de9bc9.

@cjihrig cjihrig closed this Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.