New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v19.8.0] module_wrap.cc:599: Assertion (it) != (env->id_to_function_map.end())' failed.
#47096
[v19.8.0] module_wrap.cc:599: Assertion (it) != (env->id_to_function_map.end())' failed.
#47096
Comments
module_wrap.cc:599: Assertion
(it) != (env->id_to_function_map.end())' failed.`
module_wrap.cc:599: Assertion
(it) != (env->id_to_function_map.end())' failed.`module_wrap.cc:599: Assertion (it) != (env->id_to_function_map.end())' failed.
For reference here is the error stack on darwin-arm64:
|
We have a similar issue but a slightly different stack trace. Might be related?
|
Note: We hard-pinned our node version to 19.7 (without any other code changes) and that fixed our issue. Obviously would love to see if the issue can be fixed so we can upgrade to 19.8 |
We're consistently hitting the following on 19.8.0:
Previous runs on 19.7.0 were not hitting this. |
I also have this problem. |
I have this problem as well |
I confirm that reverting #46785 fixes the crash. /cc @joyeecheung @nodejs/cpp-reviewers |
For me downgrading to 19.7 also fixed the issue |
We're also having the issue, and downgrading to 19.7 fixed it. |
This is happening on shopify-cli When installing with homebrew, we can't force shopify-cli to use a different version, nor can we easily install an older version on homebrew. |
@ekwoka you can run |
Ah, interesting! I was trying to edit node to get it to use 19.7 but it always would use 19.8 no matter what I tried. |
@ErCollao chan you share command to downgrade node version? |
We're facing the same issue; we've solved pinning 19.7 |
nodejs/node#47096 Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
nodejs/node#47096 Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
…ly is used" This reverts commit 986498b. Fixes: #47096 PR-URL: #47101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
…ly is used" This reverts commit 986498b. Fixes: #47096 PR-URL: #47101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
We actually had the problem in CI (with the |
I just found out that you can install shopify-cli through NPM instead of homebrew to avoid this issue |
v19.8.1 was just released to fix this issue. |
Nice. But why is this happening? |
Related issue in actions/setup-node |
Works for me! Thanks for fixing. |
Also broke in vite:
|
`nodejs@19.8.0` causes tests to fail because node exists with a non-zero exit code, see nodejs/node#47096 for more information
edit @bnoordhuis: fixed in v19.8.1
Version
v19.8.0
Platform
all
Subsystem
No response
What steps will reproduce the bug?
Sorry haven't found a minimal repro.
I'll update here if I do.
Currently, it can be reproduced through the following steps.
git clone https://github.com/babel/babel
make bootstrap
yarn jest
This is still not minimal, but I can't find where it crashes.
https://github.com/liuxingbaoyu/node-bug
How often does it reproduce? Is there a required condition?
always
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
Additional information
This is a regression bug.
Might be related to #46785.
The text was updated successfully, but these errors were encountered: