New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: addons cannot use the bundled OpenSSL #4932

Closed
murgatroid99 opened this Issue Jan 28, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@murgatroid99
Copy link

murgatroid99 commented Jan 28, 2016

This is basically a copy of nodejs/node-v0.x-archive#4051, since it looks like that repository is obsolete and the problem still exists in the latest version of Node.

In the Node development package on Windows, the include directory has an openssl subdirectory with all of the OpenSSL headers, but the node.lib libraries do not export those symbols to link against.

This means that any Node extension that wants to use OpenSSL must instruct its users to follow the instructions at https://github.com/nodejs/node-gyp/wiki/Linking-to-OpenSSL#windows.

@murgatroid99

This comment has been minimized.

Copy link

murgatroid99 commented Jan 28, 2016

As a side note, the headers in include/node/openssl/ seem to be the same, or very similar, to the headers in deps/openssl/openssl/include/openssl/ on Linux. For the purposes of node-gyp, module authors are instructed to include the latter path on systems where Node exports OpenSSL symbols, but to use a different include path on Windows. However, because the headers are also in the former path, they are included anyway and can conflict with the included headers on Windows.

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Jan 28, 2016

@nodejs/platform-windows ping, we need some expertise here, I can't answer this but am ready to help out where needed if we need to take action

@saper

This comment has been minimized.

Copy link

saper commented Apr 4, 2016

As a part of the build process one of the libraries generated is lib/openssl.lib:

  6177422  01-10-16 04:26   lib/cares.lib
 12294090  01-10-16 04:26   lib/gtest.lib
   117192  01-10-16 04:26   lib/http_parser.lib
  5619094  01-10-16 04:26   lib/libuv.lib
 70660776  01-10-16 04:26   lib/openssl.lib
   744562  01-10-16 04:26   lib/zlib.lib

Maybe ass a temporary workaround we should just publish those?

@bnoordhuis

This comment has been minimized.

Copy link
Member

bnoordhuis commented Aug 22, 2016

Fixed by #6274.

@bnoordhuis bnoordhuis closed this Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment