New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.parse result differences in 5.7.x to 5.6.x #5393

Closed
tombell opened this Issue Feb 23, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@tombell

tombell commented Feb 23, 2016

  • Version: v5.7.0
  • Platform: Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64

I updated to Node 5.7.0 today, which results in my Cordova build breaking due to a change in the output of url.parse.

In Node 5.5.0 the output of parsing https://* was the following:

{ protocol: 'https:',
  slashes: true,
  auth: null,
  host: '',
  port: null,
  hostname: '',
  hash: null,
  search: null,
  query: null,
  pathname: '/*',
  path: '/*',
  href: 'https:///*' }

However this changed when updating to 5.7.0:

Url {
  protocol: 'https:',
  slashes: true,
  auth: null,
  host: '',
  port: null,
  hostname: '',
  hash: null,
  search: null,
  query: null,
  pathname: null,
  path: null,
  href: 'https://' }

The pathname being null now broke the Cordova CLI library. Was this change intended to be breaking?

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Feb 23, 2016

/cc @mscdex

@MylesBorins MylesBorins added the url label Feb 23, 2016

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Feb 23, 2016

The pathname being null now broke the Cordova CLI library. Was this change intended to be breaking?

No, though we did have a large path refactor.

mscdex added a commit to mscdex/io.js that referenced this issue Feb 23, 2016

@mscdex mscdex referenced this issue Feb 23, 2016

Closed

url: fix off-by-one error with parse() #5394

4 of 4 tasks complete

@Fishrock123 Fishrock123 modified the milestone: v5.7.1 Feb 23, 2016

@Fishrock123 Fishrock123 referenced this issue Feb 23, 2016

Closed

propose v5.7.1 #5400

0 of 3 tasks complete

rvagg added a commit that referenced this issue Feb 28, 2016

url: fix off-by-one error with parse()
Fixes: #5393
PR-URL: #5394
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment