Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment fault when compile node 0.1x branch with gcc 6.1.1 in 64bit linux #6724

Closed
vitalybupt opened this issue May 13, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@vitalybupt
Copy link

commented May 13, 2016

  • 0.12.7:
  • Linux 4.5.3-1-ARCH #1 SMP PREEMPT Sat May 7 20:43:57 CEST 2016 x86_64 GNU/Linux:
    :

after update gcc version from 5.3 to 6.1.1, the compile of node 0.12.7 failed with segment fault, this issue not happened when compile debug version and i compile 0.12.14 the issue still exist and it disappeared after remove -O3 from makefile.
debug the issue found the reason is:
#0 v8::internal::PagedSpace::Contains (addr=0x0, this=0xd61ff0) at ../deps/v8/src/heap/spaces-inl.h:152 152 return p->owner() == this;
the input argument addr is null, after add a check for the input argument, this issue disappear.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented May 13, 2016

Try building with make CXX="g++ -fno-delete-null-pointer-checks". v0.12 is in maintenance mode and close to being EOL'd so I don't think we'll fix this.

Perhaps if we do another v0.12 release (big if), we could add -fno-delete-null-pointer-checks to the default build flags.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 13, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs#6724

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 13, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs#6724
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented May 13, 2016

Perhaps if we do another v0.12 release (big if), we could add -fno-delete-null-pointer-checks to the default build flags.

I filed #6737 and #6738 for v0.12 and v0.10 respectively.

jasnell added a commit that referenced this issue May 25, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

rvagg added a commit that referenced this issue Jun 23, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

rvagg added a commit that referenced this issue Sep 22, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

rvagg added a commit that referenced this issue Sep 22, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

jBarz added a commit to ibmruntimes/node that referenced this issue Nov 4, 2016

build: turn on -fno-delete-null-pointer-checks
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs/node#6724
PR-URL: nodejs/node#6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

Closing this given that support for v0.12 is coming to a close in two days and there will not be any further updates to the v0.12 branch.

@jasnell jasnell closed this Dec 29, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Jan 10, 2017

For posterity: this was fixed in v0.10.47 and v0.12.16, released in September 2016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.