Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 modification and include error message #10016

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
10 participants
@christyleung1987
Copy link

christyleung1987 commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mscdex mscdex added the lib / src label Dec 1, 2016

@addaleax addaleax referenced this pull request Dec 1, 2016

Closed

es6 modification and include error msg #9983

2 of 3 tasks complete
test/parallel/test-internal-modules.js Outdated

assert.throws(function() {
assert.throws(function(err, cb) {
if (err) return cb(err);
require('internal/freelist');
});

This comment has been minimized.

Copy link
@addaleax

addaleax Dec 3, 2016

Member

Sorry, the snippet explaining the task probably should have been a bit more precise on what to do here – This function won’t be called with err and cb arguments.

assert.throws takes a second argument that can be a regexp and validates the error message against that (like this). Do you think you could update this PR with that?

This comment has been minimized.

Copy link
@christyleung1987

christyleung1987 Dec 4, 2016

Author

ack, working on this now

This comment has been minimized.

Copy link
@Trott

Trott Dec 22, 2016

Member

Ping @christyleung1987: Still working on this? (If you have any questions or need additional assistance, feel free to ask here or on the #node-dev channel on Freenode IRC.)

@Trott Trott force-pushed the christyleung1987:test branch to e61fa9a Dec 24, 2016

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 24, 2016

@christyleung1987 I took the liberty of making the change requested by @addaleax and pushing it to your branch. Hope that's OK!

If some reviewers could please take a look, that would be great!

@Trott

This comment has been minimized.

@christyleung1987

This comment has been minimized.

Copy link
Author

christyleung1987 commented Dec 24, 2016

Hi all,

Sorry for the late reply, I didn't mean to ignore the messages, but I got the flu and strap throat at the same time and I'm still trying to recover from it. This has been a really great learning experience.

Trott added a commit to Trott/io.js that referenced this pull request Dec 24, 2016

test: refactor test-internal-modules
* var -> const
* add RegExp to assert.throws() to check error message

PR-URL: nodejs#10016
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 24, 2016

Landed in c00f647.
Thanks for the contribution, @christyleung1987! 🎉

@Trott Trott closed this Dec 24, 2016

targos added a commit that referenced this pull request Dec 26, 2016

test: refactor test-internal-modules
* var -> const
* add RegExp to assert.throws() to check error message

PR-URL: #10016
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 27, 2016

Merged

V6.9.3 proposal #10394

@evanlucas evanlucas referenced this pull request Jan 3, 2017

Merged

v7.4.0 release proposal #10589

evanlucas added a commit that referenced this pull request Jan 3, 2017

test: refactor test-internal-modules
* var -> const
* add RegExp to assert.throws() to check error message

PR-URL: #10016
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas added a commit that referenced this pull request Jan 4, 2017

test: refactor test-internal-modules
* var -> const
* add RegExp to assert.throws() to check error message

PR-URL: #10016
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.