New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: re-enable watch facility in AIX #10085

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
@gireeshpunathil
Member

gireeshpunathil commented Dec 2, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

Description of change

Please refer to 5085 for a full description of the background, need for this PR, and the changes.

On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 2, 2016

Member

I am excited to see the AIX exceptions removed from parallel.status. Thanks for doing this!

The JS test code change looks good to me. The text in the paragraph added to the doc needs some editing. Maybe someone from @nodejs/documentation can take a look and provide a reformatted version.

Member

Trott commented Dec 2, 2016

I am excited to see the AIX exceptions removed from parallel.status. Thanks for doing this!

The JS test code change looks good to me. The text in the paragraph added to the doc needs some editing. Maybe someone from @nodejs/documentation can take a look and provide a reformatted version.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 2, 2016

Member

Oh, I see there are changes in deps/uv. I suspect those would need to be upstreamed to the libuv project. (Do we float patches on libuv?)

Member

Trott commented Dec 2, 2016

Oh, I see there are changes in deps/uv. I suspect those would need to be upstreamed to the libuv project. (Do we float patches on libuv?)

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Dec 2, 2016

Member

Do we float patches on libuv?

No.

Member

bnoordhuis commented Dec 2, 2016

Do we float patches on libuv?

No.

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Dec 2, 2016

Member

@Trott , @bnoordhuis , thanks. So what is the recommendation here? first have a PR for the uv change, and then come back here with the rest of the changes? or progress this PMR and schedule the uv PR before the next libuv release separately? sorry for being blunt here, I don't know the process much.

Member

gireeshpunathil commented Dec 2, 2016

@Trott , @bnoordhuis , thanks. So what is the recommendation here? first have a PR for the uv change, and then come back here with the rest of the changes? or progress this PMR and schedule the uv PR before the next libuv release separately? sorry for being blunt here, I don't know the process much.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Dec 2, 2016

Member

@gireeshpunathil libuv PR -> libuv release -> libuv upgrade in node -> node PR -> node release. You can file the node PR ahead of time but it can't land until the libuv upgrade.

Member

bnoordhuis commented Dec 2, 2016

@gireeshpunathil libuv PR -> libuv release -> libuv upgrade in node -> node PR -> node release. You can file the node PR ahead of time but it can't land until the libuv upgrade.

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Dec 2, 2016

Member

ok, got it. will work on the libuv PR, to follow the sequence.

Member

gireeshpunathil commented Dec 2, 2016

ok, got it. will work on the libuv PR, to follow the sequence.

@mscdex mscdex added the aix label Dec 3, 2016

@gireeshpunathil gireeshpunathil referenced this pull request Feb 7, 2017

Closed

deps: upgrade libuv to 1.11.0 #11094

2 of 2 tasks complete
@mhdawson

LGTM

Show outdated Hide outdated doc/api/fs.md
@@ -1750,6 +1750,13 @@ a new inode. The watch will emit an event for the delete but will continue
watching the *original* inode. Events for the new inode will not be emitted.
This is expected behavior.
In AIX, Save and close of a file being watched causes two notifications -
one for adding new content, and one for truncation. Moreover, save and close
causes other platforms to loose the watching - as the inode changes.

This comment has been minimized.

@thefourtheye

thefourtheye Feb 8, 2017

Contributor

lose

@thefourtheye

thefourtheye Feb 8, 2017

Contributor

lose

This comment has been minimized.

@jasnell

jasnell Feb 8, 2017

Member

Suggest rewording just a bit...

Moreover, save and close operations on some platforms cause inode changes
that force watch operations to become invalid and ineffective.
@jasnell

jasnell Feb 8, 2017

Member

Suggest rewording just a bit...

Moreover, save and close operations on some platforms cause inode changes
that force watch operations to become invalid and ineffective.
@jasnell

jasnell approved these changes Feb 8, 2017

One nit but otherwise LGTM

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.
@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Feb 9, 2017

Member

made the doc changes as per @jasnell . @thefourtheye - thanks, your change proposal is indirectly addressed, as the entire sentence is now modified.

Member

gireeshpunathil commented Feb 9, 2017

made the doc changes as per @jasnell . @thefourtheye - thanks, your change proposal is indirectly addressed, as the entire sentence is now modified.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Feb 9, 2017

Contributor

Landed in 46edd94. Thanks!

Contributor

cjihrig commented Feb 9, 2017

Landed in 46edd94. Thanks!

@cjihrig cjihrig closed this Feb 9, 2017

cjihrig added a commit that referenced this pull request Feb 9, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Feb 10, 2017

Member

thanks everyone!

Member

gireeshpunathil commented Feb 10, 2017

thanks everyone!

italoacasas added a commit that referenced this pull request Feb 13, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs#11094
Refs: nodejs#5085
PR-URL: nodejs#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs#11094
Refs: nodejs#5085
PR-URL: nodejs#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

should this land in v6 or v4?

Member

jasnell commented Mar 7, 2017

should this land in v6 or v4?

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Mar 8, 2017

Member

I guess no, as this PR depends on aix: re-enable fs watch facility from libuv 1.11.0, which v6 and v4 haven't consumed.

Member

gireeshpunathil commented Mar 8, 2017

I guess no, as this PR depends on aix: re-enable fs watch facility from libuv 1.11.0, which v6 and v4 haven't consumed.

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Mar 8, 2017

Member

@jasnell - ok, I see your question to LTS in 11094 as well. So answer here will depend on that decision.

Member

gireeshpunathil commented Mar 8, 2017

@jasnell - ok, I see your question to LTS in 11094 as well. So answer here will depend on that decision.

MylesBorins added a commit that referenced this pull request May 16, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 23, 2017

Merged

v6.11.0 proposal #13059

andrew749 added a commit to michielbaird/node that referenced this pull request Jul 19, 2017

fs: re-enable watch facility in AIX
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs/node#11094
Refs: nodejs/node#5085
PR-URL: nodejs/node#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment