Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use ES6 in test-debugger-client.js #10183

Closed
wants to merge 1 commit into from

Conversation

@edsadr
Copy link
Member

commented Dec 8, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

implements ES6 const and let instead of var in test-debugger-client.js

test: use ES6 in test-debugger-client.js
implements ES6 const and let instead var in test-debugger-client.js
@cjihrig
cjihrig approved these changes Dec 9, 2016
@thefourtheye
Copy link
Contributor

left a comment

LGTM if CI is happy.

@benjamingr

This comment has been minimized.

@edsadr

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2016

@benjamingr looks like the CI didn't start ..

@benjamingr

This comment has been minimized.

Copy link
Member

commented Dec 12, 2016

@italoacasas

This comment has been minimized.

Copy link
Member

commented Dec 12, 2016

The CI is green, for some reason, Github does not show the output on this one.

@targos

This comment has been minimized.

Copy link
Member

commented Dec 12, 2016

It's just that POST_STATUS_TO_PR hasn't been checked

@italoacasas

This comment has been minimized.

Copy link
Member

commented Dec 12, 2016

Landed 5607228

Thanks for the contribution Adrian.

italoacasas added a commit that referenced this pull request Dec 12, 2016
test: use ES6 in test-debugger-client.js
implements ES6 const and let instead var in test-debugger-client.js

PR-URL: #10183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 added a commit that referenced this pull request Dec 13, 2016
test: use ES6 in test-debugger-client.js
implements ES6 const and let instead var in test-debugger-client.js

PR-URL: #10183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas referenced this pull request Dec 15, 2016
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jan 16, 2017

This is not landing cleanly on v4.x and the test on v6.x is timing out with / without this change. opting no to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.