deps: ICU 58.2 bump #10206

Closed
wants to merge 2 commits into
from

Projects

None yet

6 participants

@srl295
Member
srl295 commented Dec 9, 2016 edited
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

  • CLDR 30.0.3 ( was 30.0.2)
  • Timezone 2016j ( was 2016g )
@srl295 srl295 self-assigned this Dec 9, 2016
@srl295

Note: actual impact is smaller than what's here due to whitespace when it actually lands. I'll see if I can figure out how to reduce the whitespace churn here.

Guess i need to 'land' the PR on a branch with am … fix-whitespace .. and force push that branch back

@srl295 srl295 added a commit to srl295/node that referenced this pull request Dec 9, 2016
@srl295 srl295 deps: Bump ICU download path to 58.2
* update configure to new path

PR-URL: nodejs#10206
2e9240a
@srl295
Member
srl295 commented Dec 9, 2016 edited
@srl295 srl295 removed the in progress label Dec 10, 2016
@Fishrock123 Fishrock123 reopened this Dec 12, 2016
@Fishrock123
Member

Sorry about that.

@srl295 should this be backported to LTS?

@mhdawson
Contributor

Removing the whitespace changes would make it a lot easier to review.

@srl295 srl295 added a commit to srl295/node that referenced this pull request Dec 14, 2016
@srl295 srl295 deps: Bump ICU download path to 58.2
* update configure to new path

PR-URL: nodejs#10206
5c79e43
srl295 added some commits Dec 9, 2016
@srl295 srl295 deps: ICU 58.2 bump
No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )
cf8ab08
@srl295 srl295 deps: Bump ICU download path to 58.2
* update configure to new path

PR-URL: nodejs#10206
5366488
@srl295
Member
srl295 commented Dec 14, 2016 edited

@Fishrock123 yes, i think it should be backported
@mhdawson try it now - should be a lot easier to review.

I used curl -L https://github.com/nodejs/node/pull/10206.patch | git am --whitespace=fix to "land" it on a new branch, the pushed that back. Is there an easier way to do this? If I can integrate it into the "howto upgrade ICU docs", we can make this the same way for the future.

@mhdawson

LGTM

@gibfahn
Member
gibfahn commented Dec 23, 2016

@mhdawson To review without the whitespace changes you can just add ?w=1 to the end of the URL.

@srl295 I think fixing the whitespace issues is the right way to go, if people find it messy they can use the ?w=1 trick. Obviously hopefully once the issues have been fixed once then it won't continue to be a problem.

@srl295
Member
srl295 commented Dec 23, 2016
@srl295
Member
srl295 commented Dec 29, 2016

landed in 68f004f and c830179

@srl295 srl295 closed this Dec 29, 2016
@srl295 srl295 deleted the srl295:icu4c-58.2 branch Dec 29, 2016
@srl295 srl295 added a commit that referenced this pull request Dec 29, 2016
@srl295 srl295 deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
68f004f
@srl295 srl295 added a commit that referenced this pull request Dec 29, 2016
@srl295 srl295 deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
c830179
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@srl295 @joyeecheung srl295 + joyeecheung deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
82ad070
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@srl295 @joyeecheung srl295 + joyeecheung deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
41ae792
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
3b7dbea
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
831873e
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
616fd7a
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
96158f9
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bce0013
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@srl295 @evanlucas srl295 + evanlucas deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
785975d
@srl295 srl295 referenced this pull request Jan 16, 2017
Closed

Icu4c 58 #9234

4 of 4 tasks complete
@srl295 srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
@srl295 srl295 deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
1e8afd5
@srl295 srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
@srl295 srl295 deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
9305379
@srl295 srl295 referenced this pull request Jan 19, 2017
Closed

deps: v6.x backport of #9234/#10206 bump ICU to 58.2 🍒 #10887

1 of 2 tasks complete
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 20, 2017
@srl295 @MylesBorins srl295 + MylesBorins deps: ICU 58.2 bump
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
3462658
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 20, 2017
@srl295 @MylesBorins srl295 + MylesBorins deps: ICU 58.2 bump download URL
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
d51c637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment