inspector: fix Coverity defects #10240

Merged
merged 0 commits into from Dec 14, 2016

Projects

None yet

7 participants

@eugeneo
Contributor
eugeneo commented Dec 12, 2016
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Inspector: just minor fixes to address Coverity comments

Description of change

One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

@eugeneo eugeneo requested a review from ofrobots Dec 12, 2016
@eugeneo eugeneo closed this Dec 14, 2016
@eugeneo eugeneo deleted the eugeneo:coverty-sserver branch Dec 14, 2016
@eugeneo
Contributor
eugeneo commented Dec 14, 2016

Landed as 3c29b2f

@eugeneo eugeneo merged commit 3c29b2f into nodejs:master Dec 14, 2016
@MylesBorins
Member

@Fishrock123 not sure how the bot came up with these labels... this one definitely does not land cleanly on any branch

@MylesBorins
Member

@eugeneo this does not land cleanly on v7.x-staging

It appears there are some paths on master that don't exist on v7.x

* Unmerged path src/inspector_socket_server.cc
* Unmerged path test/cctest/test_inspector_socket_server.cc
@AnnaMag AnnaMag added a commit to AnnaMag/node that referenced this pull request Dec 18, 2016
@eugeneo @AnnaMag eugeneo + AnnaMag inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

PR-URL: nodejs#10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
caec3f3
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@eugeneo @joyeecheung eugeneo + joyeecheung inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

PR-URL: nodejs#10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
52dc0c6
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@eugeneo @evanlucas eugeneo + evanlucas inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

PR-URL: #10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
bbbabe4
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@eugeneo @evanlucas eugeneo + evanlucas inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

PR-URL: #10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
f1a1789
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@eugeneo @evanlucas eugeneo + evanlucas inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.

PR-URL: #10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
4bed947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment