repl: allow autocompletion for scoped packages #10296

Closed
wants to merge 1 commit into
from

Projects

None yet

8 participants

@evanlucas
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

Previously, autocompletion of scoped packages was not supported by the
repl due to not including the @ character in the regular expression.

test/parallel/test-repl-tab-complete.js
+ });
+ if (!files.length) common.rimrafSync(node_modules);
+ }));
+}
@bnoordhuis
bnoordhuis Dec 16, 2016 Member

Creating files or directories outside of common.tmpDir is kind of yuck. I think it should be possible to process.chdir(common.fixturesDir), then you can check in @nodejsscope/ into the existing node_modules directory.

@evanlucas
evanlucas Dec 16, 2016 Member

100% agree. I'll try and get that working. That should simplify a lot of this test. Thanks!

@bnoordhuis

LGTM with a comment.

test/common.js
@@ -60,6 +60,7 @@ function rimrafSync(p) {
rmdirSync(p, e);
}
}
+exports.rimrafSync = rimrafSync;
@bnoordhuis
bnoordhuis Dec 16, 2016 Member

You can drop this change now.

@evanlucas evanlucas repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.
d04b6ff
@jasnell jasnell added a commit that referenced this pull request Dec 23, 2016
@evanlucas @jasnell evanlucas + jasnell repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: #10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
e248f7f
@jasnell
Member
jasnell commented Dec 23, 2016

Landed in e248f7f

@jasnell jasnell closed this Dec 23, 2016
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@evanlucas @joyeecheung evanlucas + joyeecheung repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: nodejs#10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
7ab9900
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@evanlucas evanlucas repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: #10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
2e4264f
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@evanlucas evanlucas repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: #10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
a402652
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@evanlucas evanlucas repl: allow autocompletion for scoped packages
Previously, autocompletion of scoped packages was not supported by the
repl due to not including the `@` character in the regular expression.

PR-URL: #10296
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
6796bf4
@evanlucas evanlucas deleted the evanlucas:replscope branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment