benchmark: use commas in non-csv rate output #10360

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@mscdex
Contributor
mscdex commented Dec 20, 2016
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • benchmark
Description of change

This just adds commas as separators in the (non-csv) rate output to make it easier to read when dealing with larger numbers.

/cc @nodejs/benchmarking ?

@mscdex mscdex benchmark: use commas in non-csv rate output d62f2c8
@mscdex mscdex added the benchmark label Dec 20, 2016
@gareth-ellis

LGTM

@jasnell jasnell added a commit that referenced this pull request Dec 24, 2016
@mscdex @jasnell mscdex + jasnell benchmark: use commas in non-csv rate output
PR-URL: #10360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
17eb8fc
@jasnell
Member
jasnell commented Dec 24, 2016

Landed in 17eb8fc

@jasnell jasnell closed this Dec 24, 2016
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@mscdex @joyeecheung mscdex + joyeecheung benchmark: use commas in non-csv rate output
PR-URL: nodejs#10360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
7816d72
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@mscdex @evanlucas mscdex + evanlucas benchmark: use commas in non-csv rate output
PR-URL: #10360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
55cceb5
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@mscdex @evanlucas mscdex + evanlucas benchmark: use commas in non-csv rate output
PR-URL: #10360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
a582205
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@mscdex @evanlucas mscdex + evanlucas benchmark: use commas in non-csv rate output
PR-URL: #10360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
10b3297
@mscdex mscdex deleted the mscdex:benchmark-rate-commas branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment