Join GitHub today
async_wrap: close the destroy_ids_idle_handle_ on environment destruction #10385
Affected core subsystem(s)
Description of change
This is currently no issue for the "main" uv loop used by node. However if an embedder creates his own environment this will most likely lead to crashes. By looking at the code in
The additional delayed cleanup queue may be an overkill since it only contains one handle right now, but it seemed to me that it would be the most generic and verbose approach.
changed the title from
[async_wrap] close the destroy_ids_idle_handle_ on environment destruction
async_wrap: close the destroy_ids_idle_handle_ on environment destruction
Dec 21, 2016
A rule of thumb I use is "don't generalize until there are at least two or three instances." In this particular case, I'd just close the idle handle last in the destructor.
Aside: am I to infer SAP uses node in their products? It sure is a step up from ABAP. :-)
(I spent most of 2004 writing ABAP. I don't hate it, actually.)