src: describe what NODE_MODULE_VERSION is for #10414

Closed
wants to merge 1 commit into
from
@sam-github
Member

Current comment described what to do with it when the ABI changes, but
implied that node would load modules with newere ABI numbers, which it
will not.

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change
@addaleax addaleax added the lib / src label Dec 22, 2016
@addaleax

LGTM but there’s a commit message typo (newere)

@sam-github sam-github src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that node would load modules with newer ABI numbers, which it
will not.
2f5b9a4
@sam-github
Member

Typo fixed, thanks.

@Trott Trott referenced this pull request Dec 23, 2016
Closed

doc,src: clarify doc/comment about ABI number #10419

3 of 3 tasks complete
@Trott
Member
Trott commented Dec 23, 2016

We're standardizing on ABI number instead of ABI version or some other formulation? I'm OK with whatever, but I want to make sure we pick one thing and stick with it everywhere. (I've changed an instance of ABI version to ABI number in #10419. There is an additional one in releases.md.)

@Trott

Do we need to change the comment below that now repeats a fair bit of this new comment?

@sam-github
Member

We're standardizing on ABI number instead of ABI version or some other formulation?

I didn't intend to imply that, I just called it a number because it is, I'll change it back to be "version" in #10149

I really regret that modules got added to process.versions, but that's water under the bridge.

@thefourtheye

Wouldn't ABI version be better, instead of ABI number?

@jasnell jasnell added a commit that referenced this pull request Dec 27, 2016
@sam-github @jasnell sam-github + jasnell src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1257546
@jasnell
Member
jasnell commented Dec 27, 2016

Landed in 1257546

@jasnell jasnell closed this Dec 27, 2016
@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@sam-github @joyeecheung sam-github + joyeecheung src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: nodejs#10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
381ac32
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@sam-github @evanlucas sam-github + evanlucas src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
b1b3f94
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@sam-github @evanlucas sam-github + evanlucas src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
fac9c4d
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@sam-github @evanlucas sam-github + evanlucas src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
11ed800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment