Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve code in test-vm-symbols #10429

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@edsadr
Copy link
Member

edsadr commented Dec 23, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use const instead of var
  • use assert.strictEqual instead of assert.equal
test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal
@lpinca

lpinca approved these changes Dec 24, 2016

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Dec 26, 2016

Landed in 7c0d5d5.

@lpinca lpinca closed this Dec 26, 2016

lpinca added a commit that referenced this pull request Dec 26, 2016

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@evanlucas evanlucas referenced this pull request Jan 3, 2017

Merged

v7.4.0 release proposal #10589

evanlucas added a commit that referenced this pull request Jan 3, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

evanlucas added a commit that referenced this pull request Jan 4, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 23, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 23, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 24, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 24, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced Jan 24, 2017

MylesBorins added a commit that referenced this pull request Jan 31, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 1, 2017

test: improve code in test-vm-symbols
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: #10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.