Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage of Buffer.transcode #10437

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Dec 24, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, buffer

Description of change

Adds test for transcoding an empty buffer.

test: increase coverage of Buffer.transcode
Adds test for transcoding an empty buffer.
@Trott
Trott approved these changes Dec 24, 2016
Copy link
Member

left a comment

LGTM if CI is green.

@Trott

This comment has been minimized.

@evanlucas
Copy link
Member

left a comment

LGTM Thanks!

@targos
targos approved these changes Dec 24, 2016
jasnell added a commit that referenced this pull request Dec 24, 2016
test: increase coverage of Buffer.transcode
Adds test for transcoding an empty buffer.

PR-URL: #10437
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Dec 24, 2016

Landed in 904b66d

@jasnell jasnell closed this Dec 24, 2016

@joyeecheung joyeecheung deleted the joyeecheung:test-empty-transcode branch Jan 2, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: increase coverage of Buffer.transcode
Adds test for transcoding an empty buffer.

PR-URL: nodejs#10437
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.