New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix space for module version mismatch error #10606

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@Kerumen
Contributor

Kerumen commented Jan 4, 2017

The Native Module version mismatch error was missing a space at the end, between or and npm install:

screen shot 2017-01-04 at 14 36 59

Checklist
  • make -j4 test (UNIX)
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Yann Pringault
@targos

targos approved these changes Jan 4, 2017

@cjihrig

cjihrig approved these changes Jan 4, 2017

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes Jan 4, 2017

@Kerumen

This comment has been minimized.

Show comment
Hide comment
@Kerumen

Kerumen Jan 4, 2017

Contributor

Why is this labeled semver-major?

Contributor

Kerumen commented Jan 4, 2017

Why is this labeled semver-major?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jan 4, 2017

Contributor

All changes to error messages are considered semver major.

Contributor

cjihrig commented Jan 4, 2017

All changes to error messages are considered semver major.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 4, 2017

Member

Can this also update test/addons/node-module-version/test.js to check that part of the error message? Currently, it has a regex that stops before the last sentence.

Member

Trott commented Jan 4, 2017

Can this also update test/addons/node-module-version/test.js to check that part of the error message? Currently, it has a regex that stops before the last sentence.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jan 4, 2017

Contributor

I was going to PR this after this one landed. Here is the test update commit: cjihrig@8283bfa

Contributor

cjihrig commented Jan 4, 2017

I was going to PR this after this one landed. Here is the test update commit: cjihrig@8283bfa

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 4, 2017

Member

(@Kerumen By the way, if you don't want to update the test--if you were hoping to just add a space and move on--I can fix up the test. But if you're up for it, go for it.)

Member

Trott commented Jan 4, 2017

(@Kerumen By the way, if you don't want to update the test--if you were hoping to just add a space and move on--I can fix up the test. But if you're up for it, go for it.)

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 4, 2017

Member

Oh, never mind, @cjihrig has it covered. Sorry everyone.

Member

Trott commented Jan 4, 2017

Oh, never mind, @cjihrig has it covered. Sorry everyone.

@Trott

Trott approved these changes Jan 4, 2017

LGTM

@Kerumen

This comment has been minimized.

Show comment
Hide comment
@Kerumen

Kerumen Jan 4, 2017

Contributor

@Trott I could totally do it. Didn't know it was needed.

Contributor

Kerumen commented Jan 4, 2017

@Trott I could totally do it. Didn't know it was needed.

@mhdawson

LGTM

@cjihrig cjihrig referenced this pull request Jan 5, 2017

Merged

test: improve module version mismatch error check #10636

2 of 2 tasks complete
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jan 5, 2017

Contributor

One test failed in the CI, but it was unrelated. This is good to land at 9AM Eastern tomorrow.

Contributor

cjihrig commented Jan 5, 2017

One test failed in the CI, but it was unrelated. This is good to land at 9AM Eastern tomorrow.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jan 6, 2017

Contributor

Landed in 334be0f. Thanks!

Contributor

cjihrig commented Jan 6, 2017

Landed in 334be0f. Thanks!

@cjihrig cjihrig closed this Jan 6, 2017

cjihrig added a commit that referenced this pull request Jan 6, 2017

src: fix space for module version mismatch error
PR-URL: #10606
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@Kerumen Kerumen deleted the Kerumen:fix_node_module_version_message branch Jan 6, 2017

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Jan 9, 2017

test: improve module version mismatch error check
Refs: nodejs#10606
PR-URL: nodejs#10636
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017

src: fix space for module version mismatch error
PR-URL: nodejs#10606
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017

test: improve module version mismatch error check
Refs: nodejs#10606
PR-URL: nodejs#10636
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment