doc: add basic documentation for WHATWG URL API #10620

Closed
wants to merge 2 commits into
from
@jasnell
Member
jasnell commented Jan 4, 2017

Add documentation for the WHATWG URL API

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc,url

doc/api/url.md
@@ -250,7 +250,308 @@ properties of URL objects:
For example, the ASCII space character (`' '`) is encoded as `%20`. The ASCII
forward slash (`/`) character is encoded as `%3C`.
+## The WHATWG URL API
+
+The `url` module provides an experimental implementation of the
@sam-github
sam-github Jan 4, 2017 Member

define experimental, perhaps by including another > Stability: ... stanza here.

doc/api/url.md
+console.log(myURL.href);
+ // Prints http://example.org/foo
+
+myURL.href = 'https://example.com/bar'
@sam-github
sam-github Jan 4, 2017 Member

What does this actually do? Does it cause all the other properties to be re-evaluated as if the myURL had been constructuted from this new URL string?

doc/api/url.md
+
+#### url.origin
+
+Gets the read-only Unicode serialization of the URL's origin.
@sam-github
sam-github Jan 4, 2017 Member

Why is it so specific about Unicode seialization here, and not in the other string properties? This one is different?

@joyeecheung
joyeecheung Jan 5, 2017 Contributor

That one is specificly pointed out in the spec https://url.spec.whatwg.org/#dom-url-origin

The origin attribute’s getter must return the Unicode serialization of context object’s url’s origin. [HTML]

It returns the Unicode rather than the ASCII serialization for compatibility with HTML’s MessageEvent feature. [HTML]

doc/api/url.md
+```js
+const myURL = new URL('http://example.org/foo/bar?baz');
+console.log(myURL.origin);
+ // Prints http://exmaple.org
@sam-github
sam-github Jan 4, 2017 Member

"example"

doc/api/url.md
+
+#### url.port
+
+Gets and sets the port portion of the URL.
@sam-github
sam-github Jan 4, 2017 Member

if delete url.port, does it become "http://example.org"?

@targos
targos Jan 5, 2017 Member

It has no effect.

@targos
targos Jan 5, 2017 Member

To be more precise: it has no effect in sloppy mode and throws in strict mode. I think it deserves a note somewhere that to remove writable properties, one must set an empty value.

@jasnell
jasnell Jan 5, 2017 edited Member

hmm.. it does not appear to throw in strict mode... always appears to return true but have no effect.

'use strict';
const URL = require('url').URL;
const u = new URL('http://example.org:123/abc');
console.log(delete u.port);
console.log(u.href);
@TimothyGu
TimothyGu Jan 5, 2017 Member

That's because port is not a property on u, but rather u.[[Prototype]] (i.e. URL.prototype), so delete u.port will not affect the object.

However, since URL.prototype.port is configurable, you can actually delete URL.prototype.port in both strict and sloppy modes.

@targos
targos Jan 5, 2017 Member

I see. Sorry for the misunderstanding

doc/api/url.md
+
+#### url.protocol
+
+Gets and sets the protocol portion of the URL.
@sam-github
sam-github Jan 4, 2017 Member

what if you delete it? actually, for all the properties, what happens if they are deleted?

also, what happens if you assign an invalid value? does it throw, like it does in construction?

@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Could add a hint about all the attributes of properties https://heycam.github.io/webidl/#es-attributes at the top or somewhere (all enumerable: true and configurable: false for URL properties, writable depends on read-only-ness).

@jasnell
jasnell Jan 5, 2017 Member

Potentially but we do not typically go into that level of detail for most Node.js properties and the original spec is already pretty well defined.

doc/api/url.md
+
+#### url.search
+
+Gets and sets the serialized querystring portion of the URL.
@sam-github
sam-github Jan 4, 2017 Member

serialized, as opposed to ...?

@jasnell
jasnell Jan 4, 2017 Member

As opposed to searchParams

doc/api/url.md
+#### url.searchParams
+
+Gets a `URLSearchParams` object representing the querystring parameters of the
+URL.
@sam-github
sam-github Jan 4, 2017 Member

should that be linked to the def'n of URLSearchParams?

doc/api/url.md
+exported by the object, they are not considered to be part of the "public"
+API of the object.
+
+*Note*: The origin object and the `require('url').originFor()` API are not part
@sam-github
sam-github Jan 4, 2017 Member

Why are they here, then, are they going to be deprecated and removed?

@sam-github
sam-github Jan 4, 2017 Member

same question for the APIs below

@jasnell
jasnell Jan 4, 2017 Member

No, these are added as part of the new experimental implementation. They are just not part of the standard

@mscdex mscdex removed the lts-watch-v6.x label Jan 5, 2017
@jasnell
Member
jasnell commented Jan 5, 2017

Updated to address nits

doc/api/url.md
+ // Prints http://example.org/foo#baz
+```
+
+Using the `delete` keyword (e.g. `delete myURL.hash`) has no effect.
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

The delete statement would return true even though it has no effect. Could use a hint?

doc/api/url.md
+
+Using the `delete` keyword (e.g. `delete myURL.hash`) has no effect.
+
+Invalid URL characters included in the value assigned to the `hash` property
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Maybe worth pointing out that the additional escaped characters in url.parse (e.g. ") are no longer escaped (not necessarily here because that's common to a lot of properties).

doc/api/url.md
+ // Prints http://example.org/foo
+
+myURL.href = 'https://example.com/bar'
+ // Prints https://example.com/bar
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Might be worth adding

myURL.href = 'http://你好你好';
// Prints http://xn--6qqa088eba/
// Notice the slash added at the end and the ASCII serialization
doc/api/url.md
+```js
+const myURL = new URL('http://example.org/foo/bar?baz');
+console.log(myURL.origin);
+ // Prints http://example.org
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Might be worth adding

const idnURL = new URL('http://你好你好');
console.log(idnURL.origin);
// Prints http://你好你好
doc/api/url.md
+
+```js
+const myURL = new URL('http://example.org:8888');
+console.log(myURL.port);
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Worth pointing out it returns a string, not a number. Also setting it to the protocol's default port would result in a '' returned, that's different from what url.parse would do.

doc/api/url.md
+
+Using the `delete` keyword (e.g. `delete myURL.port`) has no effect.
+
+Invalid URL port values assigned to the `port` property are ignored.
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Valid range is [0, 65535].

doc/api/url.md
+```js
+const myURL = new URL('http://example.org/abc?123');
+console.log(myURL.search);
+ // Prints 123
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Has a question mark at the beginning, ?123

doc/api/url.md
+
+#### url.toString([unicode])
+
+* `unicode` {Boolean} `true` to serialize Unicode characters in the URL
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Could use a tip about it returning the same result as #href

@joyeecheung
Contributor

Overall I think we should document the behaviors different from url.parse for people who want to migrate to this new API. That doesn't have to happen all at once in this PR though.

@jasnell
Member
jasnell commented Jan 5, 2017

@joyeecheung ... definitely think that would be helpful but perhaps a guide would be better for that? In the meantime, I've address some of your comments! PTAL!

+
+```js
+const myURL = new URL('/foo', 'https://example.org/');
+ // https://example.org/foo
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Any reason this comment is indented (and others below)?

@jasnell
jasnell Jan 5, 2017 Member

Just a style I generally prefer (and have used in other docs that show the expected output

doc/api/url.md
+
+#### url.port
+
+Gets and sets the port portion of the URL as a String.
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Gets as a string, sets as either a string or a number.

doc/api/url.md
+Each item of the iterator is a JavaScript Array. The first item of the Array
+is the `name`, the second item of the Array is the `value`.
+
+### require('url').originFor(url)
@joyeecheung
joyeecheung Jan 5, 2017 Contributor

Not very sure about these, if they are not part of the public API, maybe we should avoid documenting them?

@jasnell
jasnell Jan 5, 2017 Member

They are not part of the WHATWG specification. They will be part of the Node.js API, however.

@joyeecheung
Contributor

@jasnell Yeah a guide would definitely be more suitable for this. I've submitted another review, if resolved then LGTM.

@jasnell
Member
jasnell commented Jan 5, 2017

I've added some specific details about the pct-encoding in the new implementation

doc/api/url.md
+Remove any existing name-value pairs whose name is `name` and append a new
+name-value pair.
+
+#### urlSearchParams[Symbol.iterator]()
@TimothyGu
TimothyGu Jan 5, 2017 Member

Perhaps the @@iterator notation used in ES spec would be more concise? Or is this notation already used in the documentation?

@jasnell
jasnell Jan 5, 2017 Member

I don't believe there is much (or any) precedence for documenting @@iterator in our current docs given that few (if any) of our core APIs make use of it.

doc/api/url.md
+
+Returns an ES6 Iterator over each of the name-value pairs in the query string.
+Each item of the iterator is a JavaScript Array. The first item of the Array
+is the `name`, the second item of the Array is the `value`.
@TimothyGu
TimothyGu Jan 5, 2017 Member

There are also keys, values, and entries functions.

doc/api/url.md
+
+* `name` {String}
+* `value` {String}
+* Returns `undefined`
@TimothyGu
TimothyGu Jan 5, 2017 Member

I don't think "Returns undefined" needs to be explicitly stated…

doc/api/url.md
+#### urlSearchParams.get(name)
+
+* `name` {String}
+* Returns a string or `undefined`
@TimothyGu
TimothyGu Jan 5, 2017 Member

Actually, it returns null when the param cannot be found.

doc/api/url.md
+#### urlSearchParams.getAll(name)
+
+* `name` {String}
+* Returns a JavaScript Array
@TimothyGu
TimothyGu Jan 5, 2017 edited Member

Other places of the documentation seem to prefer

* Returns: {Array}
doc/api/url.md
+
+#### urlSearchParams.entries()
+
+* Returns: ES6 Iterator
@TimothyGu
TimothyGu Jan 5, 2017 Member

While at it, why don't you add an MDN link for the Iterator type to tools/doc/type-parser.js ? Then, you will be able to use {Iterator} with automatic linking.

@jasnell
jasnell Jan 5, 2017 Member

Yeah, good idea

doc/api/url.md
+
+Returns an ES6 Iterator over each of the name-value pairs in the query string.
+Each item of the iterator is a JavaScript Array. The first item of the Array
+is the `name`, the second item of the Array is the `value`.
@TimothyGu
TimothyGu Jan 5, 2017 Member

I'd explicitly mention that by definition, urlSearchParams[@@iterator] === urlSearchParams.entries. You can completely replace this description with the aliasing information (which has the benefit of not going out of sync), or make that info an additional paragraph – either is fine with me.

@jasnell
Member
jasnell commented Jan 5, 2017

@TimothyGu ... updated! PTAL!

@Fishrock123
Fishrock123 requested changes Jan 5, 2017 edited View changes

I don't think officially documenting experimental APIs is a good idea? Wasn't there a conversation about avoiding this?

@mscdex mscdex removed the url label Jan 5, 2017
@targos
Member
targos commented Jan 5, 2017

@Fishrock123 I think the stability level 1 (experimental) is here especially so that we can document experimental APIs.

@jasnell
Member
jasnell commented Jan 5, 2017

That and this cannot move out of experimental without documentation.

@TimothyGu

Other than these nits, I think this PR is good to go.

doc/api/url.md
+
+#### url.searchParams
+
+Gets a [`URLSearchParams`][#url_class_urlsearchparams] object representing the
@TimothyGu
TimothyGu Jan 5, 2017 Member

How about "Gets the URLSearchParams object…"

This IMO makes it clearer that the same object will be returned (c.f. the IDL [SameObject] attr).

doc/api/url.md
+#### url.toString([unicode])
+
+* `unicode` {Boolean} If `true`, Unicode characters within the hostname will
+ be encoded as-is without [punycode][] encoding. Defaults to `false`.
@TimothyGu
TimothyGu Jan 5, 2017 Member

Punycode (capitalization)

doc/api/url.md
+#### urlSearchParams.has(name)
+
+* `name` {String}
+* Returns: `true` or `false`
@TimothyGu
TimothyGu Jan 5, 2017 Member

Returns: {Boolean}

doc/api/url.md
+Returns an object representing the origin of the given URL. The origin object
+is considered to be opaque. That is, while there are properties and methods
+exported by the object, they are not considered to be part of the "public"
+API of the object.
@TimothyGu
TimothyGu Jan 5, 2017 Member

This is not a comment about this PR specifically, but what is the use of this returned object for any Node.js user, if the structure of the returned object is not part of the public API?

@targos
targos approved these changes Jan 5, 2017 View changes
doc/api/url.md
+
+console.log(myURL.href); // "https://example.org/foo"
+console.log(myURL.protocol); // "https:"
+console.log(myURL.hostname); // "/example.org"
@targos
targos Jan 5, 2017 Member

no slash

doc/api/url.md
+
+#### url.searchParams
+
+Gets a [`URLSearchParams`][#url_class_urlsearchparams] object representing the
@targos
targos Jan 5, 2017 Member

parentheses instead of brackets around #url_class_urlsearchparams

doc/api/url.md
+
+Returns an ES6 Iterator over the values of each name-value pair.
+
+#### urlSearchParams[@@iterator]()
@targos
targos Jan 5, 2017 Member

this is rendered as a link on GitHub:
image

doc/api/url.md
+Returns an object representing the origin of the given URL. The origin object
+is considered to be opaque. That is, while there are properties and methods
+exported by the object, they are not considered to be part of the "public"
+API of the object.
@targos
targos Jan 5, 2017 Member

What is the public purpose of this object then?

@jasnell
jasnell Jan 5, 2017 Member

Still thinking through the utility of exposing the originFor method...

doc/api/url.md
+and which characters to encode depends entirely on where the character is
+located within the structure of the URL. The WHATWG URL Standard uses a more
+selective and fine grained approach to selecting encoded characters than that
+used by the older [`url.parse()][] and [`url.format()`][] methods.
@targos
targos Jan 5, 2017 Member

missing backtick after url.parse()

@jasnell
Member
jasnell commented Jan 5, 2017

Updated to address nits!

@jasnell
Member
jasnell commented Jan 6, 2017

@sam-github @Fishrock123 ... PTAL and let me know if I have addressed your concerns.

@domenic

Really impressive stuff; I would recommend this even to non-Node.js users of the URL API.

+#### Constructor: new URL(input[, base])
+
+* `input` {String} The input URL to parse
+* `base` {String | URL} The base URL to resolve against if the `input` is not
@domenic
domenic Jan 12, 2017 Member

I'm not sure how this fits with Node documentation conventions but technically what this does (or should do at least) is convert any input to a string. And the URL class has a toString() method, so things work well. But you could also pass e.g. Url instances or { toString() { return "https://example.com/"; } } and it should work.

@jasnell
jasnell Jan 12, 2017 Member

yeah, this part of the implementation should be improved. Note that Url instances as produced by url.parse() do not have a toString() option. I guess, however, that we could fake it by running it through the older url.format() if the input is an Object (that is not a URL). Will think about this a bit more

@jasnell
jasnell Jan 12, 2017 Member

Ok, just verified, the code is doing the right thing here for anything that can reasonably be coerced into a string via toString. Passing Url instances as produced by url.parse() does not work because those do not implement a toString().

doc/api/url.md
+const myURL = new URL('http://你好你好');
+ // http://xn--6qqa088eba
+```
+
@domenic
domenic Jan 12, 2017 Member

It might also be helpful to reference https://url.spec.whatwg.org/#example-url-parsing to show the full breadth of the normalization that parsing causes.

doc/api/url.md
+```
+
+Using the `delete` keyword (e.g. `delete myURL.hash`) has no effect but will
+still return `true`.
@domenic
domenic Jan 12, 2017 Member

This seems kind of random but maybe the idea is to counter peoples' expectations from Url? Regardless it's rather repetitive; maybe move it up to a prelude? Apologies if this was covered in previous collapsed reviews. Not a big deal.

@jasnell
jasnell Jan 12, 2017 Member

This was added in response to a question in the thread above. I can consolidate it down to a single comment in a prelude as suggested. Personally tho, I'd be happier to not include this at all.

doc/api/url.md
+Gets and sets the host portion of the URL.
+
+```js
+const myURL = new URL('http://example.org:81/foo');
@domenic
domenic Jan 12, 2017 Member

IMO s/http:/https:/g ^_^

doc/api/url.md
+```
+
+Setting the value of the `href` property to a new value is equivalent to
+creating a new `URL` object using `new URL(value)`. Each of the `URL` objects
@domenic
domenic Jan 12, 2017 Member

s/objects/object's/

doc/api/url.md
+ be encoded as-is without [Punycode][] encoding. Defaults to `false`.
+
+The `toString()` method on the `URL` object returns the serialized URL. When
+`unicode` is `false`, the value returned is equivalent to that of `url.href`.
@domenic
domenic Jan 12, 2017 Member

the [unicode] extension appears nonstandard. It should be removed, or at least not documented?

doc/api/url.md
+Each item of the iterator is a JavaScript Array. The first item of the Array
+is the `name`, the second item of the Array is the `value`.
+
+Alias for `urlSearchParams\[\@\@iterator\]()`.
@domenic
domenic Jan 12, 2017 Member

Maybe Symbol.iterator is clearer to devs than @@iterator

@jasnell
jasnell Jan 12, 2017 Member

heh.. earlier comment suggested the opposite ;-)

@jasnell
Member
jasnell commented Jan 12, 2017

@domenic ... updated to address your feedback!

doc/api/url.md
+#### url.toString()
+
+The `toString()` method on the `URL` object returns the serialized URL. When
+`unicode` is `false`, the value returned is equivalent to that of `url.href`.
@TimothyGu
TimothyGu Jan 12, 2017 Member

Now that the unicode parameter is not mentioned, this sentence should be revised as

The value returned is equivalent to that of url.href.

@jasnell
Member
jasnell commented Jan 12, 2017

ping @sam-github and @Fishrock123 ... I'd like to get this landed.

@TimothyGu

Sorry for noticing these things so late.

doc/api/url.md
+
+#### url.search
+
+Gets and sets the serialized querystring portion of the URL.
@TimothyGu
TimothyGu Jan 14, 2017 Member

s/querystring/query/

doc/api/url.md
+#### url.searchParams
+
+Gets a [`URLSearchParams`](#url_class_urlsearchparams) object representing the
+querystring parameters of the URL.
@TimothyGu
TimothyGu Jan 14, 2017 Member

s/querystring/query/

+The `toString()` method on the `URL` object returns the serialized URL. The
+value returned is equivalent to that of `url.href`.
+
+### Class: URLSearchParams
@TimothyGu
TimothyGu Jan 14, 2017 Member

toString and forEach don't seem to be documented.

doc/api/url.md
+
+### Class: URLSearchParams
+
+The `URLSearchParams` object provides read and write access to the querystring
@TimothyGu
TimothyGu Jan 14, 2017 Member

s/querystring/query parameters/

doc/api/url.md
+
+#### Constructor: new URLSearchParams([init])
+
+* `init` {String} The URL querystring
@TimothyGu
TimothyGu Jan 14, 2017 Member

s/querystring/query string/

doc/api/url.md
+Returns the [Punycode][] ASCII serialization of the `domain`.
+
+*Note*: The `require('url').domainToAscii()` method is introduced as part of
+the new `URL` implementation but is not part of the WHATWG URL specification.
@TimothyGu
TimothyGu Jan 14, 2017 Member

The doc for domainToUnicode function uses the word "standard," which is the wording the URL Standard uses as well.

@TimothyGu TimothyGu referenced this pull request Jan 14, 2017
Closed

url: export URLSearchParams #10801

2 of 2 tasks complete
@jasnell
Member
jasnell commented Jan 15, 2017

This should be updated to include the corrected URLSearchParam constructor also

@TimothyGu
Member

@jasnell, I wouldn't bother documenting URLSearchParams in this PR for now. After all, it is not yet exported, and what is currently in the PR is not wrong, simply incomplete.

@jasnell
Member
jasnell commented Jan 16, 2017

@TimothyGu .. updated, PTAL

doc/api/url.md
+```js
+const URL = require('url').URL;
+const myURL = new URL('https://example.org/?a=b&c=d');
+myURL.searchParams.forEach((name, value) => {
@TimothyGu
TimothyGu Jan 17, 2017 Member

It's actually (value, name). Yeah it's counterintuitive but its to keep up with Array and Map's behavior.

@jasnell
jasnell Jan 17, 2017 Member

oh right, yes, I'd forgotten about that little nuance. Thank you :-)

doc/api/url.md
+
+#### urlSearchParams.toString()
+
+Returns the search parameters serialized as a URL-encoded string.
@TimothyGu
TimothyGu Jan 17, 2017 Member
* Returns: {String}
@jasnell
Member
jasnell commented Jan 17, 2017

Updated!

@jasnell
Member
jasnell commented Jan 17, 2017

Will land this tomorrow if there are further objections or comments.

@joyeecheung
Contributor

This haven't moved for a while. Pinging @Fishrock123 , are you OK with landing this now?

@jasnell
Member
jasnell commented Jan 23, 2017

Yeah, I intentionally left it open just in case. I'm planning on landing it today.

@jasnell jasnell added a commit that referenced this pull request Jan 23, 2017
@jasnell jasnell tools: add mdn link for Iterator
PR-URL: #10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
0c712b6
@jasnell jasnell added a commit that referenced this pull request Jan 23, 2017
@jasnell jasnell doc: add basic documentation for WHATWG URL API
PR-URL: #10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
4757ddc
@jasnell
Member
jasnell commented Jan 23, 2017

Landed in 0c712b6 and 4757ddc

@jasnell jasnell closed this Jan 23, 2017
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@jasnell @italoacasas jasnell + italoacasas tools: add mdn link for Iterator
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
bac662a
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@jasnell @italoacasas jasnell + italoacasas doc: add basic documentation for WHATWG URL API
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
44d1431
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@jasnell @italoacasas jasnell + italoacasas tools: add mdn link for Iterator
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
73e45fd
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@jasnell @italoacasas jasnell + italoacasas doc: add basic documentation for WHATWG URL API
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
afe228f
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@jasnell @italoacasas jasnell + italoacasas tools: add mdn link for Iterator
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
c92b8ec
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@jasnell @italoacasas jasnell + italoacasas doc: add basic documentation for WHATWG URL API
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
84e2ff3
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@jasnell @italoacasas jasnell + italoacasas tools: add mdn link for Iterator
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
0c642ff
@italoacasas italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@jasnell @italoacasas jasnell + italoacasas doc: add basic documentation for WHATWG URL API
PR-URL: nodejs#10620
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
9a5efee
@evanlucas evanlucas added a commit that referenced this pull request Jan 31, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
42b4cee
@evanlucas evanlucas added a commit that referenced this pull request Jan 31, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
a34f1d6
@evanlucas evanlucas added a commit that referenced this pull request Feb 1, 2017
@evanlucas evanlucas 2017-01-31, Version 7.5.0 (Current)
Notable changes:

* crypto:
  * ability to select cert store at runtime (Adam Majer) #8334
  * Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
  * upgrade npm to 4.1.2 (Kat Marchán) #11020
  * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638

PR-URL: #11062
a1c91ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment