Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve module version mismatch error check #10636

Merged
merged 1 commit into from Jan 9, 2017

Conversation

@cjihrig
Copy link
Contributor

commented Jan 5, 2017

Refs: #10606

Don't run the CI yet. The test will fail until #10606 lands.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the addons label Jan 5, 2017

@jasnell
jasnell approved these changes Jan 5, 2017
test/addons/node-module-version/test.js Outdated
'was compiled against a different Node.js version using\n' +
'NODE_MODULE_VERSION 42. This version of Node.js requires\n' +
`NODE_MODULE_VERSION ${process.versions.modules}.`);
`^Error: The module '.+'\n` +

This comment has been minimized.

Copy link
@sam-github

sam-github Jan 5, 2017

Member

Most node Error: messages don't insert line breaks into the message output.

Consider removing the newlines, so that the message can wrap at the user's terminal boundary, or in the case of stderr being directed to a log aggregation service, the entire error will be one single line/log entry.

I would make each sentence a single line, or maybe the entire thing two lines, with the second line being "Please try...".

This comment has been minimized.

Copy link
@cjihrig

cjihrig Jan 5, 2017

Author Contributor

This PR is just improving the regular expression that matches the existing error message (which includes explicit line breaks). It's not changing the error message itself.

@Trott
Trott approved these changes Jan 6, 2017
Copy link
Member

left a comment

LGTM if CI is

@cjihrig cjihrig force-pushed the cjihrig:err-msg branch Jan 6, 2017

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2017

test: improve module version mismatch error check
Refs: #10606
PR-URL: #10636
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:err-msg branch to 775de9c Jan 9, 2017

@cjihrig cjihrig merged commit 775de9c into nodejs:master Jan 9, 2017

@cjihrig cjihrig deleted the cjihrig:err-msg branch Jan 9, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: improve module version mismatch error check
Refs: nodejs#10606
PR-URL: nodejs#10636
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

Since #10606 is a semver-major and these two commits need to be together, I'm adding do-not-land labels here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.