Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: note v5, v0.10, v0.12 EOL in the CHANGELOG #10743

Closed
wants to merge 3 commits into from

Conversation

@ChALkeR
Copy link
Member

commented Jan 11, 2017

The CHANGELOG page looks like this now:
spectacle zw3351

Seeing that, one might think that 0.12 and 0.10 are currently in the LTS.

So this commit makes it clear that v5, v0.10, and v0.12 are EOL and unsupported:
spectacle rx3351

We probably don't want people seeing LTS badge next to those in the current Node.js repo and think that those are still supported. Not everyone is aware of the nodejs/LTS repo.

This also includes the dates for v5, v0.10 and v0.12 EOL:

  • 2016-07-01 for v5
  • 2016-11-01 for v0.10
  • 2017-01-01 for v0.12
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

ChALkeR added 2 commits Jan 11, 2017
doc: fix CHANGELOG.md table formatting
It had some minor errors in td/th html tags.
doc: note v5, v0.10, v0.12 EOL in the CHANGELOG
Make it clear that v5, v0.10, and v0.12 are EOL and unsupported.

We probably don't want people seeing 'LTS' badge next to those
in the current Node.js repo and think that those are still supported.
Not everyone is aware of the nodejs/LTS repo.

This also includes the dates for v5, v0.10 and v0.12 EOL:
 - 2016-07-01 for v5
 - 2016-11-01 for v0.10
 - 2017-01-01 for v0.12
@richardlau

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

The same page also says:

  • Release versions displayed in bold text represent the most recent actively supported release.

Should 5.11.1, 0.12.18 and 0.10.48 still be in bold?

[squash] Make v5/v0.10/v0.12 not bold in CHANGELOG
Make v5, v0.10, v0.12 not bold in the CHANGELOG.md, as bold is said to
be an indication of the most recent actively supported release futher
on the same page.

@ChALkeR ChALkeR force-pushed the ChALkeR:changelog-fixes branch to 8812456 Jan 11, 2017

@ChALkeR

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2017

@richardlau Good point, thanks! Fixed.

spectacle ny3351

@mhdawson
Copy link
Member

left a comment

LGTM

jasnell added a commit that referenced this pull request Jan 16, 2017
doc: fix CHANGELOG.md table formatting
* It had some minor errors in td/th html tags.
* Make it clear that v5, v0.10, and v0.12 are EOL and unsupported.

We probably don't want people seeing 'LTS' badge next to those
in the current Node.js repo and think that those are still supported.
Not everyone is aware of the nodejs/LTS repo.

This also includes the dates for v5, v0.10 and v0.12 EOL:
 - 2016-07-01 for v5
 - 2016-11-01 for v0.10
 - 2017-01-01 for v0.12

* Make v5/v0.10/v0.12 not bold in CHANGELOG

Make v5, v0.10, v0.12 not bold in the CHANGELOG.md, as bold is said to
be an indication of the most recent actively supported release futher
on the same page.

PR-URL: #10743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 16, 2017

Squashed and landed in f3f2468

@jasnell jasnell closed this Jan 16, 2017

@ChALkeR

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2017

@jasnell Thanks! I somehow totally forgot about this… :-(

@evanlucas

This comment has been minimized.

Copy link
Member

commented Jan 31, 2017

This isn't landing cleanly on v7.x-staging. Mind backporting?

@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

@ChALkeR should this be backported to 6.x?

@ChALkeR

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2017

@gibfahn Yes, it looks like this should be backported, without the v7 line, though.

https://raw.githubusercontent.com/nodejs/node/v6.x/CHANGELOG.md has the same formatting errors (</sup</th>), and specificies 0.12 as being LTS.

I am not able to backport this at the moment, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.