test: add test cases to test-readline-keys.js #10772

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@hiroppy
Member

hiroppy commented Jan 12, 2017

Add test cases for all patterns of readline.js.
Make use of arrow function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott

This comment has been minimized.

Show comment
Hide comment
@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Jan 16, 2017

Member

@Trott Would you be able to confirm this PR?

Member

hiroppy commented Jan 16, 2017

@Trott Would you be able to confirm this PR?

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 17, 2017

Member

@nodejs/testing Anyone want to take a look at this one? This looks to me like it changes existing test cases (but not behavior) rather than merely adding new test cases. Are we OK with that?

Member

Trott commented Jan 17, 2017

@nodejs/testing Anyone want to take a look at this one? This looks to me like it changes existing test cases (but not behavior) rather than merely adding new test cases. Are we OK with that?

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Jan 18, 2017

Member

Looks like this just appends new keys to the same test case instead of putting them in a following one. I think it's probably safe.

Member

joyeecheung commented Jan 18, 2017

Looks like this just appends new keys to the same test case instead of putting them in a following one. I think it's probably safe.

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes Feb 3, 2017

jasnell added a commit that referenced this pull request Feb 8, 2017

test: add test cases to test-readline-keys.js
PR-URL: #10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 8, 2017

Member

Landed in 2db3b94

Member

jasnell commented Feb 8, 2017

Landed in 2db3b94

@jasnell jasnell closed this Feb 8, 2017

@hiroppy hiroppy deleted the hiroppy:feature/add-readline-keys-test branch Feb 9, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 9, 2017

test: add test cases to test-readline-keys.js
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: add test cases to test-readline-keys.js
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: add test cases to test-readline-keys.js
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

would need backport PRs to land in v6 or v4

Member

jasnell commented Mar 7, 2017

would need backport PRs to land in v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment