Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add msg validation to test-buffer-compare #10807

Closed
wants to merge 1 commit into from

Conversation

@joshholl
Copy link
Contributor

commented Jan 14, 2017

added message validation to assert.throws

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2017

@cjihrig
Copy link
Contributor

left a comment

LGTM. CI is green.

@thefourtheye
Copy link
Contributor

left a comment

LGTM if CI is happy.

@lpinca
lpinca approved these changes Jan 15, 2017
jasnell added a commit that referenced this pull request Jan 16, 2017
test: add msg validation to test-buffer-compare
PR-URL: #10807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 16, 2017

landed in 6af1090

@jasnell jasnell closed this Jan 16, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: add msg validation to test-buffer-compare
PR-URL: nodejs#10807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

since #10236 is a semver-major and this depends on that commit I'm adding dont-land-on-x labels.

@jasnell jasnell referenced this pull request Apr 4, 2017
gibfahn added a commit that referenced this pull request Jun 19, 2017
test: add msg validation to test-buffer-compare
PR-URL: #10807
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: add msg validation to test-buffer-compare
PR-URL: #10807
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: add msg validation to test-buffer-compare
PR-URL: #10807
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.