Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor fixups for changelogs #10827

Closed
wants to merge 3 commits into from

Conversation

@addaleax
Copy link
Member

commented Jan 15, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc/changelogs

@lpinca
lpinca approved these changes Jan 16, 2017
addaleax added 3 commits Jan 13, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.
doc: move Boron releases to LTS column
Move the LTS releases for Node 6 to the `LTS` column in the
corresponding `CHANGELOG_V6.md`.

@addaleax addaleax force-pushed the addaleax:changelog-fixes branch to e06e8d2 Jan 17, 2017

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2017

Landed in f57dabe...6d31bdb

@addaleax addaleax closed this Jan 18, 2017

@addaleax addaleax deleted the addaleax:changelog-fixes branch Jan 18, 2017

addaleax added a commit that referenced this pull request Jan 18, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: #10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 18, 2017
doc: fix markdown escaping in CHANGELOG_V7.md
PR-URL: #10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 18, 2017
doc: move Boron releases to LTS column
Move the LTS releases for Node 6 to the `LTS` column in the
corresponding `CHANGELOG_V6.md`.

PR-URL: #10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
doc: fix markdown escaping in CHANGELOG_V7.md
PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 23, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 23, 2017
doc: fix markdown escaping in CHANGELOG_V7.md
PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 24, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 24, 2017
doc: fix markdown escaping in CHANGELOG_V7.md
PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
doc: remove duplicate PR link from changelog
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
doc: fix markdown escaping in CHANGELOG_V7.md
PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas referenced this pull request Jan 29, 2017
@evanlucas

This comment has been minimized.

Copy link
Member

commented Jan 31, 2017

This isn't landing cleanly on v7.x. Mind submitting a backport PR?

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

ditto for v4 / v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.