Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "doc: correct vcbuild options for windows testing" #10839

Merged
merged 0 commits into from Jan 21, 2017

Conversation

@gibfahn
Copy link
Member

commented Jan 16, 2017

This reverts commit ed9b6c1.

Basically #10686 shouldn't have landed in master, it was superseded by #10156. I've reopened #10686.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

cc/ @MylesBorins @jasnell let me know if I'm doing this right, basically did a git revert ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.

@gibfahn gibfahn self-assigned this Jan 19, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 21, 2017

@gibfahn You self-assigned this … should we wait with landing this?

@gibfahn gibfahn closed this Jan 21, 2017

@gibfahn gibfahn force-pushed the gibfahn:revert-vcbuild-nosign branch to 93c4820 Jan 21, 2017

@gibfahn gibfahn merged commit 93c4820 into nodejs:master Jan 21, 2017

@gibfahn

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2017

Landed in 93c4820

@gibfahn gibfahn deleted the gibfahn:revert-vcbuild-nosign branch Jan 21, 2017

@gibfahn

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2017

@addaleax Thanks for reminding me! In general feel free to land stuff I've self-assigned, it's more to keep it on my list than anything else.

italoacasas added a commit to italoacasas/node that referenced this pull request Jan 25, 2017
Revert "doc: correct vcbuild options for windows testing"
This reverts commit ed9b6c1.

PR-URL: nodejs#10839
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 27, 2017
Revert "doc: correct vcbuild options for windows testing"
This reverts commit ed9b6c1.

PR-URL: nodejs#10839
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@italoacasas italoacasas referenced this pull request Jan 29, 2017
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.