New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve error messages in test-npm-install #11027

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
9 participants
@gonenduk
Member

gonenduk commented Jan 26, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott

Trott approved these changes Jan 26, 2017

LGTM if CI is green

@Trott

This comment has been minimized.

Show comment
Hide comment

@mscdex mscdex added npm and removed dont-land-on-v7.x labels Jan 26, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 27, 2017

Member

Looks like there was a weird Jenkins hiccup but everything is green.

Member

Trott commented Jan 27, 2017

Looks like there was a weird Jenkins hiccup but everything is green.

@lpinca

lpinca approved these changes Jan 27, 2017

@gonenduk

This comment has been minimized.

Show comment
Hide comment
@gonenduk

gonenduk Feb 1, 2017

Member

bump

Member

gonenduk commented Feb 1, 2017

bump

jasnell added a commit that referenced this pull request Feb 1, 2017

test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 1, 2017

Member

Landed in 6ca1bdf

Member

jasnell commented Feb 1, 2017

Landed in 6ca1bdf

@jasnell jasnell closed this Feb 1, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 1, 2017

Member

Thanks for the contribution! 🎉

Member

Trott commented Feb 1, 2017

Thanks for the contribution! 🎉

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 2, 2017

test: improve error messages in test-npm-install
PR-URL: nodejs#11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: improve error messages in test-npm-install
PR-URL: nodejs#11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: improve error messages in test-npm-install
PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment