Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
v7.x: backport update to V8 5.5 #11029
This is a backport of the update to V8 5.5 for v7.x.
Affected core subsystem(s)
Needs a rebase. Also, do any of the Collaborators giving this emoticon upvotes and positive comments feel comfortable enough approving it? 1500+ files changed. Personally, I wouldn't know where to begin to even spot-check this sort of thing before dropping in a rubber-stamp approval. Paging @nodejs/v8 for help.
Rebased the rebuild job and fingers crossed it should be working
Will dig into results tomorrow
edit: the above was just the job that forces a rebuild of native modules, below is a job that builds with v7.5.0 and then tests with the node built from this PR
citgm job of v7.5.0 for comparison
the rebuild job has some failures that are a bit concerning, the abi smoker has passed. Only failures are known flakes
citgm abi smoker with
NVM the above rebuild was accidentally run on master and everything breaking was due to module version mismatch.
citgm-abi-smoker with rebuild with 5.5: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-abi-smoker/31/
citgm-rebuild-smoker on v7.5.0 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-rebuild/4/
This was referenced
Feb 5, 2017
Rebased and squashed commits about ABI compatibility.
@MylesBorins What's the conclusion with the CITGM ABI smoker?
One more run of the ABI smoker. So far everything looked good except for a couple of odd failures on Ubuntu 1404. I have a beefy VM spun up and am going to test those ones manually