New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: align fork/spawn stdio error msg #11044

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@sam-github
Member

sam-github commented Jan 27, 2017

fork()'s support for .stdio strings in 3268863 used a different
TypeError string from spawn, unnecessarily.

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Jan 27, 2017

Member

@mscdex approved?

Do I need to wait 2 days, or can I revert once there are two approvals?

Member

sam-github commented Jan 27, 2017

@mscdex approved?

Do I need to wait 2 days, or can I revert once there are two approvals?

@cjihrig

LGTM. However, if @mscdex's request to change the error message was the only thing outstanding, couldn't it just be updated here?

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Jan 28, 2017

Contributor

If nobody else had any questions/suggestions about the original changes, then it would probably be easier to just change the error message here instead of revert + change.

Contributor

mscdex commented Jan 28, 2017

If nobody else had any questions/suggestions about the original changes, then it would probably be easier to just change the error message here instead of revert + change.

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Jan 28, 2017

Member

OK, I'll revise this PR to be an update of the error message. On monday, though. Cheers.

Member

sam-github commented Jan 28, 2017

OK, I'll revise this PR to be an update of the error message. On monday, though. Cheers.

@sam-github sam-github changed the title from Revert "child_process: add string shortcut for fork stdio" to child_process: align fork/spawn stdio error msg Jan 30, 2017

@sam-github sam-github dismissed stale reviews from jasnell and cjihrig Jan 30, 2017

replaced revert with code, PTAL

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Jan 30, 2017

Member

@mscdex I fixed the error message, PTAL, sorry I didn't understand what you LGTM was conditional on.

Member

sam-github commented Jan 30, 2017

@mscdex I fixed the error message, PTAL, sorry I didn't understand what you LGTM was conditional on.

Show outdated Hide outdated doc/api/child_process.md
@@ -299,6 +299,9 @@ output on this fd is expected to be line delimited JSON objects.
*Note: Unlike the fork(2) POSIX system call, `child_process.fork()` does
not clone the current process.*
*Note*: Support for non-Array values of the `.stdio` option was added in

This comment has been minimized.

@mscdex

mscdex Jan 30, 2017

Contributor

I don't know if we want to start adding this kind of information in this way or not. I think it's probably a separate discussion to be had outside of this PR?

@mscdex

mscdex Jan 30, 2017

Contributor

I don't know if we want to start adding this kind of information in this way or not. I think it's probably a separate discussion to be had outside of this PR?

This comment has been minimized.

@sam-github

sam-github Jan 30, 2017

Member

Don't we usually put something in the API docs when we make breaking API changes? I'll check around to see what we've done in the recent past.

@sam-github

sam-github Jan 30, 2017

Member

Don't we usually put something in the API docs when we make breaking API changes? I'll check around to see what we've done in the recent past.

This comment has been minimized.

@mscdex

mscdex Jan 30, 2017

Contributor

AFAIK we haven't been including version information when it comes to changes in behavior over time. That might be beneficial, but still it's a separate discussion on if we want to start doing that and if so, how something like that would be best conveyed to the end user (presumably not in a free-form way like this note).

@mscdex

mscdex Jan 30, 2017

Contributor

AFAIK we haven't been including version information when it comes to changes in behavior over time. That might be beneficial, but still it's a separate discussion on if we want to start doing that and if so, how something like that would be best conveyed to the end user (presumably not in a free-form way like this note).

Show outdated Hide outdated doc/api/child_process.md
@@ -299,6 +299,9 @@ output on this fd is expected to be line delimited JSON objects.
*Note: Unlike the fork(2) POSIX system call, `child_process.fork()` does
not clone the current process.*
*Note*: Support for non-Array values of the `.stdio` option was added in

This comment has been minimized.

@sam-github

sam-github Jan 30, 2017

Member

@addaleax (because you did the original YAML markup, I think) @MylesBorins Will this work?

Our 'ADDED' metadata is not granular enough. It tracks API additions, mostly, but it doesn't account for backporting though 00ffa33 gives me the impression it was intended to.

Since it doesn't track changes in APIs, will this note work? Will the FIXME (EDIT: <-- I meant REPLACEME) get processed?

@sam-github

sam-github Jan 30, 2017

Member

@addaleax (because you did the original YAML markup, I think) @MylesBorins Will this work?

Our 'ADDED' metadata is not granular enough. It tracks API additions, mostly, but it doesn't account for backporting though 00ffa33 gives me the impression it was intended to.

Since it doesn't track changes in APIs, will this note work? Will the FIXME (EDIT: <-- I meant REPLACEME) get processed?

This comment has been minimized.

@addaleax

addaleax Jan 31, 2017

Member

Will the FIXME (EDIT: <-- I meant REPLACEME) get processed?

Yup, the releaser will be warned by the build script (which does just a plain “grep”) and replace it.

Our 'ADDED' metadata is not granular enough.

Working on that! ;)

@addaleax

addaleax Jan 31, 2017

Member

Will the FIXME (EDIT: <-- I meant REPLACEME) get processed?

Yup, the releaser will be warned by the build script (which does just a plain “grep”) and replace it.

Our 'ADDED' metadata is not granular enough.

Working on that! ;)

Show outdated Hide outdated lib/child_process.js
case 'inherit':
return [option, option, option, 'ipc'];
}
throw new TypeError('Incorrect value of stdio option: ' + option);

This comment has been minimized.

@mscdex

mscdex Jan 30, 2017

Contributor

I think this should instead go inside a default: case in the switch above.

@mscdex

mscdex Jan 30, 2017

Contributor

I think this should instead go inside a default: case in the switch above.

child_process: align fork/spawn stdio error msg
fork()'s support for .stdio strings in 3268863 used a different
TypeError string from spawn, unnecessarily.
@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github
Member

sam-github commented Jan 31, 2017

PTAL @mscdex

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex
Contributor

mscdex commented Feb 1, 2017

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Feb 1, 2017

Member

ci: https://ci.nodejs.org/job/node-test-pull-request/6150/

One of the freebsd machines failed a number of cluster tests. Trying again, may be ephemeral.

Member

sam-github commented Feb 1, 2017

ci: https://ci.nodejs.org/job/node-test-pull-request/6150/

One of the freebsd machines failed a number of cluster tests. Trying again, may be ephemeral.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 2, 2017

Member

The change LGTM but does this need to be semver-major? Are the error conditions changing here? It's not obvious

Member

jasnell commented Feb 2, 2017

The change LGTM but does this need to be semver-major? Are the error conditions changing here? It's not obvious

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 2, 2017

Member

Scratch that, the error message change definitely makes this semver-major

Member

jasnell commented Feb 2, 2017

Scratch that, the error message change definitely makes this semver-major

@jasnell

jasnell approved these changes Feb 2, 2017

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Feb 10, 2017

Member

Yeah, its semver major because it builds on #10866, which was semver major. Unfortunately, because its really a feature that would be nice to get backported.

What was the word on adding new property values to options?

If that is NOT semver-major, then we can do a backportable version of #10866

Member

sam-github commented Feb 10, 2017

Yeah, its semver major because it builds on #10866, which was semver major. Unfortunately, because its really a feature that would be nice to get backported.

What was the word on adding new property values to options?

If that is NOT semver-major, then we can do a backportable version of #10866

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 10, 2017

Member

Adding properties to options objects, so long as they are not required, is semver-minor.

Member

jasnell commented Feb 10, 2017

Adding properties to options objects, so long as they are not required, is semver-minor.

jasnell added a commit that referenced this pull request Feb 11, 2017

child_process: align fork/spawn stdio error msg
fork()'s support for .stdio strings in 3268863 used a different
TypeError string from spawn, unnecessarily.

PR-URL: #11044
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 11, 2017

Member

Landed in 4cafa60

Member

jasnell commented Feb 11, 2017

Landed in 4cafa60

@jasnell jasnell closed this Feb 11, 2017

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

child_process: align fork/spawn stdio error msg
fork()'s support for .stdio strings in 3268863 used a different
TypeError string from spawn, unnecessarily.

PR-URL: nodejs#11044
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@sam-github sam-github deleted the sam-github:revert-10866 branch Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment