New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: don't imply that we still do io.js releases #11054

Merged
merged 1 commit into from Feb 11, 2017

Conversation

@bnoordhuis
Member

bnoordhuis commented Jan 28, 2017

Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

cc @ChALkeR

@targos

targos approved these changes Jan 28, 2017

Show outdated Hide outdated README.md
Previous releases of Node.js have been signed with one of the following GPG
keys:
Previous releases of Node.js and io.js have been signed with one of the
following GPG keys:

This comment has been minimized.

@Fishrock123

Fishrock123 Jan 28, 2017

Member

Actually, this isn't correct. Most of the current keys were the ones used for signing io.js releases.

@Fishrock123

Fishrock123 Jan 28, 2017

Member

Actually, this isn't correct. Most of the current keys were the ones used for signing io.js releases.

This comment has been minimized.

@ChALkeR

ChALkeR Jan 30, 2017

Member

Perhaps with either one of those or one of the following GPG keys? I'm not sure that's the best way to say it, though.

@ChALkeR

ChALkeR Jan 30, 2017

Member

Perhaps with either one of those or one of the following GPG keys? I'm not sure that's the best way to say it, though.

This comment has been minimized.

@TimothyGu

TimothyGu Jan 30, 2017

Member

Or how about

-Releases of Node.js and io.js will be signed with one of the following GPG keys:
+Releases of Node.js will be signed with one of the following GPG keys, so have
+previous releases of io.js:

Not the most grammatically correct per se, but it is the most concise I can think of.

@TimothyGu

TimothyGu Jan 30, 2017

Member

Or how about

-Releases of Node.js and io.js will be signed with one of the following GPG keys:
+Releases of Node.js will be signed with one of the following GPG keys, so have
+previous releases of io.js:

Not the most grammatically correct per se, but it is the most concise I can think of.

This comment has been minimized.

@bnoordhuis

bnoordhuis Jan 30, 2017

Member

How about I drop the reference to io.js altogether?

@bnoordhuis

bnoordhuis Jan 30, 2017

Member

How about I drop the reference to io.js altogether?

This comment has been minimized.

@Fishrock123

Fishrock123 Jan 30, 2017

Member

Maybe put a line above this one that says: io.js releases may have been signed with any of the keys above or below.

I think hat may be the closest while still easy enough to understand.

@Fishrock123

Fishrock123 Jan 30, 2017

Member

Maybe put a line above this one that says: io.js releases may have been signed with any of the keys above or below.

I think hat may be the closest while still easy enough to understand.

This comment has been minimized.

@Trott

Trott Jan 31, 2017

Member

We don't support any of the io.js releases anymore anyway. So +1 on just saying Node.js and leaving it at that.

@Trott

Trott Jan 31, 2017

Member

We don't support any of the io.js releases anymore anyway. So +1 on just saying Node.js and leaving it at that.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 7, 2017

Member

Reworded, PTAL.

Member

bnoordhuis commented Feb 7, 2017

Reworded, PTAL.

@jasnell

jasnell approved these changes Feb 7, 2017

@targos

targos approved these changes Feb 7, 2017

@cjihrig

cjihrig approved these changes Feb 7, 2017

@ChALkeR

ChALkeR approved these changes Feb 8, 2017

LGTM =).

@danbev

danbev approved these changes Feb 8, 2017

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
Member

bnoordhuis commented Feb 8, 2017

@Fishrock123 LGTY?

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@bnoordhuis bnoordhuis closed this Feb 11, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:update-readme-release-language branch Feb 11, 2017

@bnoordhuis bnoordhuis merged commit 1062736 into nodejs:master Feb 11, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: drop "and io.js" from release section
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment