New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: extend URLSearchParams constructor #11060

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
7 participants
@TimothyGu
Member

TimothyGu commented Jan 28, 2017

In addition to URLSearchParams and USVString, support record<USVString, USVString> and sequence<sequence<USVString>> also.

Fixes: #10635
Refs: whatwg/url#175
Refs: web-platform-tests/wpt#4523

CI: https://ci.nodejs.org/job/node-test-pull-request/6089/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Show outdated Hide outdated doc/api/url.md

@TimothyGu TimothyGu referenced this pull request Jan 29, 2017

Closed

url: track status of a spec-compliant URLSearchParams #10821

11 of 11 tasks complete
@joyeecheung

Great work! Left a few comments, please take a look.

Show outdated Hide outdated lib/internal/url.js
Show outdated Hide outdated lib/internal/url.js
@@ -16,23 +16,24 @@ assert.strictEqual(params + '', 'a=b');
params = new URLSearchParams(params);
assert.strictEqual(params + '', 'a=b');
// URLSearchParams constructor, empty.
// URLSearchParams constructor, no arguments
params = new URLSearchParams();

This comment has been minimized.

@joyeecheung

joyeecheung Jan 29, 2017

Member

Do we have new URLSearchParams(null) test?

@joyeecheung

joyeecheung Jan 29, 2017

Member

Do we have new URLSearchParams(null) test?

This comment has been minimized.

@TimothyGu

TimothyGu Jan 29, 2017

Member

Not yet, nor do we have a new URLSearchParams(undefined) test. Both are added.

@TimothyGu

TimothyGu Jan 29, 2017

Member

Not yet, nor do we have a new URLSearchParams(undefined) test. Both are added.

Show outdated Hide outdated doc/api/url.md
@jasnell

Woohoo! happy to see this. Left a couple of comments but otherwise LGTM

Show outdated Hide outdated doc/api/url.md
Show outdated Hide outdated doc/api/url.md
@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jan 31, 2017

Member

@jasnell, done, PTAL. I also added some more examples for interoperation of URL and URLSearchParams in 25a60ad. Please take a look at that as well.

/cc @nodejs/url

Member

TimothyGu commented Jan 31, 2017

@jasnell, done, PTAL. I also added some more examples for interoperation of URL and URLSearchParams in 25a60ad. Please take a look at that as well.

/cc @nodejs/url

@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Jan 31, 2017

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Feb 1, 2017

Member

Landed in cc48f21, 29f7587, and c505b81.

Member

TimothyGu commented Feb 1, 2017

Landed in cc48f21, 29f7587, and c505b81.

@TimothyGu TimothyGu closed this Feb 1, 2017

@TimothyGu TimothyGu deleted the TimothyGu:urlsearchparams-ctor branch Feb 1, 2017

TimothyGu added a commit that referenced this pull request Feb 1, 2017

url: extend URLSearchParams constructor
PR-URL: #11060
Fixes: #10635
Ref: whatwg/url#175
Ref: web-platform-tests/wpt#4523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

TimothyGu added a commit that referenced this pull request Feb 1, 2017

tools: add MDN link for Iterable
PR-URL: #11060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

TimothyGu added a commit that referenced this pull request Feb 1, 2017

doc: document URLSearchParams constructor
PR-URL: #11060
Ref: whatwg/url#175
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@TimothyGu TimothyGu moved this from Landed in Spec to Done in WHATWG URL implementation Feb 1, 2017

@joyeecheung joyeecheung referenced this pull request Feb 1, 2017

Closed

url, test: synchronize web-platform-test url tests #11079

3 of 3 tasks complete

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 2, 2017

url: extend URLSearchParams constructor
PR-URL: nodejs#11060
Fixes: nodejs#10635
Ref: whatwg/url#175
Ref: web-platform-tests/wpt#4523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 2, 2017

tools: add MDN link for Iterable
PR-URL: nodejs#11060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 2, 2017

doc: document URLSearchParams constructor
PR-URL: nodejs#11060
Ref: whatwg/url#175
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@italoacasas italoacasas referenced this pull request Feb 18, 2017

Closed

(v7.x backport) URL-related changes #11457

4 of 4 tasks complete

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@TimothyGu TimothyGu referenced this pull request Apr 19, 2017

Merged

(v7.x backport) url: updates to the WHATWG URL parser #12507

4 of 4 tasks complete
@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Apr 19, 2017

Member

Added backport-requested for v7.x since it doesn't look like the spec is gonna change any time soon (re #11185 (comment)).

EDIT: it was backported in #12507, pending a merge there.

Member

TimothyGu commented Apr 19, 2017

Added backport-requested for v7.x since it doesn't look like the spec is gonna change any time soon (re #11185 (comment)).

EDIT: it was backported in #12507, pending a merge there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment