test: add path.join's test #11063

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@hiroppy
Member

hiroppy commented Jan 29, 2017

Add a test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and Array.from.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.
@lpinca

lpinca approved these changes Jan 29, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

hiroppy added a commit that referenced this pull request Feb 2, 2017

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Feb 2, 2017

Member

Landed in 81d1559.

Member

hiroppy commented Feb 2, 2017

Landed in 81d1559.

@hiroppy hiroppy closed this Feb 2, 2017

@hiroppy hiroppy deleted the hiroppy:feature/test-path branch Feb 2, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 2, 2017

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: nodejs#11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: nodejs#11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

would require a backport PR in order to land on v4 (if it should at all)

Member

jasnell commented Mar 7, 2017

would require a backport PR in order to land on v4 (if it should at all)

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: add path.join's test
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment