readline: update 6 comparisons to strict #11078

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
8 participants
@umairishaq
Contributor

umairishaq commented Jan 31, 2017

In readline.js, update 6 comparisons to strict comparisons.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Jan 31, 2017

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jan 31, 2017

Member

Those Windows failures look weird… /cc @Fishrock123 @zkat

Member

addaleax commented Jan 31, 2017

Those Windows failures look weird… /cc @Fishrock123 @zkat

@jasnell jasnell changed the title from readline: update 6 comparions to strict to readline: update 6 comparisons to strict Jan 31, 2017

@targos

targos approved these changes Jan 31, 2017

@Trott

Trott approved these changes Jan 31, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 31, 2017

Member

Definitely want a CI run for Windows on this. Should be able to do it once #11085 lands.

Member

Trott commented Jan 31, 2017

Definitely want a CI run for Windows on this. Should be able to do it once #11085 lands.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Jan 31, 2017

Member

Whoops, I rebased onto something that didn't have the fix in place so the build failed again.

Once more... CI (for Windows): https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/

Member

Trott commented Jan 31, 2017

Whoops, I rebased onto something that didn't have the fix in place so the build failed again.

Once more... CI (for Windows): https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 4, 2017

Member

Landed in b869eca – thanks for the PR!

Member

addaleax commented Feb 4, 2017

Landed in b869eca – thanks for the PR!

@addaleax addaleax closed this Feb 4, 2017

addaleax added a commit that referenced this pull request Feb 4, 2017

readline: update 6 comparions to strict
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 5, 2017

readline: update 6 comparions to strict
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

readline: update 6 comparions to strict
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

readline: update 6 comparions to strict
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

readline: update 6 comparions to strict
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

readline: update 6 comparions to strict
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

readline: update 6 comparions to strict
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

readline: update 6 comparions to strict
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment