Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
src: don't overwrite non-writable vm globals #11109
Another try for #10223.
This is @bnoordhuis reverted commit, without removing
The first assert in the test is different from the reverted commit, because
https://github.com/nodejs/node/blob/master/test/known_issues/test-vm-data-property-writable.js is still a known issue, because the property descriptor is taken from the sandbox not the vm context. The test is not testing that read-only properties are not overwritten, but that defineProperty works.